[fix](function) check return type is nullptr in FunctionBasePtr::build #49737

Mryange · 2025-04-01T08:00:07Z

What problem does this PR solve?

Some functions' implementations return a nullptr in case of an error, which can directly cause a core dump.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-04-01T08:00:12Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Mryange · 2025-04-01T08:00:20Z

run buildall

doris-robot · 2025-04-01T09:13:32Z

TPC-H: Total hot run time: 34161 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 04657806bcac6f4c454e331caf7b859b48a77c9f, data reload: false

------ Round 1 ----------------------------------
q1	26099	5051	4949	4949
q2	2088	281	189	189
q3	10380	1287	699	699
q4	10238	1000	523	523
q5	7568	2381	2333	2333
q6	193	163	131	131
q7	920	740	599	599
q8	9307	1311	1142	1142
q9	6840	5132	5085	5085
q10	6816	2317	1859	1859
q11	483	293	269	269
q12	352	351	219	219
q13	17780	3657	3048	3048
q14	238	236	213	213
q15	539	507	485	485
q16	615	645	584	584
q17	601	868	368	368
q18	7542	7236	7249	7236
q19	1214	948	559	559
q20	322	336	227	227
q21	4277	2687	2500	2500
q22	1003	1027	944	944
Total cold run time: 115415 ms
Total hot run time: 34161 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5093	5049	5043	5043
q2	238	323	233	233
q3	2166	2672	2286	2286
q4	1468	1808	1452	1452
q5	4570	4476	4406	4406
q6	214	172	122	122
q7	1993	1916	1701	1701
q8	2576	2551	2590	2551
q9	7272	7209	7062	7062
q10	2986	3164	2751	2751
q11	570	495	482	482
q12	709	763	607	607
q13	3460	3854	3266	3266
q14	278	310	283	283
q15	515	490	473	473
q16	655	667	624	624
q17	1144	1524	1395	1395
q18	7980	7611	7497	7497
q19	830	855	1094	855
q20	1954	2012	1860	1860
q21	5118	4721	4627	4627
q22	1050	994	992	992
Total cold run time: 52839 ms
Total hot run time: 50568 ms

doris-robot · 2025-04-01T09:25:07Z

TPC-DS: Total hot run time: 186241 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 04657806bcac6f4c454e331caf7b859b48a77c9f, data reload: false

query1	1018	503	471	471
query2	6525	2035	1947	1947
query3	6742	230	221	221
query4	25938	23321	22908	22908
query5	4354	627	465	465
query6	314	220	221	220
query7	4625	497	289	289
query8	291	242	238	238
query9	8597	2588	2591	2588
query10	447	321	269	269
query11	15345	15306	14767	14767
query12	166	110	110	110
query13	1661	527	396	396
query14	9274	6239	6217	6217
query15	207	187	161	161
query16	7562	622	531	531
query17	1183	731	569	569
query18	1988	396	309	309
query19	193	182	158	158
query20	121	121	113	113
query21	213	125	104	104
query22	4336	4366	4285	4285
query23	34038	32876	32977	32876
query24	8472	2364	2383	2364
query25	532	453	388	388
query26	1236	268	149	149
query27	2757	504	336	336
query28	4312	2439	2412	2412
query29	729	562	430	430
query30	286	221	193	193
query31	937	871	809	809
query32	74	67	61	61
query33	568	371	319	319
query34	800	865	513	513
query35	774	811	741	741
query36	942	993	911	911
query37	124	103	80	80
query38	4171	4280	4117	4117
query39	1459	1443	1380	1380
query40	213	120	104	104
query41	57	54	52	52
query42	121	109	105	105
query43	498	522	485	485
query44	1287	810	803	803
query45	179	175	181	175
query46	831	1030	627	627
query47	1793	1792	1729	1729
query48	390	427	324	324
query49	821	536	438	438
query50	638	686	413	413
query51	4193	4162	4132	4132
query52	112	112	104	104
query53	229	255	225	225
query54	571	563	511	511
query55	91	81	89	81
query56	303	301	285	285
query57	1136	1154	1075	1075
query58	264	257	261	257
query59	2780	2838	2685	2685
query60	333	324	302	302
query61	135	134	135	134
query62	791	752	654	654
query63	234	182	187	182
query64	4320	1006	692	692
query65	4344	4238	4265	4238
query66	1196	424	315	315
query67	15812	15459	15257	15257
query68	8192	884	518	518
query69	483	306	271	271
query70	1204	1039	1077	1039
query71	468	327	290	290
query72	5310	4742	4681	4681
query73	707	582	345	345
query74	9388	9031	8596	8596
query75	3881	3229	2688	2688
query76	3721	1244	803	803
query77	806	385	297	297
query78	10192	10194	9217	9217
query79	1944	808	562	562
query80	582	530	433	433
query81	483	258	225	225
query82	466	131	96	96
query83	259	251	246	246
query84	248	107	83	83
query85	801	350	405	350
query86	335	304	286	286
query87	4348	4413	4608	4413
query88	3363	2251	2238	2238
query89	386	321	282	282
query90	1942	222	223	222
query91	146	142	111	111
query92	79	61	57	57
query93	1127	945	585	585
query94	680	425	329	329
query95	375	292	283	283
query96	479	558	276	276
query97	3183	3215	3135	3135
query98	248	221	206	206
query99	1646	1387	1279	1279
Total cold run time: 274455 ms
Total hot run time: 186241 ms

doris-robot · 2025-04-01T09:30:24Z

ClickBench: Total hot run time: 31.15 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 04657806bcac6f4c454e331caf7b859b48a77c9f, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.10
query3	0.24	0.20	0.19
query4	1.59	0.20	0.20
query5	0.57	0.58	0.59
query6	1.21	0.72	0.72
query7	0.03	0.01	0.02
query8	0.04	0.03	0.03
query9	0.58	0.54	0.53
query10	0.55	0.60	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.60	0.60
query14	2.65	2.71	2.71
query15	0.92	0.85	0.84
query16	0.38	0.40	0.40
query17	1.01	1.08	1.03
query18	0.21	0.19	0.19
query19	1.91	1.97	1.86
query20	0.01	0.01	0.02
query21	15.37	0.89	0.55
query22	0.76	1.44	0.76
query23	14.75	1.37	0.65
query24	7.19	1.04	0.55
query25	0.47	0.14	0.15
query26	0.71	0.18	0.14
query27	0.04	0.05	0.05
query28	8.65	0.93	0.44
query29	12.53	3.94	3.33
query30	0.25	0.09	0.06
query31	2.83	0.58	0.39
query32	3.26	0.55	0.48
query33	3.08	3.04	3.05
query34	15.72	5.10	4.47
query35	4.48	4.47	4.50
query36	0.65	0.48	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.14
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 104.19 s
Total hot run time: 31.15 s

doris-robot · 2025-04-01T11:29:23Z

BE UT Coverage Report

Increment line coverage 87.50% (7/8) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	51.35% (13740/26760)
Line Coverage	40.71% (119650/293944)
Region Coverage	39.43% (60958/154604)
Branch Coverage	34.22% (30592/89394)

Mryange · 2025-04-01T12:01:23Z

run buildall

doris-robot · 2025-04-01T13:09:53Z

TPC-H: Total hot run time: 35223 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6b5e5c4a0cff50302f066ec61242b2b0806af111, data reload: false

------ Round 1 ----------------------------------
q1	26295	5259	5251	5251
q2	2095	285	189	189
q3	10385	1346	701	701
q4	10220	1115	559	559
q5	7541	2529	2731	2529
q6	197	175	133	133
q7	1004	775	604	604
q8	9328	1486	1290	1290
q9	6806	5401	5343	5343
q10	6881	2355	1902	1902
q11	498	280	270	270
q12	370	393	221	221
q13	17762	3821	3146	3146
q14	237	236	210	210
q15	540	484	480	480
q16	647	621	574	574
q17	586	916	359	359
q18	7678	7145	7195	7145
q19	1297	1105	587	587
q20	348	353	224	224
q21	4554	3449	2533	2533
q22	1059	1038	973	973
Total cold run time: 116328 ms
Total hot run time: 35223 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5462	5453	5466	5453
q2	252	350	234	234
q3	2184	2713	2345	2345
q4	1539	2002	1481	1481
q5	4579	4360	4373	4360
q6	256	183	131	131
q7	2053	1911	1719	1719
q8	2870	2805	2783	2783
q9	7245	7152	7123	7123
q10	3060	3217	2782	2782
q11	628	518	489	489
q12	702	775	626	626
q13	3563	4021	3275	3275
q14	278	319	265	265
q15	538	472	476	472
q16	667	701	649	649
q17	1198	1696	1469	1469
q18	7755	7465	7360	7360
q19	842	932	1148	932
q20	2037	2064	1841	1841
q21	5358	4812	4787	4787
q22	1100	1041	968	968
Total cold run time: 54166 ms
Total hot run time: 51544 ms

doris-robot · 2025-04-01T13:21:28Z

TPC-DS: Total hot run time: 186884 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6b5e5c4a0cff50302f066ec61242b2b0806af111, data reload: false

query1	1005	508	471	471
query2	6533	1961	1931	1931
query3	6742	222	218	218
query4	26088	23604	23483	23483
query5	4314	621	457	457
query6	317	223	199	199
query7	4615	497	274	274
query8	289	258	230	230
query9	8623	2559	2564	2559
query10	468	326	254	254
query11	15871	15125	14725	14725
query12	162	109	110	109
query13	1651	529	414	414
query14	8723	6165	6093	6093
query15	198	193	166	166
query16	7143	635	476	476
query17	960	752	597	597
query18	1970	388	297	297
query19	182	177	151	151
query20	116	118	119	118
query21	211	120	103	103
query22	4141	4238	4039	4039
query23	33889	32825	32826	32825
query24	8489	2356	2365	2356
query25	545	446	386	386
query26	1239	265	153	153
query27	2768	498	328	328
query28	4344	2439	2407	2407
query29	752	569	448	448
query30	284	218	181	181
query31	933	863	757	757
query32	77	65	66	65
query33	559	371	308	308
query34	776	850	513	513
query35	792	833	747	747
query36	982	989	891	891
query37	118	100	71	71
query38	4129	4343	4117	4117
query39	1446	1389	1399	1389
query40	220	117	107	107
query41	57	55	52	52
query42	119	111	101	101
query43	496	517	480	480
query44	1282	809	788	788
query45	183	173	169	169
query46	820	1005	611	611
query47	1779	1875	1738	1738
query48	380	399	295	295
query49	764	504	415	415
query50	631	689	408	408
query51	4160	4134	4101	4101
query52	114	106	102	102
query53	226	254	188	188
query54	565	600	522	522
query55	85	82	79	79
query56	299	308	278	278
query57	1124	1130	1084	1084
query58	273	281	269	269
query59	2582	2795	2807	2795
query60	335	335	305	305
query61	140	134	131	131
query62	785	746	686	686
query63	219	184	188	184
query64	4388	1013	697	697
query65	4307	4210	4253	4210
query66	1167	435	326	326
query67	15843	15386	15435	15386
query68	7803	877	511	511
query69	479	311	265	265
query70	1194	1123	1113	1113
query71	414	309	290	290
query72	5697	4880	4902	4880
query73	702	692	363	363
query74	8993	9116	8785	8785
query75	3394	3195	2716	2716
query76	3312	1183	787	787
query77	711	372	292	292
query78	10003	10005	9354	9354
query79	2444	861	569	569
query80	650	520	441	441
query81	504	252	231	231
query82	242	134	102	102
query83	258	254	235	235
query84	302	101	86	86
query85	775	347	319	319
query86	370	322	284	284
query87	4503	4493	4468	4468
query88	3992	2242	2212	2212
query89	391	309	285	285
query90	1966	229	224	224
query91	146	147	115	115
query92	81	62	58	58
query93	2371	937	574	574
query94	700	435	329	329
query95	380	305	286	286
query96	488	559	272	272
query97	3104	3245	3099	3099
query98	231	209	208	208
query99	1345	1398	1318	1318
Total cold run time: 273732 ms
Total hot run time: 186884 ms

doris-robot · 2025-04-01T13:26:49Z

ClickBench: Total hot run time: 30.99 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6b5e5c4a0cff50302f066ec61242b2b0806af111, data reload: false

query1	0.03	0.04	0.03
query2	0.11	0.11	0.11
query3	0.25	0.19	0.20
query4	1.59	0.20	0.10
query5	0.55	0.56	0.55
query6	1.20	0.70	0.72
query7	0.03	0.01	0.01
query8	0.04	0.03	0.03
query9	0.58	0.51	0.50
query10	0.62	0.61	0.58
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.60	0.60
query14	2.67	2.82	2.82
query15	0.93	0.84	0.85
query16	0.39	0.38	0.38
query17	1.07	1.06	1.03
query18	0.21	0.19	0.20
query19	2.08	1.82	1.84
query20	0.02	0.02	0.01
query21	15.37	0.91	0.54
query22	0.74	1.14	0.75
query23	14.89	1.41	0.62
query24	6.78	2.46	0.69
query25	0.49	0.08	0.16
query26	0.60	0.16	0.12
query27	0.05	0.05	0.05
query28	9.72	0.87	0.45
query29	12.65	3.92	3.29
query30	0.25	0.09	0.06
query31	2.82	0.60	0.38
query32	3.22	0.55	0.46
query33	2.99	2.99	3.07
query34	15.82	5.06	4.46
query35	4.54	4.54	4.52
query36	0.66	0.49	0.49
query37	0.08	0.06	0.07
query38	0.05	0.05	0.04
query39	0.03	0.02	0.02
query40	0.17	0.15	0.12
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.37 s
Total hot run time: 30.99 s

doris-robot · 2025-04-01T15:24:36Z

BE UT Coverage Report

Increment line coverage 41.18% (7/17) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	52.12% (13952/26769)
Line Coverage	40.79% (120015/294228)
Region Coverage	39.56% (61204/154694)
Branch Coverage	34.23% (30618/89454)

HappenLee

LGTM

github-actions · 2025-04-02T03:16:07Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-04-02T03:16:09Z

PR approved by anyone and no changes requested.

#49737) ### What problem does this PR solve? Some functions' implementations return a nullptr in case of an error, which can directly cause a core dump.

apache#49737) ### What problem does this PR solve? Some functions' implementations return a nullptr in case of an error, which can directly cause a core dump.

…asePtr::build #49737 (#49761)

…asePtr::build #49737 (#49762) #49737

apache#49737) ### What problem does this PR solve? Some functions' implementations return a nullptr in case of an error, which can directly cause a core dump.

upd

00647a5

Mryange force-pushed the function-check-return-type-null branch from 0465780 to 00647a5 Compare April 1, 2025 11:56

remove return

6b5e5c4

HappenLee approved these changes Apr 2, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2025

github-actions bot added the reviewed label Apr 2, 2025

yiguolei approved these changes Apr 2, 2025

View reviewed changes

yiguolei added p0_c dev/2.1.x dev/3.0.x labels Apr 2, 2025

yiguolei merged commit aba5f03 into apache:master Apr 2, 2025
27 of 29 checks passed

github-actions bot mentioned this pull request Apr 2, 2025

branch-3.0: [fix](function) check return type is nullptr in FunctionBasePtr::build #49737 #49758

Closed

github-actions bot mentioned this pull request Apr 2, 2025

branch-2.1: [fix](function) check return type is nullptr in FunctionBasePtr::build #49737 #49759

Closed

yiguolei added the usercase Important user case type label label Apr 2, 2025

Mryange mentioned this pull request Apr 2, 2025

branch-2.1: [fix](function) check return type is nullptr in FunctionBasePtr::build #49737 #49761

Merged

16 tasks

Mryange mentioned this pull request Apr 2, 2025

branch-3.0: [fix](function) check return type is nullptr in FunctionBasePtr::build #49737 #49762

Merged

16 tasks

yiguolei pushed a commit that referenced this pull request Apr 2, 2025

branch-2.1: [fix](function) check return type is nullptr in FunctionB…

145e393

…asePtr::build #49737 (#49761)

yiguolei added dev/2.1.10-merged and removed dev/2.1.x labels Apr 2, 2025

dataroaring pushed a commit that referenced this pull request Apr 9, 2025

branch-3.0: [fix](function) check return type is nullptr in FunctionB…

e4f5f18

…asePtr::build #49737 (#49762) #49737

dataroaring added dev/3.0.5-merged and removed dev/3.0.x labels Apr 9, 2025

gavinchou mentioned this pull request Apr 23, 2025

Release Notes 3.0.5 #50333

Closed

[fix](function) check return type is nullptr in FunctionBasePtr::build #49737

[fix](function) check return type is nullptr in FunctionBasePtr::build #49737

Uh oh!

Conversation

Mryange commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Apr 1, 2025

Uh oh!

Mryange commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

BE UT Coverage Report

Uh oh!

Mryange commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

Uh oh!

doris-robot commented Apr 1, 2025

BE UT Coverage Report

Uh oh!

HappenLee left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Mryange commented Apr 1, 2025 •

edited

Loading