Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Apr 2, 2025

What problem does this PR solve?

#49737

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Mryange added 2 commits April 2, 2025 12:37
apache#49737)

### What problem does this PR solve?

Some functions' implementations return a nullptr in case of an error,
which can directly cause a core dump.
@Mryange Mryange requested a review from yiguolei as a code owner April 2, 2025 04:40
@Thearas
Copy link
Contributor

Thearas commented Apr 2, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Apr 2, 2025

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 41.18% (7/17) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 38.18% (10060/26347)
Line Coverage 29.18% (82838/283841)
Region Coverage 27.86% (42593/152898)
Branch Coverage 24.47% (21576/88186)

@Mryange
Copy link
Contributor Author

Mryange commented Apr 2, 2025

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2025

PR approved by anyone and no changes requested.

@yiguolei yiguolei merged commit 145e393 into apache:branch-2.1 Apr 2, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants