Skip to content

Conversation

@Mryange
Copy link
Contributor

@Mryange Mryange commented Apr 2, 2025

What problem does this PR solve?

#49737

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

Mryange added 2 commits April 2, 2025 12:40
apache#49737)

### What problem does this PR solve?

Some functions' implementations return a nullptr in case of an error,
which can directly cause a core dump.
@Mryange Mryange requested a review from dataroaring as a code owner April 2, 2025 04:42
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Mryange
Copy link
Contributor Author

Mryange commented Apr 2, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39946 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 7a5554e9e7b5062db29f45f6fe592817ced04399, data reload: false

------ Round 1 ----------------------------------
q1	17606	6740	6568	6568
q2	2064	177	165	165
q3	10625	1050	1151	1050
q4	10554	734	729	729
q5	7737	2857	2786	2786
q6	224	134	131	131
q7	985	635	600	600
q8	9346	1935	2019	1935
q9	6605	6431	6483	6431
q10	7046	2298	2304	2298
q11	469	257	260	257
q12	394	212	209	209
q13	17777	3004	2972	2972
q14	242	217	211	211
q15	494	471	452	452
q16	653	574	581	574
q17	970	635	589	589
q18	7144	6848	6651	6651
q19	1480	1036	1055	1036
q20	469	197	208	197
q21	4160	3146	3246	3146
q22	1116	978	959	959
Total cold run time: 108160 ms
Total hot run time: 39946 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6645	6562	6574	6562
q2	339	231	224	224
q3	2882	2738	2882	2738
q4	2049	1807	1791	1791
q5	5735	5698	5688	5688
q6	233	134	128	128
q7	2163	1803	1786	1786
q8	3366	3579	3513	3513
q9	8893	8889	8885	8885
q10	3560	3542	3530	3530
q11	600	504	495	495
q12	808	620	608	608
q13	7674	3161	3223	3161
q14	319	272	289	272
q15	525	465	468	465
q16	701	656	634	634
q17	1832	1601	1598	1598
q18	8265	7863	7710	7710
q19	1654	1547	1502	1502
q20	2069	1870	1921	1870
q21	5461	5346	5310	5310
q22	1141	1044	1032	1032
Total cold run time: 66914 ms
Total hot run time: 59502 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196626 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7a5554e9e7b5062db29f45f6fe592817ced04399, data reload: false

query1	1291	914	885	885
query2	6295	2098	2043	2043
query3	10732	4253	4268	4253
query4	60997	28653	23346	23346
query5	5218	448	445	445
query6	405	177	174	174
query7	5464	308	309	308
query8	303	238	214	214
query9	8566	2615	2591	2591
query10	460	272	257	257
query11	17532	15112	15595	15112
query12	148	103	108	103
query13	1413	461	445	445
query14	10790	7042	7076	7042
query15	201	185	177	177
query16	7149	464	503	464
query17	1151	560	550	550
query18	1881	306	302	302
query19	210	151	148	148
query20	116	107	104	104
query21	205	103	100	100
query22	4650	4552	4644	4552
query23	34459	33640	34917	33640
query24	6159	2930	2938	2930
query25	516	411	403	403
query26	652	167	167	167
query27	1860	348	351	348
query28	4135	2436	2416	2416
query29	705	484	461	461
query30	234	170	165	165
query31	1018	854	840	840
query32	69	59	61	59
query33	408	307	303	303
query34	900	504	506	504
query35	855	737	709	709
query36	1109	975	989	975
query37	116	71	67	67
query38	4090	4016	4008	4008
query39	1525	1499	1468	1468
query40	213	100	101	100
query41	56	50	49	49
query42	121	114	107	107
query43	531	512	499	499
query44	1182	815	807	807
query45	192	167	172	167
query46	1162	710	721	710
query47	2021	1970	1929	1929
query48	478	414	384	384
query49	754	432	402	402
query50	834	427	432	427
query51	7361	7265	7150	7150
query52	104	92	89	89
query53	267	190	192	190
query54	570	472	479	472
query55	83	77	80	77
query56	279	257	268	257
query57	1286	1159	1182	1159
query58	217	215	215	215
query59	3348	3017	3055	3017
query60	271	253	257	253
query61	117	112	109	109
query62	780	682	666	666
query63	211	185	190	185
query64	1400	666	644	644
query65	3241	3287	3213	3213
query66	730	299	305	299
query67	16002	15527	15541	15527
query68	4203	562	584	562
query69	435	265	265	265
query70	1180	1105	1117	1105
query71	354	258	252	252
query72	6065	4053	3961	3961
query73	763	351	349	349
query74	10471	9043	8894	8894
query75	3340	2624	2651	2624
query76	2123	1132	1068	1068
query77	484	266	270	266
query78	10632	9645	9682	9645
query79	2165	602	594	594
query80	1328	417	427	417
query81	539	236	234	234
query82	1304	92	89	89
query83	163	141	143	141
query84	289	78	83	78
query85	1023	307	297	297
query86	390	274	306	274
query87	4423	4278	4410	4278
query88	3852	2405	2352	2352
query89	416	290	296	290
query90	1996	183	184	183
query91	184	148	149	148
query92	65	49	47	47
query93	2632	547	544	544
query94	787	292	293	292
query95	359	250	253	250
query96	614	278	279	278
query97	3349	3179	3159	3159
query98	214	210	205	205
query99	1612	1327	1304	1304
Total cold run time: 315552 ms
Total hot run time: 196626 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 41.18% (7/17) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.88% (10445/26191)
Line Coverage 30.52% (87535/286798)
Region Coverage 29.64% (45118/152206)
Branch Coverage 26.05% (22880/87844)

@doris-robot
Copy link

ClickBench: Total hot run time: 32.62 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7a5554e9e7b5062db29f45f6fe592817ced04399, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.63	0.10	0.10
query5	0.54	0.53	0.53
query6	1.13	0.74	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.57	0.54	0.55
query11	0.14	0.10	0.10
query12	0.14	0.11	0.12
query13	0.61	0.59	0.59
query14	2.71	2.73	2.75
query15	0.89	0.82	0.82
query16	0.40	0.39	0.39
query17	1.02	1.06	1.02
query18	0.24	0.21	0.22
query19	1.82	1.77	2.01
query20	0.01	0.02	0.01
query21	15.35	0.58	0.57
query22	3.08	2.48	1.72
query23	17.06	0.87	0.90
query24	3.63	1.69	1.59
query25	0.17	0.22	0.13
query26	0.61	0.14	0.13
query27	0.05	0.04	0.05
query28	8.84	0.50	0.51
query29	12.57	3.23	3.23
query30	0.24	0.06	0.06
query31	2.86	0.39	0.38
query32	3.27	0.46	0.45
query33	2.96	3.00	3.01
query34	17.11	4.48	4.43
query35	4.53	4.52	4.45
query36	0.66	0.47	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.04
query39	0.04	0.03	0.02
query40	0.17	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 106.28 s
Total hot run time: 32.62 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit e4f5f18 into apache:branch-3.0 Apr 9, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants