[fix](nereids) fix bug of MergePercentileToArray #49773

feiniaofeiafei · 2025-04-02T12:08:09Z

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #34313

Problem Summary:
When the second argument of percentile is not literal, will report error ：index out of range.
This pr fix this bug, taking the second argument of percentile directly, and changing the arguments of percentilearray from array literal to array expression.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

Thearas · 2025-04-02T12:08:14Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

feiniaofeiafei · 2025-04-02T12:08:40Z

run buildall

doris-robot · 2025-04-02T12:46:22Z

TPC-H: Total hot run time: 36262 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d5e322439020081dc6eaa5139a1332446ac7a89a, data reload: false

------ Round 1 ----------------------------------
q1	25724	5231	5226	5226
q2	2079	300	190	190
q3	10987	1346	729	729
q4	10219	1095	563	563
q5	7553	2671	2645	2645
q6	210	176	135	135
q7	1007	808	629	629
q8	9314	1500	1247	1247
q9	6860	5302	5305	5302
q10	6921	2390	1910	1910
q11	508	289	281	281
q12	360	403	225	225
q13	17756	3900	3097	3097
q14	239	232	211	211
q15	580	507	510	507
q16	625	610	599	599
q17	618	913	384	384
q18	7584	7258	7204	7204
q19	1235	1072	591	591
q20	349	349	239	239
q21	4784	4215	3404	3404
q22	1039	1007	944	944
Total cold run time: 116551 ms
Total hot run time: 36262 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5476	5507	5492	5492
q2	252	345	244	244
q3	2283	2872	2602	2602
q4	1618	2126	1610	1610
q5	4768	4598	4671	4598
q6	262	190	136	136
q7	2174	2024	1780	1780
q8	2946	2919	2901	2901
q9	6937	7102	7026	7026
q10	3170	3330	2829	2829
q11	641	539	512	512
q12	742	815	601	601
q13	3583	4155	3334	3334
q14	300	313	295	295
q15	545	498	487	487
q16	671	708	669	669
q17	1238	1698	1482	1482
q18	7869	7589	7399	7399
q19	841	850	929	850
q20	2037	2117	1882	1882
q21	5702	5100	4945	4945
q22	1099	1045	1026	1026
Total cold run time: 55154 ms
Total hot run time: 52700 ms

doris-robot · 2025-04-02T12:58:19Z

TPC-DS: Total hot run time: 194319 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d5e322439020081dc6eaa5139a1332446ac7a89a, data reload: false

query1	1404	1048	1065	1048
query2	6277	1891	1968	1891
query3	10946	4656	4671	4656
query4	25310	23735	23327	23327
query5	3744	700	489	489
query6	301	216	202	202
query7	3979	506	278	278
query8	298	263	228	228
query9	8476	2595	2581	2581
query10	473	323	266	266
query11	15332	15245	14905	14905
query12	165	110	105	105
query13	1548	526	386	386
query14	8392	6474	6243	6243
query15	217	195	178	178
query16	7124	648	415	415
query17	1003	742	588	588
query18	1987	434	331	331
query19	207	201	176	176
query20	128	126	127	126
query21	214	131	134	131
query22	4586	4524	4421	4421
query23	34314	33573	33531	33531
query24	8567	2514	2455	2455
query25	506	492	402	402
query26	1197	282	154	154
query27	2904	512	344	344
query28	4605	2455	2462	2455
query29	790	574	467	467
query30	290	224	202	202
query31	921	859	793	793
query32	78	70	66	66
query33	574	391	318	318
query34	826	907	549	549
query35	834	877	781	781
query36	979	1008	905	905
query37	133	110	84	84
query38	4308	4254	4169	4169
query39	1491	1439	1513	1439
query40	237	135	116	116
query41	60	57	60	57
query42	126	111	112	111
query43	514	507	487	487
query44	1391	831	833	831
query45	185	188	178	178
query46	878	1062	711	711
query47	1836	1839	1754	1754
query48	385	461	315	315
query49	755	563	458	458
query50	723	752	414	414
query51	4233	4383	4335	4335
query52	114	111	100	100
query53	230	285	197	197
query54	592	586	524	524
query55	86	85	85	85
query56	338	304	287	287
query57	1186	1171	1105	1105
query58	266	279	282	279
query59	2665	2891	2793	2793
query60	351	327	308	308
query61	139	131	139	131
query62	772	709	696	696
query63	246	190	189	189
query64	4283	1121	710	710
query65	4557	4373	4369	4369
query66	1145	423	320	320
query67	16267	15771	15414	15414
query68	8882	914	518	518
query69	473	319	272	272
query70	1169	1109	1105	1105
query71	469	330	299	299
query72	5819	4762	4928	4762
query73	730	670	355	355
query74	8925	9147	8891	8891
query75	4013	3181	2742	2742
query76	3723	1213	771	771
query77	803	383	291	291
query78	10242	10370	9336	9336
query79	2220	842	581	581
query80	613	534	455	455
query81	482	258	222	222
query82	532	136	98	98
query83	264	255	235	235
query84	295	103	92	92
query85	766	362	313	313
query86	379	293	300	293
query87	4393	4509	4337	4337
query88	3661	2246	2224	2224
query89	405	318	282	282
query90	1833	216	225	216
query91	149	142	118	118
query92	81	66	56	56
query93	1711	975	583	583
query94	662	434	317	317
query95	380	299	282	282
query96	497	614	282	282
query97	3193	3275	3132	3132
query98	239	212	201	201
query99	1413	1437	1299	1299
Total cold run time: 279404 ms
Total hot run time: 194319 ms

doris-robot · 2025-04-02T13:03:36Z

ClickBench: Total hot run time: 31.2 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d5e322439020081dc6eaa5139a1332446ac7a89a, data reload: false

query1	0.04	0.04	0.04
query2	0.12	0.11	0.10
query3	0.24	0.19	0.19
query4	1.58	0.19	0.20
query5	0.59	0.59	0.58
query6	1.19	0.73	0.71
query7	0.03	0.02	0.02
query8	0.04	0.03	0.03
query9	0.60	0.52	0.53
query10	0.58	0.59	0.58
query11	0.17	0.12	0.11
query12	0.15	0.11	0.11
query13	0.61	0.60	0.61
query14	2.82	2.81	2.84
query15	0.94	0.86	0.85
query16	0.39	0.37	0.38
query17	1.02	1.05	1.08
query18	0.21	0.19	0.21
query19	1.91	2.04	1.80
query20	0.02	0.01	0.01
query21	15.38	0.92	0.54
query22	0.75	1.22	0.68
query23	14.92	1.39	0.63
query24	6.80	1.38	0.72
query25	0.45	0.15	0.24
query26	0.65	0.17	0.14
query27	0.05	0.04	0.04
query28	9.13	0.94	0.44
query29	12.53	3.92	3.27
query30	0.25	0.10	0.06
query31	2.82	0.58	0.38
query32	3.22	0.55	0.47
query33	3.11	3.09	3.06
query34	15.73	5.07	4.50
query35	4.54	4.50	4.45
query36	0.66	0.50	0.48
query37	0.08	0.06	0.06
query38	0.06	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.14	0.14
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.72 s
Total hot run time: 31.2 s

github-actions · 2025-04-03T06:49:44Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-04-03T06:49:45Z

PR approved by anyone and no changes requested.

feiniaofeiafei · 2025-04-18T09:12:27Z

run buildall

doris-robot · 2025-04-18T09:41:51Z

TPC-H: Total hot run time: 33838 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit d69abdd530a2be6e9fac5335131e05dac2eb8ff6, data reload: false

------ Round 1 ----------------------------------
q1	25826	5030	4985	4985
q2	2065	297	188	188
q3	10386	1219	680	680
q4	10219	1061	516	516
q5	7508	2351	2334	2334
q6	185	164	134	134
q7	918	751	630	630
q8	9320	1250	1076	1076
q9	6871	5118	5086	5086
q10	6835	2267	1883	1883
q11	486	284	268	268
q12	355	367	224	224
q13	17778	3823	3091	3091
q14	224	233	210	210
q15	531	481	482	481
q16	448	448	414	414
q17	597	853	384	384
q18	7484	7162	7057	7057
q19	1524	946	571	571
q20	331	335	222	222
q21	3995	3335	2431	2431
q22	1065	1015	973	973
Total cold run time: 114951 ms
Total hot run time: 33838 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5161	5084	5107	5084
q2	236	328	237	237
q3	2152	2637	2282	2282
q4	1451	1839	1406	1406
q5	4428	4411	4364	4364
q6	224	170	131	131
q7	1980	1882	1761	1761
q8	2554	2656	2577	2577
q9	7234	7165	7031	7031
q10	2994	3183	2729	2729
q11	580	525	484	484
q12	738	751	617	617
q13	3576	3875	3269	3269
q14	284	288	298	288
q15	530	472	478	472
q16	461	522	452	452
q17	1150	1533	1378	1378
q18	7634	7472	7334	7334
q19	825	840	969	840
q20	1971	2029	1887	1887
q21	5146	4970	4833	4833
q22	1089	1046	1012	1012
Total cold run time: 52398 ms
Total hot run time: 50468 ms

doris-robot · 2025-04-18T09:54:05Z

TPC-DS: Total hot run time: 193200 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit d69abdd530a2be6e9fac5335131e05dac2eb8ff6, data reload: false

query1	1409	1080	1070	1070
query2	6139	1787	1811	1787
query3	11055	4552	4429	4429
query4	54147	25118	23320	23320
query5	5149	617	470	470
query6	341	212	215	212
query7	4876	515	285	285
query8	321	246	233	233
query9	5676	2550	2554	2550
query10	442	335	264	264
query11	15196	15421	14891	14891
query12	165	113	106	106
query13	1034	518	400	400
query14	10166	6362	6325	6325
query15	202	194	168	168
query16	7096	638	496	496
query17	1108	748	612	612
query18	1542	416	339	339
query19	206	203	211	203
query20	132	130	120	120
query21	207	127	107	107
query22	4393	4411	4309	4309
query23	34098	33427	33359	33359
query24	6577	2427	2449	2427
query25	475	479	441	441
query26	716	273	163	163
query27	2314	514	357	357
query28	3243	2153	2141	2141
query29	609	553	428	428
query30	269	229	191	191
query31	869	890	781	781
query32	76	70	60	60
query33	442	368	312	312
query34	773	906	525	525
query35	801	825	762	762
query36	958	1011	896	896
query37	123	102	77	77
query38	4304	4165	4280	4165
query39	1484	1454	1494	1454
query40	198	117	109	109
query41	55	52	53	52
query42	133	113	115	113
query43	495	516	485	485
query44	1376	830	828	828
query45	185	175	172	172
query46	866	1043	692	692
query47	1836	1897	1784	1784
query48	395	423	305	305
query49	687	516	421	421
query50	689	707	413	413
query51	4219	4298	4179	4179
query52	117	112	101	101
query53	242	274	189	189
query54	592	595	506	506
query55	91	90	84	84
query56	316	316	299	299
query57	1171	1207	1116	1116
query58	265	265	259	259
query59	2671	2764	2705	2705
query60	353	324	306	306
query61	128	147	140	140
query62	742	771	692	692
query63	243	192	193	192
query64	2009	1046	718	718
query65	4427	4401	4385	4385
query66	715	407	307	307
query67	15742	15504	15247	15247
query68	6565	903	521	521
query69	539	309	262	262
query70	1208	1129	1095	1095
query71	492	325	285	285
query72	5839	4965	5047	4965
query73	1504	744	344	344
query74	8981	9150	8997	8997
query75	4223	3177	2705	2705
query76	4299	1334	769	769
query77	783	384	289	289
query78	10034	10036	9339	9339
query79	2041	881	577	577
query80	679	533	456	456
query81	466	262	219	219
query82	437	135	98	98
query83	256	257	232	232
query84	289	103	82	82
query85	780	352	314	314
query86	363	313	292	292
query87	4329	4407	4353	4353
query88	3484	2210	2229	2210
query89	405	326	289	289
query90	1908	218	219	218
query91	141	142	113	113
query92	73	67	57	57
query93	1527	977	587	587
query94	669	414	351	351
query95	372	296	313	296
query96	486	573	277	277
query97	3108	3251	3106	3106
query98	220	212	200	200
query99	1685	1403	1268	1268
Total cold run time: 298276 ms
Total hot run time: 193200 ms

doris-robot · 2025-04-18T09:59:17Z

ClickBench: Total hot run time: 29.97 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit d69abdd530a2be6e9fac5335131e05dac2eb8ff6, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.12
query3	0.25	0.20	0.20
query4	1.59	0.20	0.20
query5	0.60	0.59	0.60
query6	1.17	0.71	0.72
query7	0.03	0.02	0.01
query8	0.05	0.03	0.04
query9	0.57	0.53	0.52
query10	0.56	0.57	0.56
query11	0.15	0.11	0.11
query12	0.15	0.11	0.12
query13	0.60	0.60	0.59
query14	1.20	1.20	1.17
query15	0.90	0.86	0.86
query16	0.38	0.37	0.37
query17	1.01	1.05	1.03
query18	0.22	0.20	0.20
query19	1.87	1.79	1.72
query20	0.01	0.01	0.01
query21	15.45	0.93	0.54
query22	0.75	1.16	0.66
query23	14.96	1.40	0.69
query24	7.24	1.12	1.06
query25	0.50	0.22	0.06
query26	0.65	0.16	0.13
query27	0.06	0.05	0.07
query28	9.23	0.91	0.45
query29	12.52	4.13	3.47
query30	0.26	0.09	0.07
query31	2.82	0.60	0.38
query32	3.23	0.55	0.46
query33	3.00	3.00	3.06
query34	15.80	5.12	4.52
query35	4.58	4.55	4.50
query36	0.67	0.51	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.02	0.02	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.03	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.66 s
Total hot run time: 29.97 s

morrySnow · 2025-04-24T07:29:00Z

fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/MergePercentileToArray.java

+
        for (Map.Entry<DistinctAndExpr, List<AggregateFunction>> entry : funcMap.entrySet()) {
-            List<Literal> literals = new ArrayList<>();
+            List<Expression> literals = new ArrayList<>();


rename this variable to a proper name

morrySnow · 2025-04-24T07:29:47Z

fe/fe-core/src/main/java/org/apache/doris/nereids/rules/rewrite/MergePercentileToArray.java

-                literals.add((Literal) literal.get(0));
+                literals.add(aggFunc.child(1));
            }
-            ArrayLiteral arrayLiteral = new ArrayLiteral(literals);


if all expression are literal, generate a array literal directly for better performance

feiniaofeiafei · 2025-05-01T08:02:46Z

run buildall

doris-robot · 2025-05-01T08:44:33Z

TPC-H: Total hot run time: 34313 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 9b6e95599a656ad6779978fc7ce44cfe3507163c, data reload: false

------ Round 1 ----------------------------------
q1	25982	5099	5041	5041
q2	2065	269	180	180
q3	10408	1268	730	730
q4	10242	1009	541	541
q5	7516	2417	2371	2371
q6	199	170	140	140
q7	919	755	615	615
q8	9308	1335	1154	1154
q9	6878	5131	5090	5090
q10	6903	2313	1886	1886
q11	487	295	292	292
q12	362	373	221	221
q13	17778	3656	3145	3145
q14	237	226	207	207
q15	530	481	483	481
q16	415	439	392	392
q17	640	874	376	376
q18	7528	7242	7013	7013
q19	1609	935	576	576
q20	358	344	235	235
q21	4483	3511	2662	2662
q22	1055	986	965	965
Total cold run time: 115902 ms
Total hot run time: 34313 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5194	5142	5362	5142
q2	244	327	234	234
q3	2160	2625	2271	2271
q4	1402	1820	1494	1494
q5	4516	4397	4392	4392
q6	213	168	133	133
q7	2007	1918	1760	1760
q8	2610	2672	2608	2608
q9	7272	7122	7100	7100
q10	3004	3139	2794	2794
q11	575	506	503	503
q12	650	755	600	600
q13	3565	3961	3387	3387
q14	302	296	263	263
q15	515	472	470	470
q16	430	501	443	443
q17	1191	1543	1405	1405
q18	7757	7538	7402	7402
q19	863	947	946	946
q20	2016	1969	1805	1805
q21	5506	4802	4701	4701
q22	1103	1029	994	994
Total cold run time: 53095 ms
Total hot run time: 50847 ms

doris-robot · 2025-05-01T08:56:47Z

TPC-DS: Total hot run time: 192685 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 9b6e95599a656ad6779978fc7ce44cfe3507163c, data reload: false

query1	1399	1097	1059	1059
query2	6193	1788	1803	1788
query3	10967	4622	4409	4409
query4	51791	25844	23520	23520
query5	5290	608	472	472
query6	369	215	211	211
query7	4976	513	287	287
query8	346	266	247	247
query9	5864	2580	2569	2569
query10	448	333	265	265
query11	15087	14995	14844	14844
query12	160	113	109	109
query13	1101	521	402	402
query14	10162	6379	6479	6379
query15	194	202	181	181
query16	6997	659	493	493
query17	1087	780	629	629
query18	1543	425	332	332
query19	206	199	179	179
query20	130	128	124	124
query21	218	161	117	117
query22	4331	4490	4242	4242
query23	34175	33271	33451	33271
query24	6651	2454	2476	2454
query25	482	480	395	395
query26	766	278	160	160
query27	2357	524	349	349
query28	3006	2148	2107	2107
query29	599	549	433	433
query30	270	220	195	195
query31	882	852	798	798
query32	70	65	64	64
query33	465	362	310	310
query34	797	864	526	526
query35	806	853	760	760
query36	942	1026	920	920
query37	119	102	79	79
query38	4188	4246	4277	4246
query39	1529	1450	1441	1441
query40	208	120	104	104
query41	54	55	52	52
query42	125	105	114	105
query43	491	506	470	470
query44	1381	828	843	828
query45	194	171	170	170
query46	880	1020	642	642
query47	1850	1833	1780	1780
query48	398	441	317	317
query49	707	516	462	462
query50	659	696	416	416
query51	4226	4283	4237	4237
query52	113	112	97	97
query53	231	261	190	190
query54	624	602	549	549
query55	91	89	89	89
query56	316	310	291	291
query57	1161	1183	1108	1108
query58	270	270	263	263
query59	2734	2695	2668	2668
query60	340	346	311	311
query61	135	133	131	131
query62	726	733	663	663
query63	243	202	198	198
query64	2117	1055	729	729
query65	4475	4208	4240	4208
query66	727	394	308	308
query67	15689	15711	15236	15236
query68	6972	882	515	515
query69	529	304	265	265
query70	1163	1075	1045	1045
query71	503	316	295	295
query72	5978	4850	4904	4850
query73	1376	697	346	346
query74	8841	8863	8800	8800
query75	4024	3199	2684	2684
query76	4207	1184	744	744
query77	771	359	288	288
query78	10034	9927	9293	9293
query79	3600	822	548	548
query80	645	514	445	445
query81	482	253	212	212
query82	476	128	96	96
query83	318	257	236	236
query84	290	102	83	83
query85	809	351	371	351
query86	356	302	291	291
query87	4385	4358	4332	4332
query88	3647	2246	2254	2246
query89	437	320	281	281
query90	1966	215	216	215
query91	147	143	113	113
query92	76	59	57	57
query93	2593	955	583	583
query94	666	409	316	316
query95	368	302	291	291
query96	486	566	275	275
query97	3165	3227	3095	3095
query98	221	202	207	202
query99	1439	1394	1304	1304
Total cold run time: 299098 ms
Total hot run time: 192685 ms

doris-robot · 2025-05-01T09:01:56Z

ClickBench: Total hot run time: 29.06 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 9b6e95599a656ad6779978fc7ce44cfe3507163c, data reload: false

query1	0.04	0.04	0.04
query2	0.12	0.11	0.12
query3	0.24	0.20	0.19
query4	1.60	0.19	0.20
query5	0.61	0.59	0.59
query6	1.18	0.74	0.72
query7	0.03	0.01	0.02
query8	0.05	0.04	0.04
query9	0.57	0.52	0.51
query10	0.57	0.57	0.58
query11	0.15	0.10	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	0.79	0.81	0.80
query15	0.88	0.85	0.86
query16	0.38	0.38	0.41
query17	1.03	1.02	1.03
query18	0.22	0.20	0.20
query19	1.84	1.75	1.82
query20	0.01	0.01	0.01
query21	15.40	0.89	0.55
query22	0.77	1.34	0.98
query23	14.71	1.40	0.64
query24	7.19	1.04	0.44
query25	0.50	0.12	0.12
query26	0.61	0.17	0.13
query27	0.05	0.06	0.05
query28	9.37	0.93	0.42
query29	12.53	3.93	3.25
query30	0.25	0.09	0.06
query31	2.82	0.59	0.40
query32	3.22	0.54	0.46
query33	2.98	3.06	3.02
query34	15.98	5.11	4.45
query35	4.54	4.54	4.50
query36	0.67	0.51	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.09	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.14 s
Total hot run time: 29.06 s

github-actions · 2025-05-06T03:41:36Z

PR approved by at least one committer and no changes requested.

### What problem does this PR solve? Related PR: #34313 Problem Summary: When the second argument of percentile is not literal, will report error ：index out of range. This pr fix this bug, taking the second argument of percentile directly, and changing the arguments of percentilearray from array literal to array expression.

…50603) Cherry-picked from #49773 Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

…50602) Cherry-picked from #49773 Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

### What problem does this PR solve? Related PR: apache#34313 Problem Summary: When the second argument of percentile is not literal, will report error ：index out of range. This pr fix this bug, taking the second argument of percentile directly, and changing the arguments of percentilearray from array literal to array expression.

feiniaofeiafei force-pushed the test_grouping branch from cd7b12d to d5e3224 Compare April 2, 2025 12:08

morrySnow previously approved these changes Apr 3, 2025

View reviewed changes

morrySnow added dev/2.1.x dev/3.0.x labels Apr 3, 2025

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 3, 2025

github-actions bot added the reviewed label Apr 3, 2025

seawinde approved these changes Apr 9, 2025

View reviewed changes

morrySnow marked this pull request as draft April 10, 2025 03:49

feiniaofeiafei dismissed morrySnow’s stale review via 4509a6e April 18, 2025 09:11

feiniaofeiafei force-pushed the test_grouping branch 2 times, most recently from 4509a6e to d69abdd Compare April 18, 2025 09:12

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 18, 2025

feiniaofeiafei marked this pull request as ready for review April 21, 2025 02:05

morrySnow reviewed Apr 24, 2025

View reviewed changes

feiniaofeiafei added 3 commits May 1, 2025 15:22

fix

939acd8

add grouping support

9ea97f9

cast to ArrayLiteral if can

57d13e3

feiniaofeiafei force-pushed the test_grouping branch from d69abdd to 57d13e3 Compare May 1, 2025 07:49

use castIfNotSameType

9b6e955

morrySnow approved these changes May 6, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label May 6, 2025

morrySnow merged commit 9f4802c into apache:master May 6, 2025
23 of 24 checks passed

github-actions bot mentioned this pull request May 6, 2025

branch-3.0: [fix](nereids) fix bug of MergePercentileToArray #49773 #50602

Merged

github-actions bot mentioned this pull request May 6, 2025

branch-2.1: [fix](nereids) fix bug of MergePercentileToArray #49773 #50603

Merged

yiguolei pushed a commit that referenced this pull request May 6, 2025

branch-2.1: [fix](nereids) fix bug of MergePercentileToArray #49773 (#…

c3812b3

…50603) Cherry-picked from #49773 Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

wm1581066 added dev/2.1.10-merged and removed dev/2.1.x labels May 6, 2025

dataroaring pushed a commit that referenced this pull request May 7, 2025

branch-3.0: [fix](nereids) fix bug of MergePercentileToArray #49773 (#…

5615d7d

…50602) Cherry-picked from #49773 Co-authored-by: feiniaofeiafei <moailing@selectdb.com>

dataroaring added dev/3.0.6-merged and removed dev/3.0.x labels May 7, 2025

[fix](nereids) fix bug of MergePercentileToArray #49773

[fix](nereids) fix bug of MergePercentileToArray #49773

Uh oh!

Conversation

feiniaofeiafei commented Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

Thearas commented Apr 2, 2025

Uh oh!

feiniaofeiafei commented Apr 2, 2025

Uh oh!

doris-robot commented Apr 2, 2025

Uh oh!

doris-robot commented Apr 2, 2025

Uh oh!

doris-robot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

github-actions bot commented Apr 3, 2025

Uh oh!

feiniaofeiafei commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

doris-robot commented Apr 18, 2025

Uh oh!

morrySnow Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

morrySnow Apr 24, 2025

Choose a reason for hiding this comment

Uh oh!

feiniaofeiafei commented May 1, 2025

Uh oh!

doris-robot commented May 1, 2025

Uh oh!

doris-robot commented May 1, 2025

Uh oh!

doris-robot commented May 1, 2025

Uh oh!

github-actions bot commented May 6, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

feiniaofeiafei commented Apr 2, 2025 •

edited

Loading