Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented May 6, 2025

Cherry-picked from #49773

### What problem does this PR solve?

Related PR: #34313 

Problem Summary:
When the second argument of percentile is not literal, will report error
:index out of range.
This pr fix this bug, taking the second argument of percentile directly,
and changing the arguments of percentilearray from array literal to
array expression.
@github-actions github-actions bot requested a review from dataroaring as a code owner May 6, 2025 03:51
@Thearas
Copy link
Contributor

Thearas commented May 6, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this May 6, 2025
@dataroaring dataroaring reopened this May 6, 2025
@Thearas
Copy link
Contributor

Thearas commented May 6, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40687 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2fd78807bc9e63e0cc967732161b06b2b3d06d6d, data reload: false

------ Round 1 ----------------------------------
q1	18705	7080	6705	6705
q2	2132	177	172	172
q3	10988	1149	1223	1149
q4	10497	807	770	770
q5	8393	3023	2908	2908
q6	226	137	140	137
q7	999	643	628	628
q8	9634	2023	2075	2023
q9	6744	6421	6393	6393
q10	7003	2288	2294	2288
q11	466	272	268	268
q12	421	213	219	213
q13	17803	3027	3016	3016
q14	260	214	210	210
q15	528	464	453	453
q16	642	593	592	592
q17	1008	647	606	606
q18	7296	6673	6706	6673
q19	1396	1053	1044	1044
q20	491	203	207	203
q21	4170	3240	3305	3240
q22	1075	1020	996	996
Total cold run time: 110877 ms
Total hot run time: 40687 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6667	6691	6578	6578
q2	324	239	236	236
q3	2993	3038	3061	3038
q4	2005	1801	1786	1786
q5	5730	5781	5713	5713
q6	221	134	128	128
q7	2210	1809	1826	1809
q8	3330	3515	3552	3515
q9	8907	8939	9015	8939
q10	3630	3572	3544	3544
q11	595	499	505	499
q12	819	629	606	606
q13	9288	3204	3211	3204
q14	317	270	272	270
q15	515	468	477	468
q16	701	656	643	643
q17	1872	1626	1608	1608
q18	8135	7717	7604	7604
q19	1752	1671	1532	1532
q20	2099	1902	1883	1883
q21	5634	5226	5268	5226
q22	1085	1015	984	984
Total cold run time: 68829 ms
Total hot run time: 59813 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 191836 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2fd78807bc9e63e0cc967732161b06b2b3d06d6d, data reload: false

query1	986	374	390	374
query2	6523	2057	2004	2004
query3	6706	233	223	223
query4	34171	23670	23863	23670
query5	4323	454	439	439
query6	280	202	214	202
query7	4641	333	326	326
query8	295	224	219	219
query9	9616	2640	2673	2640
query10	485	265	274	265
query11	18206	15270	15174	15174
query12	163	104	106	104
query13	1642	428	434	428
query14	10238	7156	7127	7127
query15	246	174	187	174
query16	8098	476	477	476
query17	1652	589	562	562
query18	2101	325	330	325
query19	241	176	174	174
query20	117	110	109	109
query21	214	105	108	105
query22	4502	4118	4176	4118
query23	34789	33518	34077	33518
query24	11801	2873	2796	2796
query25	716	422	411	411
query26	1809	180	180	180
query27	2904	360	349	349
query28	7950	2462	2471	2462
query29	1072	460	439	439
query30	350	171	174	171
query31	1044	802	819	802
query32	102	61	63	61
query33	802	311	298	298
query34	923	500	519	500
query35	919	713	722	713
query36	1133	940	986	940
query37	151	80	72	72
query38	3965	3850	3829	3829
query39	1512	1436	1442	1436
query40	294	107	103	103
query41	54	57	53	53
query42	115	106	101	101
query43	538	500	495	495
query44	1284	797	816	797
query45	188	171	168	168
query46	1150	721	743	721
query47	1941	1825	1853	1825
query48	475	377	393	377
query49	1291	423	415	415
query50	828	436	429	429
query51	7196	7076	7070	7070
query52	110	98	92	92
query53	266	194	190	190
query54	1263	490	485	485
query55	80	83	85	83
query56	287	254	269	254
query57	1257	1143	1125	1125
query58	241	211	217	211
query59	3078	2965	2868	2868
query60	288	258	247	247
query61	113	111	114	111
query62	880	704	683	683
query63	220	190	192	190
query64	5336	656	642	642
query65	3305	3216	3243	3216
query66	1435	317	312	312
query67	16058	15694	15764	15694
query68	4746	575	577	575
query69	446	272	276	272
query70	1176	1109	1103	1103
query71	414	261	264	261
query72	6453	4040	4015	4015
query73	767	354	357	354
query74	10193	9242	8844	8844
query75	3426	2617	2650	2617
query76	2917	1085	1069	1069
query77	492	271	272	271
query78	10682	9636	9710	9636
query79	1406	613	616	613
query80	962	453	445	445
query81	552	244	239	239
query82	962	97	90	90
query83	234	156	146	146
query84	235	88	86	86
query85	1293	306	291	291
query86	372	314	308	308
query87	4423	4283	4300	4283
query88	3745	2454	2440	2440
query89	413	297	292	292
query90	1932	193	185	185
query91	185	150	153	150
query92	60	49	55	49
query93	1114	574	560	560
query94	912	314	294	294
query95	372	268	259	259
query96	610	285	292	285
query97	3347	3138	3133	3133
query98	225	211	204	204
query99	1507	1329	1295	1295
Total cold run time: 303532 ms
Total hot run time: 191836 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 32.68 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2fd78807bc9e63e0cc967732161b06b2b3d06d6d, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.08
query4	1.61	0.11	0.10
query5	0.54	0.50	0.52
query6	1.14	0.74	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.57	0.50	0.51
query10	0.55	0.56	0.58
query11	0.15	0.11	0.10
query12	0.14	0.14	0.12
query13	0.61	0.61	0.60
query14	2.74	2.83	2.89
query15	0.91	0.84	0.84
query16	0.38	0.39	0.38
query17	1.07	1.06	1.05
query18	0.25	0.24	0.22
query19	1.89	1.82	1.98
query20	0.01	0.01	0.01
query21	15.38	0.60	0.57
query22	2.55	2.59	1.87
query23	16.89	1.10	0.77
query24	3.61	1.28	1.19
query25	0.20	0.06	0.08
query26	0.62	0.14	0.14
query27	0.06	0.04	0.03
query28	9.58	0.57	0.49
query29	12.62	3.29	3.26
query30	0.25	0.06	0.07
query31	2.85	0.41	0.39
query32	3.24	0.48	0.45
query33	3.01	3.07	3.08
query34	17.15	4.50	4.46
query35	4.61	4.53	4.54
query36	0.68	0.50	0.48
query37	0.08	0.06	0.07
query38	0.04	0.04	0.04
query39	0.04	0.02	0.03
query40	0.16	0.12	0.13
query41	0.09	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.75 s
Total hot run time: 32.68 s

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 5615d7d into branch-3.0 May 7, 2025
23 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-49773-branch-3.0 branch May 7, 2025 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants