Skip to content

[fix](restapi) Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And NODE RestAPI #50140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 26 commits into from
May 6, 2025
Merged

[fix](restapi) Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And NODE RestAPI #50140

yiguolei merged 26 commits into from
May 6, 2025

Conversation

@zhaorongsheng
Copy link
Contributor

@zhaorongsheng zhaorongsheng commented Apr 17, 2025 •
edited
Loading

What problem does this PR solve?

Issue Number: close #50138

Problem Summary:

Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And NODE RestAPI. Make it as same as the privileges of system default database information_schema.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhaorongsheng zhaorongsheng changed the title [fix](restapi) remove some permission checker about node config GET api [fix](restapi) Keep the permission verification in the node config GET API consistent with that of the SHOW statement. Apr 17, 2025
yiguolei
yiguolei previously approved these changes Apr 23, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 23, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 23, 2025

PR approved by anyone and no changes requested.

zddr
zddr reviewed Apr 24, 2025
View reviewed changes
zddr
zddr reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@zddr zddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified pr Description Explaining the Behavioral Changes，such as Permission Requirements for Executing SHOW FRONTENDS

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 24, 2025
@zhaorongsheng zhaorongsheng changed the title [fix](restapi) Keep the permission verification in the node config GET API consistent with that of the SHOW statement. [fix](restapi) Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And NODE RestAPI Apr 24, 2025
@zhaorongsheng
Copy link
Contributor Author

zhaorongsheng commented Apr 24, 2025

@zddr I have updated some codes. Would you mind reviewing it once again? Thanks~

zddr
zddr approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@zddr zddr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yiguolei
yiguolei previously approved these changes Apr 24, 2025
View reviewed changes
@yiguolei
Copy link
Contributor

yiguolei commented Apr 24, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 24, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 24, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 24, 2025
@yiguolei
Copy link
Contributor

yiguolei commented Apr 24, 2025

run buildall

@yiguolei yiguolei added usercase Important user case type label dev/2.1.x dev/3.0.x labels Apr 24, 2025
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@zhaorongsheng @koarz
[fix](restapi) Unify Permission Requirements for Executing SHOW FRONT…
1d1621a 
…ENDS/BACKENDS And NODE RestAPI (apache#50140)

### What problem does this PR solve?

Issue Number: close apache#50138 

Problem Summary:

Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And
NODE RestAPI. Make it as same as the privileges of system default
database `information_schema`.
zddr pushed a commit to zddr/incubator-doris that referenced this pull request Jun 24, 2025
@zhaorongsheng @zddr
[fix](restapi) Unify Permission Requirements for Executing SHOW FRONT…
36b2589 
…ENDS/BACKENDS And NODE RestAPI (apache#50140)

Issue Number: close apache#50138

Problem Summary:

Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And
NODE RestAPI. Make it as same as the privileges of system default
database `information_schema`.
@zddr zddr mentioned this pull request Jun 24, 2025
Merged
zddr pushed a commit to zddr/incubator-doris that referenced this pull request Jun 24, 2025
@zhaorongsheng @zddr
[fix](restapi) Unify Permission Requirements for Executing SHOW FRONT…
26dcdcb 
…ENDS/BACKENDS And NODE RestAPI (apache#50140)

Issue Number: close apache#50138

Problem Summary:

Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And
NODE RestAPI. Make it as same as the privileges of system default
database `information_schema`.
@zddr zddr mentioned this pull request Jun 24, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 26, 2025
@zddr @zhaorongsheng
branch-3.1:[fix](restapi) Unify Permission Requirements for Executing…
cc2df46 
… SHOW FRONTENDS/BACKENDS And NODE RestAPI #50140 (#52230)

Cherry pick from #50140

---------

Co-authored-by: zhaorongsheng <zhaorongsheng@users.noreply.github.com>
dataroaring pushed a commit that referenced this pull request Jul 7, 2025
@zddr @zhaorongsheng
branch-3.0:[fix](restapi) Unify Permission Requirements for Executing…
4177ad9 
… SHOW FRONT… (#52226)

…ENDS/BACKENDS And NODE RestAPI (#50140)

pick: #50140

---------

Co-authored-by: zhaorongsheng <zhaorongsheng@users.noreply.github.com>
@zddr zddr mentioned this pull request Jul 15, 2025
Merged
16 tasks
morrySnow pushed a commit that referenced this pull request Jul 16, 2025
@zddr
[fix](case) fix regression case test_cluster_management_auth (#53336)
5a756ef 
Related PR: #50140
github-actions bot pushed a commit that referenced this pull request Jul 16, 2025
@zddr
[fix](case) fix regression case test_cluster_management_auth (#53336)
5e7e2d8 
Related PR: #50140
github-actions bot pushed a commit that referenced this pull request Jul 16, 2025
@zddr
[fix](case) fix regression case test_cluster_management_auth (#53336)
bd592fe 
Related PR: #50140
@zddr zddr mentioned this pull request Aug 14, 2025
Merged
8 tasks
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
morrySnow pushed a commit to apache/doris-website that referenced this pull request Dec 2, 2025
@zddr
[auth]Unify Permission Requirements for Executing SHOW FRONTENDS/BACK…
2c823aa 
…ENDS (#2750)

doris pr: apache/doris#50140

## Versions 

- [x] dev
- [x] 3.0
- [ ] 2.1
- [ ] 2.0

## Languages

- [x] Chinese
- [x] English

## Docs Checklist

- [ ] Checked by AI
- [ ] Test Cases Built
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

+1 more reviewer

@zddr zddr zddr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged kind/behavior-changed reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] privilege checking about node manager rest api

7 participants

@zhaorongsheng @hello-stephen @yiguolei @doris-robot @zddr @dataroaring @morrySnow