Skip to content

branch-3.0:[fix](restapi) Unify Permission Requirements for Executing SHOW FRONT… #52226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jul 7, 2025
Merged

branch-3.0:[fix](restapi) Unify Permission Requirements for Executing SHOW FRONT… #52226

dataroaring merged 2 commits into from
Jul 7, 2025

Conversation

@zddr
Copy link
Contributor

@zddr zddr commented Jun 24, 2025

…ENDS/BACKENDS And NODE RestAPI (#50140)

pick: #50140

@zhaorongsheng @zddr
[fix](restapi) Unify Permission Requirements for Executing SHOW FRONT…
36b2589 
…ENDS/BACKENDS And NODE RestAPI (apache#50140)

Issue Number: close apache#50138

Problem Summary:

Unify Permission Requirements for Executing SHOW FRONTENDS/BACKENDS And
NODE RestAPI. Make it as same as the privileges of system default
database `information_schema`.
@zddr zddr requested a review from dataroaring as a code owner June 24, 2025 09:58
@zddr
Copy link
Contributor Author

zddr commented Jun 24, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Jun 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zddr
Copy link
Contributor Author

zddr commented Jun 25, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-H: Total hot run time: 39872 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 262ff662c83681fb10972d53fe15a1c00bf832f6, data reload: false

------ Round 1 ----------------------------------
q1	17580	6704	6581	6581
q2	2075	173	169	169
q3	10777	1090	1199	1090
q4	10454	774	739	739
q5	7743	2863	2787	2787
q6	215	135	137	135
q7	965	621	618	618
q8	9359	1955	2054	1955
q9	6571	6398	6455	6398
q10	7053	2302	2300	2300
q11	467	268	272	268
q12	417	223	215	215
q13	17809	2978	2980	2978
q14	237	207	207	207
q15	530	455	468	455
q16	509	379	384	379
q17	987	550	573	550
q18	7244	6663	6610	6610
q19	1440	1081	1069	1069
q20	498	198	203	198
q21	3933	3195	3173	3173
q22	1070	1004	998	998
Total cold run time: 107933 ms
Total hot run time: 39872 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6642	6579	6570	6570
q2	336	245	231	231
q3	2871	2714	2889	2714
q4	2064	1786	1769	1769
q5	5783	5712	5747	5712
q6	217	140	133	133
q7	2246	1832	1772	1772
q8	3389	3580	3571	3571
q9	8973	8785	8875	8785
q10	3582	3489	3504	3489
q11	598	503	496	496
q12	813	587	592	587
q13	9338	3137	3211	3137
q14	307	270	270	270
q15	514	465	464	464
q16	515	450	467	450
q17	1856	1626	1644	1626
q18	8138	7795	7714	7714
q19	1737	1567	1569	1567
q20	2172	1861	1808	1808
q21	5125	5139	4975	4975
q22	1129	1051	1057	1051
Total cold run time: 68345 ms
Total hot run time: 58891 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-DS: Total hot run time: 197038 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 262ff662c83681fb10972d53fe15a1c00bf832f6, data reload: false

query1	1321	929	885	885
query2	6357	2037	2024	2024
query3	10862	4329	4568	4329
query4	60928	29961	23499	23499
query5	5218	468	456	456
query6	393	177	178	177
query7	5524	326	315	315
query8	316	240	227	227
query9	8677	2551	2556	2551
query10	472	278	263	263
query11	17614	15112	15726	15112
query12	184	110	115	110
query13	1450	441	425	425
query14	10244	6940	7875	6940
query15	215	180	190	180
query16	7082	497	505	497
query17	1149	603	625	603
query18	1889	330	328	328
query19	221	169	157	157
query20	118	110	108	108
query21	208	104	109	104
query22	4620	4418	4800	4418
query23	34573	34004	34311	34004
query24	6186	2988	2998	2988
query25	533	436	448	436
query26	662	178	181	178
query27	1909	359	362	359
query28	3895	2117	2105	2105
query29	711	488	436	436
query30	238	154	158	154
query31	1003	846	837	837
query32	64	59	55	55
query33	419	304	315	304
query34	949	516	530	516
query35	880	736	743	736
query36	1097	963	981	963
query37	110	68	70	68
query38	4085	4008	3998	3998
query39	1526	1523	1457	1457
query40	206	99	102	99
query41	49	59	48	48
query42	118	106	108	106
query43	543	492	521	492
query44	1203	803	818	803
query45	187	167	174	167
query46	1140	764	753	753
query47	2015	1857	1892	1857
query48	492	382	382	382
query49	732	403	404	403
query50	840	436	450	436
query51	7419	7295	7244	7244
query52	101	98	95	95
query53	277	186	187	186
query54	584	455	463	455
query55	82	86	79	79
query56	271	261	248	248
query57	1306	1214	1174	1174
query58	240	227	230	227
query59	3241	3105	3152	3105
query60	320	298	279	279
query61	107	122	110	110
query62	789	692	689	689
query63	241	200	212	200
query64	1433	671	623	623
query65	3298	3175	3205	3175
query66	692	300	296	296
query67	15925	15463	15445	15445
query68	4224	584	573	573
query69	433	272	271	271
query70	1183	1130	1137	1130
query71	340	261	256	256
query72	6343	4086	4163	4086
query73	760	345	354	345
query74	10365	9216	9019	9019
query75	3376	2596	2680	2596
query76	2038	1069	1167	1069
query77	483	279	287	279
query78	10678	9687	9489	9489
query79	2123	609	602	602
query80	1360	447	433	433
query81	530	223	225	223
query82	1272	88	88	88
query83	270	144	144	144
query84	275	82	79	79
query85	1034	302	289	289
query86	381	306	267	267
query87	4461	4297	4251	4251
query88	3731	2383	2365	2365
query89	421	304	311	304
query90	1985	186	185	185
query91	185	149	167	149
query92	64	53	51	51
query93	2623	550	543	543
query94	777	300	299	299
query95	373	268	269	268
query96	633	283	286	283
query97	3331	3114	3118	3114
query98	220	199	196	196
query99	1575	1314	1321	1314
Total cold run time: 315600 ms
Total hot run time: 197038 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

ClickBench: Total hot run time: 30.27 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 262ff662c83681fb10972d53fe15a1c00bf832f6, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.61	0.11	0.10
query5	0.53	0.52	0.53
query6	1.15	0.73	0.73
query7	0.02	0.02	0.03
query8	0.04	0.03	0.03
query9	0.55	0.49	0.49
query10	0.54	0.55	0.54
query11	0.15	0.10	0.10
query12	0.14	0.12	0.11
query13	0.60	0.59	0.59
query14	0.77	0.80	0.83
query15	0.84	0.82	0.82
query16	0.36	0.38	0.41
query17	1.05	1.04	1.02
query18	0.24	0.23	0.22
query19	1.92	1.90	1.86
query20	0.01	0.00	0.01
query21	15.47	0.60	0.59
query22	2.31	2.11	1.27
query23	17.00	0.98	0.78
query24	2.96	1.83	1.53
query25	0.21	0.10	0.14
query26	0.45	0.14	0.14
query27	0.05	0.04	0.04
query28	9.23	0.50	0.52
query29	12.60	3.25	3.20
query30	0.25	0.06	0.06
query31	2.85	0.39	0.39
query32	3.23	0.48	0.47
query33	3.03	3.07	3.02
query34	16.86	4.46	4.43
query35	4.53	4.54	4.52
query36	0.68	0.49	0.48
query37	0.09	0.06	0.07
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.12
query41	0.09	0.02	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.06 s
Total hot run time: 30.27 s

@zddr
Copy link
Contributor Author

zddr commented Jun 25, 2025

run p0

@zddr
Copy link
Contributor Author

zddr commented Jun 25, 2025

run cloud_p0

dataroaring
dataroaring approved these changes Jul 7, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 4177ad9 into apache:branch-3.0 Jul 7, 2025
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zddr @Thearas @doris-robot @dataroaring @zhaorongsheng