Skip to content

[Bug](function) fix Could not find function explode_json_array_json_outer #50164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Apr 21, 2025
Merged

[Bug](function) fix Could not find function explode_json_array_json_outer #50164

yiguolei merged 1 commit into from
Apr 21, 2025

Conversation

@zhangstar333
Copy link
Contributor

@zhangstar333 zhangstar333 commented Apr 18, 2025 •
edited
Loading

What problem does this PR solve?

Problem Summary:
issue: #49946

the table function of outer is always nullable.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Apr 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@zhangstar333 zhangstar333 mentioned this pull request Apr 18, 2025
Closed
3 tasks
@zhangstar333
Copy link
Contributor Author

zhangstar333 commented Apr 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 18, 2025

TPC-H: Total hot run time: 34527 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit e628bfdafc5ae9f5d39beaec0a2f4ab8cc0f63b3, data reload: false

------ Round 1 ----------------------------------
q1	25841	5142	5145	5142
q2	2056	293	185	185
q3	10425	1263	715	715
q4	10220	1016	553	553
q5	8207	2418	2436	2418
q6	206	173	137	137
q7	950	806	637	637
q8	9322	1457	1200	1200
q9	6808	5163	5240	5163
q10	6910	2338	1900	1900
q11	500	294	265	265
q12	347	378	238	238
q13	17768	3762	3108	3108
q14	217	231	212	212
q15	534	499	491	491
q16	470	455	409	409
q17	605	904	362	362
q18	7540	7154	7116	7116
q19	1558	948	560	560
q20	329	339	222	222
q21	4291	3558	2544	2544
q22	1087	1021	950	950
Total cold run time: 116191 ms
Total hot run time: 34527 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5319	5200	5218	5200
q2	249	336	232	232
q3	2200	2680	2317	2317
q4	1504	2056	1555	1555
q5	4523	4428	4441	4428
q6	227	186	130	130
q7	2049	1929	1776	1776
q8	2835	2862	2764	2764
q9	7251	7048	7082	7048
q10	3094	3233	2803	2803
q11	626	508	498	498
q12	710	769	618	618
q13	3646	3966	3354	3354
q14	311	301	283	283
q15	531	477	484	477
q16	471	532	493	493
q17	1209	1745	1435	1435
q18	7782	7699	7493	7493
q19	892	867	907	867
q20	2005	2001	1843	1843
q21	5484	5098	4963	4963
q22	1073	1088	1007	1007
Total cold run time: 53991 ms
Total hot run time: 51584 ms

@doris-robot
Copy link

doris-robot commented Apr 18, 2025

TPC-DS: Total hot run time: 191703 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit e628bfdafc5ae9f5d39beaec0a2f4ab8cc0f63b3, data reload: false

query1	1398	1094	1072	1072
query2	6288	1794	1776	1776
query3	11187	4813	4713	4713
query4	25910	23843	22862	22862
query5	4962	603	451	451
query6	306	205	204	204
query7	3998	487	278	278
query8	310	251	238	238
query9	8535	2511	2543	2511
query10	497	315	259	259
query11	15294	14993	14894	14894
query12	161	107	107	107
query13	1558	521	385	385
query14	9626	6195	6075	6075
query15	218	189	165	165
query16	7608	597	480	480
query17	1159	774	572	572
query18	2026	403	310	310
query19	193	194	177	177
query20	127	123	143	123
query21	207	122	113	113
query22	4350	4377	4351	4351
query23	34412	33423	33635	33423
query24	8526	2409	2415	2409
query25	503	466	418	418
query26	1190	270	157	157
query27	2929	490	336	336
query28	4836	2111	2126	2111
query29	730	578	463	463
query30	278	224	193	193
query31	948	884	787	787
query32	74	65	61	61
query33	532	356	337	337
query34	809	876	532	532
query35	785	844	761	761
query36	957	1013	882	882
query37	115	100	75	75
query38	4205	4278	4210	4210
query39	1473	1436	1436	1436
query40	206	124	110	110
query41	52	55	51	51
query42	125	105	108	105
query43	513	489	484	484
query44	1307	812	837	812
query45	181	173	169	169
query46	844	1018	669	669
query47	1818	1891	1811	1811
query48	397	404	301	301
query49	757	502	436	436
query50	677	694	416	416
query51	4252	4342	4174	4174
query52	111	113	111	111
query53	232	260	190	190
query54	571	583	488	488
query55	80	80	81	80
query56	302	298	307	298
query57	1145	1191	1127	1127
query58	275	274	273	273
query59	2719	2727	2590	2590
query60	339	375	301	301
query61	130	139	123	123
query62	779	739	695	695
query63	224	190	185	185
query64	4411	1034	727	727
query65	4521	4349	4330	4330
query66	1052	406	303	303
query67	15923	15528	15281	15281
query68	7853	864	513	513
query69	443	302	271	271
query70	1156	1133	1097	1097
query71	446	315	289	289
query72	5709	4697	4678	4678
query73	535	583	341	341
query74	9244	8918	8920	8918
query75	3877	3181	2655	2655
query76	3117	1191	760	760
query77	761	365	272	272
query78	9912	10089	9251	9251
query79	2851	819	560	560
query80	627	498	423	423
query81	480	254	217	217
query82	447	126	94	94
query83	272	245	224	224
query84	290	104	87	87
query85	769	343	303	303
query86	427	301	298	298
query87	4393	4396	4312	4312
query88	3042	2171	2156	2156
query89	412	302	283	283
query90	1937	204	210	204
query91	140	139	111	111
query92	73	58	58	58
query93	1975	929	577	577
query94	660	413	280	280
query95	357	284	280	280
query96	475	560	271	271
query97	3123	3186	3118	3118
query98	219	211	206	206
query99	1468	1377	1249	1249
Total cold run time: 280653 ms
Total hot run time: 191703 ms

@doris-robot
Copy link

doris-robot commented Apr 18, 2025

ClickBench: Total hot run time: 29.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit e628bfdafc5ae9f5d39beaec0a2f4ab8cc0f63b3, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.19
query4	1.59	0.19	0.18
query5	0.58	0.59	0.58
query6	1.19	0.71	0.71
query7	0.02	0.02	0.01
query8	0.04	0.04	0.03
query9	0.58	0.53	0.51
query10	0.58	0.57	0.57
query11	0.15	0.11	0.10
query12	0.14	0.11	0.11
query13	0.61	0.59	0.60
query14	1.19	1.17	1.18
query15	0.86	0.84	0.85
query16	0.37	0.38	0.40
query17	1.01	1.03	1.02
query18	0.21	0.20	0.19
query19	1.92	1.77	1.74
query20	0.02	0.01	0.01
query21	15.44	0.89	0.53
query22	0.75	1.14	0.62
query23	15.03	1.39	0.62
query24	6.94	1.46	0.89
query25	0.51	0.18	0.07
query26	0.62	0.17	0.15
query27	0.05	0.05	0.05
query28	9.45	0.86	0.43
query29	12.54	3.98	3.34
query30	0.26	0.08	0.06
query31	2.83	0.60	0.39
query32	3.23	0.55	0.47
query33	3.00	3.01	3.10
query34	15.88	5.11	4.48
query35	4.55	4.54	4.54
query36	0.67	0.49	0.47
query37	0.08	0.06	0.06
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.17	0.15	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 103.69 s
Total hot run time: 29.49 s

@doris-robot
Copy link

doris-robot commented Apr 18, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.15% (14420/27132)
Line Coverage 42.01% (124961/297466)
Region Coverage 40.83% (63843/156382)
Branch Coverage 35.46% (32109/90540)

HappenLee
HappenLee approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Apr 21, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 21, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 21, 2025

BE Regression P0 && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 10.18% (2730/26829)
Line Coverage 7.66% (22812/297645)
Region Coverage 7.09% (12969/182986)
Branch Coverage 5.52% (5689/103098)

@yiguolei yiguolei added the usercase Important user case type label label Apr 21, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 21, 2025

BE Regression P0 && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 10.18% (2730/26829)
Line Coverage 7.66% (22812/297645)
Region Coverage 7.09% (12969/182986)
Branch Coverage 5.52% (5689/103098)

@yiguolei yiguolei merged commit c511f0c into apache:master Apr 21, 2025
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 21, 2025
@zhangstar333
[Bug](function) fix Could not find function explode_json_array_json_o…
21b4e2e 
…uter (#50164)

### What problem does this PR solve?
Problem Summary:
issue: #49946

the table function of outer is always nullable.
@github-actions github-actions bot mentioned this pull request Apr 21, 2025
Merged
github-actions bot pushed a commit that referenced this pull request Apr 21, 2025
@zhangstar333
[Bug](function) fix Could not find function explode_json_array_json_o…
d573829 
…uter (#50164)

### What problem does this PR solve?
Problem Summary:
issue: #49946

the table function of outer is always nullable.
@github-actions github-actions bot mentioned this pull request Apr 21, 2025
Merged
yiguolei pushed a commit that referenced this pull request Apr 23, 2025
@github-actions @zhangstar333
branch-2.1: [Bug](function) fix Could not find function explode_json_…
b0c8cb0 
…array_json_outer #50164 (#50227)

Cherry-picked from #50164

Co-authored-by: zhangstar333 <zhangsida@selectdb.com>
dataroaring pushed a commit that referenced this pull request Apr 25, 2025
@github-actions @zhangstar333
branch-3.0: [Bug](function) fix Could not find function explode_json_…
1659df5 
…array_json_outer #50164 (#50226)

Cherry-picked from #50164

Co-authored-by: zhangstar333 <zhangsida@selectdb.com>
@yiguolei yiguolei mentioned this pull request May 13, 2025
Closed
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@zhangstar333 @koarz
[Bug](function) fix Could not find function explode_json_array_json_o…
1a53ef6 
…uter (apache#50164)

### What problem does this PR solve?
Problem Summary:
issue: apache#49946

the table function of outer is always nullable.
@gavinchou gavinchou mentioned this pull request Jun 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

@HappenLee HappenLee HappenLee approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/2.1.10-merged dev/3.0.6-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@zhangstar333 @Thearas @doris-robot @hello-stephen @yiguolei @HappenLee @dataroaring