Skip to content

branch-3.0: [Bug](function) fix Could not find function explode_json_array_json_outer #50164 #50226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 25, 2025
Merged

branch-3.0: [Bug](function) fix Could not find function explode_json_array_json_outer #50164 #50226

dataroaring merged 1 commit into from
Apr 25, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Apr 21, 2025

Cherry-picked from #50164

@zhangstar333
[Bug](function) fix Could not find function explode_json_array_json_o…
21b4e2e 
…uter (#50164)

### What problem does this PR solve?
Problem Summary:
issue: #49946

the table function of outer is always nullable.
@github-actions github-actions bot requested a review from dataroaring as a code owner April 21, 2025 06:34
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Apr 21, 2025
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 21, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 21, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.12% (10511/26198)
Line Coverage 30.75% (88283/287058)
Region Coverage 29.86% (45490/152354)
Branch Coverage 26.22% (23057/87930)

@zhangstar333
Copy link
Contributor

zhangstar333 commented Apr 24, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Apr 24, 2025

TPC-H: Total hot run time: 39842 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 21b4e2e7bce1fcb0e7a628b8805057d97d532c97, data reload: false

------ Round 1 ----------------------------------
q1	17580	6672	6616	6616
q2	2054	177	166	166
q3	10662	1099	1199	1099
q4	10570	710	789	710
q5	7739	2828	2805	2805
q6	225	134	129	129
q7	963	603	600	600
q8	9360	1934	2042	1934
q9	6654	6399	6399	6399
q10	7025	2271	2242	2242
q11	471	265	274	265
q12	402	207	207	207
q13	17789	2977	2988	2977
q14	235	215	221	215
q15	500	469	467	467
q16	669	595	597	595
q17	977	622	537	537
q18	7171	6600	6799	6600
q19	1406	1116	999	999
q20	473	195	198	195
q21	3931	3214	3110	3110
q22	1069	1015	975	975
Total cold run time: 107925 ms
Total hot run time: 39842 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6697	6590	6581	6581
q2	333	228	232	228
q3	2897	2763	2938	2763
q4	2035	1763	1736	1736
q5	5754	5758	5716	5716
q6	215	126	127	126
q7	2203	1799	1837	1799
q8	3386	3562	3538	3538
q9	8967	8754	8913	8754
q10	3554	3490	3522	3490
q11	599	481	508	481
q12	782	577	606	577
q13	11135	3171	3159	3159
q14	304	285	271	271
q15	511	473	456	456
q16	694	650	669	650
q17	1837	1629	1624	1624
q18	8307	7902	7863	7863
q19	1658	1548	1506	1506
q20	2056	1828	1861	1828
q21	5556	5243	5165	5165
q22	1111	1063	1013	1013
Total cold run time: 70591 ms
Total hot run time: 59324 ms

@doris-robot
Copy link

doris-robot commented Apr 24, 2025

TPC-DS: Total hot run time: 196666 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 21b4e2e7bce1fcb0e7a628b8805057d97d532c97, data reload: false

query1	1293	890	915	890
query2	6243	2069	2017	2017
query3	10818	4456	4332	4332
query4	60806	32066	23633	23633
query5	4686	465	456	456
query6	386	192	179	179
query7	5403	317	319	317
query8	318	226	223	223
query9	8343	2623	2623	2623
query10	440	265	256	256
query11	16556	15166	15523	15166
query12	162	103	107	103
query13	1438	440	441	440
query14	10492	6741	6886	6741
query15	207	174	181	174
query16	7323	461	488	461
query17	1206	591	593	591
query18	1894	331	313	313
query19	216	169	159	159
query20	119	107	108	107
query21	211	100	102	100
query22	4712	4579	4398	4398
query23	34815	33846	34118	33846
query24	6208	2909	2921	2909
query25	528	397	392	392
query26	691	165	164	164
query27	2034	356	360	356
query28	4354	2439	2424	2424
query29	702	439	444	439
query30	256	168	162	162
query31	1004	811	827	811
query32	68	56	60	56
query33	398	272	283	272
query34	927	499	507	499
query35	886	767	751	751
query36	1096	962	985	962
query37	116	77	66	66
query38	4059	3962	3973	3962
query39	1543	1475	1488	1475
query40	205	94	98	94
query41	50	49	47	47
query42	114	102	102	102
query43	533	495	496	495
query44	1191	820	827	820
query45	185	172	175	172
query46	1138	716	732	716
query47	2002	1940	2004	1940
query48	476	386	386	386
query49	738	393	392	392
query50	854	422	462	422
query51	7344	7163	7324	7163
query52	103	89	88	88
query53	260	188	185	185
query54	567	466	475	466
query55	74	77	80	77
query56	272	247	263	247
query57	1263	1201	1166	1166
query58	222	223	221	221
query59	3205	3152	2916	2916
query60	274	248	244	244
query61	139	121	102	102
query62	787	679	687	679
query63	211	184	186	184
query64	1766	668	618	618
query65	3252	3221	3216	3216
query66	671	294	301	294
query67	15949	15648	15524	15524
query68	4067	574	581	574
query69	431	266	259	259
query70	1199	1087	1101	1087
query71	350	256	268	256
query72	6355	4064	4302	4064
query73	742	347	350	347
query74	10209	9011	8899	8899
query75	3373	2682	2695	2682
query76	1954	1117	1036	1036
query77	490	280	267	267
query78	10579	9608	9571	9571
query79	1303	590	591	590
query80	857	429	428	428
query81	519	239	237	237
query82	1309	86	86	86
query83	244	148	143	143
query84	286	78	82	78
query85	890	357	348	348
query86	332	312	263	263
query87	4482	4251	4215	4215
query88	3610	2402	2383	2383
query89	427	291	298	291
query90	1940	186	186	186
query91	197	161	185	161
query92	63	46	49	46
query93	1704	550	562	550
query94	728	282	300	282
query95	351	260	256	256
query96	621	279	275	275
query97	3263	3125	3229	3125
query98	213	197	205	197
query99	1582	1308	1283	1283
Total cold run time: 311472 ms
Total hot run time: 196666 ms

@doris-robot
Copy link

doris-robot commented Apr 24, 2025

ClickBench: Total hot run time: 32.45 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 21b4e2e7bce1fcb0e7a628b8805057d97d532c97, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.03	0.04
query3	0.23	0.06	0.07
query4	1.64	0.11	0.10
query5	0.51	0.52	0.53
query6	1.14	0.74	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.56	0.50	0.48
query10	0.55	0.54	0.56
query11	0.14	0.10	0.10
query12	0.14	0.10	0.11
query13	0.60	0.59	0.60
query14	2.82	2.71	2.84
query15	0.90	0.82	0.82
query16	0.37	0.38	0.38
query17	0.98	1.04	1.07
query18	0.24	0.21	0.23
query19	1.99	1.88	2.06
query20	0.02	0.01	0.01
query21	15.36	0.58	0.59
query22	2.53	3.29	1.76
query23	16.99	1.07	0.97
query24	3.12	1.81	1.28
query25	0.30	0.06	0.18
query26	0.48	0.14	0.14
query27	0.04	0.04	0.04
query28	9.45	0.54	0.46
query29	12.60	3.24	3.27
query30	0.26	0.06	0.06
query31	2.94	0.39	0.38
query32	3.26	0.45	0.46
query33	2.93	2.95	3.02
query34	17.06	4.44	4.52
query35	4.56	4.50	4.56
query36	0.68	0.48	0.47
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.03	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 106.02 s
Total hot run time: 32.45 s

dataroaring
dataroaring approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2025
@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 25, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor Author

github-actions bot commented Apr 25, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 1659df5 into branch-3.0 Apr 25, 2025
22 of 24 checks passed
@github-actions github-actions bot deleted the auto-pick-50164-branch-3.0 branch April 25, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hello-stephen @zhangstar333 @doris-robot @dataroaring