[fix](nereids) fix AND extract uniform slots #50265

yujun777 · 2025-04-22T01:58:27Z

What problem does this PR solve?

#44574 make AND's child size may exceeds 2, need consider.

Issue Number: close #xxx

Related PR: #44574

Problem Summary:

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

yujun777 · 2025-04-22T01:58:39Z

run buildall

hello-stephen · 2025-04-22T01:58:43Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

Copilot

Pull Request Overview

This PR fixes the uniform slot extraction functionality by updating the extraction algorithm for And expressions and adds corresponding unit tests. The key changes include:

Updating the ExpressionUtils.extractUniformSlot method to iterate over all children of an And expression.
Introducing a new unit test in ExpressionUtilsTest to verify the behavior of uniform slot extraction.
Refactoring the code for clarity and improved consistency in handling And expressions.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
fe/fe-core/src/test/java/org/apache/doris/nereids/util/ExpressionUtilsTest.java	Added a test (testExtractUniformSlot) to verify that uniform slots are correctly extracted from complex And expressions.
fe/fe-core/src/main/java/org/apache/doris/nereids/util/ExpressionUtils.java	Updated the uniform slot extraction, replacing hard-coded child references with iteration over all children of an And expression.

Comments suppressed due to low confidence (1)

fe/fe-core/src/test/java/org/apache/doris/nereids/util/ExpressionUtilsTest.java:197

Consider adding additional test cases to cover scenarios where the EqualTo expression does not satisfy the conditions for uniform slot extraction (e.g., when the first child is not injective or when the second child is non-constant).

@Test public void testExtractUniformSlot() {

github-actions · 2025-04-22T02:28:03Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-04-22T02:28:06Z

PR approved by anyone and no changes requested.

yujun777 · 2025-04-22T03:04:43Z

run buildall

doris-robot · 2025-04-22T03:29:32Z

TPC-H: Total hot run time: 33943 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 891ec92c110fe85b339449ec7f6614761b2a6dad, data reload: false

------ Round 1 ----------------------------------
q1	25916	5081	5074	5074
q2	2068	279	176	176
q3	10387	1255	678	678
q4	10228	998	532	532
q5	7559	2368	2334	2334
q6	181	163	132	132
q7	919	731	614	614
q8	9320	1307	1067	1067
q9	6990	5099	5034	5034
q10	6865	2300	1901	1901
q11	480	283	276	276
q12	354	351	220	220
q13	17757	3676	3095	3095
q14	219	227	212	212
q15	540	489	484	484
q16	456	441	408	408
q17	589	907	366	366
q18	7504	7120	7221	7120
q19	1606	949	563	563
q20	327	329	218	218
q21	4107	3362	2462	2462
q22	1064	1037	977	977
Total cold run time: 115436 ms
Total hot run time: 33943 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5273	5149	5102	5102
q2	248	331	226	226
q3	2150	2623	2296	2296
q4	1374	1837	1386	1386
q5	4456	4364	4387	4364
q6	216	170	123	123
q7	2020	1888	1793	1793
q8	2584	2521	2470	2470
q9	7270	7172	7052	7052
q10	3052	3155	2722	2722
q11	580	503	480	480
q12	678	748	624	624
q13	3492	3846	3360	3360
q14	295	307	289	289
q15	527	499	478	478
q16	482	511	468	468
q17	1160	1539	1395	1395
q18	7746	7680	7551	7551
q19	806	801	880	801
q20	1908	1956	1819	1819
q21	5350	4952	4856	4856
q22	1125	1072	1016	1016
Total cold run time: 52792 ms
Total hot run time: 50671 ms

github-actions · 2025-04-22T03:33:19Z

PR approved by at least one committer and no changes requested.

doris-robot · 2025-04-22T03:41:18Z

TPC-DS: Total hot run time: 191733 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 891ec92c110fe85b339449ec7f6614761b2a6dad, data reload: false

query1	1390	1066	1047	1047
query2	6193	1799	1782	1782
query3	11021	4428	4596	4428
query4	25572	23672	23246	23246
query5	5052	632	496	496
query6	304	191	178	178
query7	3984	484	269	269
query8	294	231	239	231
query9	8504	2553	2566	2553
query10	496	318	270	270
query11	15250	15021	14790	14790
query12	156	107	112	107
query13	1545	522	403	403
query14	8778	6085	6191	6085
query15	197	184	171	171
query16	7255	626	451	451
query17	1153	723	600	600
query18	2024	416	350	350
query19	209	207	178	178
query20	131	121	121	121
query21	210	125	117	117
query22	4462	4494	4282	4282
query23	34246	33647	33575	33575
query24	8240	2403	2402	2402
query25	495	456	390	390
query26	766	278	155	155
query27	2736	507	333	333
query28	4764	2183	2180	2180
query29	675	581	449	449
query30	269	218	190	190
query31	885	839	784	784
query32	77	64	62	62
query33	538	370	308	308
query34	805	889	539	539
query35	820	879	778	778
query36	958	994	885	885
query37	111	105	77	77
query38	4264	4208	4168	4168
query39	1471	1439	1424	1424
query40	216	123	109	109
query41	56	58	56	56
query42	121	105	106	105
query43	509	486	473	473
query44	1343	834	814	814
query45	183	177	182	177
query46	856	1024	641	641
query47	1815	1873	1856	1856
query48	388	412	302	302
query49	732	529	426	426
query50	655	700	427	427
query51	4167	4227	4153	4153
query52	113	112	102	102
query53	232	251	185	185
query54	601	593	518	518
query55	81	76	81	76
query56	295	304	284	284
query57	1143	1200	1117	1117
query58	262	274	260	260
query59	2613	2764	2629	2629
query60	332	339	334	334
query61	132	120	119	119
query62	752	716	662	662
query63	233	185	193	185
query64	3090	1023	724	724
query65	4404	4335	4353	4335
query66	906	396	307	307
query67	16304	15400	15315	15315
query68	8854	869	511	511
query69	515	291	266	266
query70	1166	1097	1075	1075
query71	475	318	291	291
query72	5155	4664	4652	4652
query73	702	564	340	340
query74	8919	9012	8654	8654
query75	4137	3183	2703	2703
query76	3780	1182	734	734
query77	788	382	293	293
query78	9917	10218	9230	9230
query79	1596	781	550	550
query80	574	498	452	452
query81	461	246	218	218
query82	421	121	94	94
query83	244	317	236	236
query84	248	100	98	98
query85	747	340	305	305
query86	325	307	311	307
query87	4386	4420	4271	4271
query88	2799	2222	2189	2189
query89	397	326	277	277
query90	1917	207	218	207
query91	141	140	111	111
query92	75	60	54	54
query93	1064	931	585	585
query94	684	405	308	308
query95	389	289	304	289
query96	480	567	281	281
query97	3115	3237	3138	3138
query98	219	212	204	204
query99	1446	1383	1265	1265
Total cold run time: 274970 ms
Total hot run time: 191733 ms

doris-robot · 2025-04-22T03:46:30Z

ClickBench: Total hot run time: 29.31 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 891ec92c110fe85b339449ec7f6614761b2a6dad, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.10	0.12
query3	0.24	0.20	0.19
query4	1.60	0.18	0.19
query5	0.59	0.58	0.59
query6	1.21	0.72	0.72
query7	0.02	0.02	0.01
query8	0.04	0.04	0.04
query9	0.58	0.52	0.50
query10	0.58	0.57	0.57
query11	0.15	0.10	0.10
query12	0.14	0.11	0.11
query13	0.62	0.59	0.60
query14	1.16	1.21	1.18
query15	0.87	0.85	0.84
query16	0.40	0.38	0.39
query17	1.06	1.03	1.06
query18	0.20	0.20	0.19
query19	1.90	1.87	1.75
query20	0.02	0.00	0.01
query21	15.42	0.88	0.56
query22	0.75	1.21	0.83
query23	14.77	1.36	0.64
query24	7.35	2.25	0.37
query25	0.32	0.12	0.13
query26	0.61	0.15	0.13
query27	0.06	0.05	0.05
query28	9.69	0.84	0.43
query29	12.53	3.97	3.34
query30	0.27	0.09	0.06
query31	2.85	0.59	0.39
query32	3.22	0.53	0.47
query33	2.96	3.09	3.15
query34	15.79	5.07	4.47
query35	4.51	4.53	4.48
query36	0.66	0.51	0.47
query37	0.09	0.06	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.14	0.14
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.04	0.03
Total cold run time: 103.77 s
Total hot run time: 29.31 s

yujun777 · 2025-04-22T03:53:50Z

run p0

yujun777 · 2025-04-22T06:15:23Z

run p0

yujun777 · 2025-04-22T06:15:33Z

run feut

yujun777 · 2025-04-22T07:48:36Z

run feut

yujun777 · 2025-04-22T08:40:18Z

run feut

yujun777 · 2025-04-22T09:17:56Z

run feut

yujun777 · 2025-04-22T10:02:32Z

run feut

yujun777 · 2025-04-22T11:17:07Z

run feut

yujun777 · 2025-04-23T01:57:43Z

run buildall

doris-robot · 2025-04-23T03:19:38Z

TPC-H: Total hot run time: 34155 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

------ Round 1 ----------------------------------
q1	26391	5225	5036	5036
q2	2060	316	206	206
q3	10332	1245	739	739
q4	10216	1005	533	533
q5	7524	2363	2344	2344
q6	187	172	130	130
q7	924	731	627	627
q8	9332	1223	1150	1150
q9	6884	5139	5111	5111
q10	6852	2326	1870	1870
q11	508	297	270	270
q12	353	366	218	218
q13	17786	3707	3128	3128
q14	237	233	212	212
q15	537	501	488	488
q16	450	455	410	410
q17	599	873	362	362
q18	7561	7228	7174	7174
q19	1549	954	555	555
q20	319	329	218	218
q21	3992	2629	2400	2400
q22	1074	1042	974	974
Total cold run time: 115667 ms
Total hot run time: 34155 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5156	5121	5326	5121
q2	240	324	231	231
q3	2160	2672	2332	2332
q4	1423	1807	1404	1404
q5	4480	4526	4389	4389
q6	220	170	132	132
q7	1973	1908	1784	1784
q8	2613	2520	2560	2520
q9	7235	7220	7075	7075
q10	2989	3197	2763	2763
q11	563	510	500	500
q12	709	786	616	616
q13	3624	3921	3352	3352
q14	295	326	290	290
q15	543	496	484	484
q16	471	511	465	465
q17	1147	1572	1412	1412
q18	7692	7636	7577	7577
q19	808	835	884	835
q20	2021	1965	1850	1850
q21	5315	4842	4716	4716
q22	1051	1073	991	991
Total cold run time: 52728 ms
Total hot run time: 50839 ms

doris-robot · 2025-04-23T03:31:29Z

TPC-DS: Total hot run time: 192539 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

query1	1427	1100	1056	1056
query2	6274	1797	1762	1762
query3	10990	4525	4653	4525
query4	25274	23871	22978	22978
query5	4826	640	447	447
query6	323	219	215	215
query7	3999	488	283	283
query8	303	254	239	239
query9	8540	2588	2625	2588
query10	495	324	267	267
query11	15274	15049	14802	14802
query12	165	108	108	108
query13	1550	519	386	386
query14	9117	6014	6208	6014
query15	205	189	177	177
query16	7351	639	471	471
query17	1132	694	602	602
query18	1998	412	320	320
query19	207	210	165	165
query20	128	124	120	120
query21	211	141	116	116
query22	4432	4545	4303	4303
query23	34654	33776	33547	33547
query24	8332	2436	2470	2436
query25	557	495	424	424
query26	732	282	200	200
query27	2724	506	344	344
query28	4649	2180	2154	2154
query29	628	578	440	440
query30	276	223	222	222
query31	903	927	790	790
query32	79	66	64	64
query33	540	379	330	330
query34	806	878	519	519
query35	826	858	768	768
query36	978	1019	902	902
query37	108	97	75	75
query38	4285	4359	4130	4130
query39	1547	1463	1477	1463
query40	218	125	113	113
query41	54	52	52	52
query42	122	105	110	105
query43	505	522	492	492
query44	1327	849	827	827
query45	190	181	170	170
query46	840	1037	651	651
query47	1829	1855	1825	1825
query48	376	402	309	309
query49	700	510	445	445
query50	652	697	410	410
query51	4226	4213	4251	4213
query52	109	116	101	101
query53	230	265	192	192
query54	588	574	525	525
query55	80	83	85	83
query56	285	304	308	304
query57	1181	1180	1130	1130
query58	277	278	276	276
query59	2691	2754	2609	2609
query60	334	327	306	306
query61	127	151	128	128
query62	758	736	665	665
query63	228	184	187	184
query64	3043	1106	710	710
query65	4455	4406	4361	4361
query66	1080	420	326	326
query67	15934	15463	15456	15456
query68	8802	876	502	502
query69	490	299	262	262
query70	1185	1115	1135	1115
query71	476	318	297	297
query72	5251	4762	4829	4762
query73	723	651	349	349
query74	8925	9109	8988	8988
query75	4113	3203	2710	2710
query76	3645	1190	749	749
query77	791	426	294	294
query78	10050	10188	9370	9370
query79	2273	820	564	564
query80	610	511	441	441
query81	480	256	224	224
query82	423	128	96	96
query83	275	255	234	234
query84	283	100	81	81
query85	762	347	306	306
query86	325	308	295	295
query87	4390	4402	4285	4285
query88	2940	2227	2203	2203
query89	406	326	274	274
query90	1907	205	206	205
query91	138	138	106	106
query92	71	56	57	56
query93	1224	964	584	584
query94	672	415	303	303
query95	369	289	284	284
query96	488	569	276	276
query97	3144	3232	3110	3110
query98	229	204	203	203
query99	1411	1426	1291	1291
Total cold run time: 276555 ms
Total hot run time: 192539 ms

doris-robot · 2025-04-23T03:36:41Z

ClickBench: Total hot run time: 29.96 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.12
query3	0.25	0.20	0.19
query4	1.58	0.20	0.19
query5	0.60	0.59	0.59
query6	1.17	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.57	0.52	0.50
query10	0.58	0.57	0.57
query11	0.15	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	1.20	1.17	1.20
query15	0.87	0.86	0.85
query16	0.40	0.38	0.37
query17	1.03	1.05	1.02
query18	0.22	0.20	0.20
query19	1.88	1.76	1.84
query20	0.01	0.01	0.02
query21	15.40	0.90	0.54
query22	0.77	1.20	0.96
query23	14.70	1.39	0.67
query24	7.14	1.47	0.84
query25	0.48	0.20	0.08
query26	0.63	0.17	0.15
query27	0.05	0.05	0.05
query28	9.80	0.86	0.43
query29	12.59	4.06	3.30
query30	0.25	0.09	0.07
query31	2.82	0.61	0.37
query32	3.22	0.55	0.47
query33	3.01	3.08	3.14
query34	15.62	5.11	4.49
query35	4.60	4.50	4.51
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.18	0.14	0.13
query41	0.09	0.03	0.03
query42	0.03	0.02	0.03
query43	0.04	0.03	0.03
Total cold run time: 103.72 s
Total hot run time: 29.96 s

yujun777 · 2025-04-23T06:28:29Z

run buildall

doris-robot · 2025-04-23T07:06:07Z

TPC-H: Total hot run time: 34619 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

------ Round 1 ----------------------------------
q1	26061	5052	5049	5049
q2	2066	280	190	190
q3	10381	1208	688	688
q4	10441	1018	556	556
q5	9116	2462	2333	2333
q6	185	164	135	135
q7	930	740	618	618
q8	9302	1299	1126	1126
q9	7992	5150	5187	5150
q10	6890	2368	1960	1960
q11	470	311	280	280
q12	369	367	230	230
q13	18907	4018	3354	3354
q14	254	243	225	225
q15	664	497	492	492
q16	462	466	400	400
q17	607	851	377	377
q18	7453	7301	7261	7261
q19	1768	970	558	558
q20	343	319	226	226
q21	4147	2647	2430	2430
q22	1032	991	981	981
Total cold run time: 119840 ms
Total hot run time: 34619 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5159	5049	5086	5049
q2	232	336	228	228
q3	2167	2612	2242	2242
q4	1534	1935	1476	1476
q5	4541	4390	4495	4390
q6	215	166	127	127
q7	1997	1942	1792	1792
q8	2569	2521	2533	2521
q9	7253	7019	7143	7019
q10	2978	3170	2749	2749
q11	566	501	516	501
q12	685	754	615	615
q13	3494	3942	3291	3291
q14	289	297	280	280
q15	521	469	466	466
q16	472	505	468	468
q17	1241	1533	1387	1387
q18	7669	7541	7460	7460
q19	800	815	836	815
q20	1882	1938	1872	1872
q21	5351	4836	4755	4755
q22	1116	1064	1012	1012
Total cold run time: 52731 ms
Total hot run time: 50515 ms

doris-robot · 2025-04-23T07:18:23Z

TPC-DS: Total hot run time: 191935 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

query1	1408	1096	1051	1051
query2	6164	1857	1858	1857
query3	11049	4526	4545	4526
query4	53641	25468	23263	23263
query5	5231	505	470	470
query6	358	210	197	197
query7	4887	512	290	290
query8	321	272	246	246
query9	5706	2550	2573	2550
query10	408	342	267	267
query11	15004	15127	14812	14812
query12	158	109	114	109
query13	1046	533	417	417
query14	10098	6277	6494	6277
query15	206	193	172	172
query16	7094	643	513	513
query17	1069	728	600	600
query18	1547	403	304	304
query19	190	185	159	159
query20	119	132	120	120
query21	238	124	110	110
query22	4432	4403	4253	4253
query23	34120	33379	33494	33379
query24	6574	2400	2420	2400
query25	454	462	402	402
query26	666	279	158	158
query27	2178	506	341	341
query28	3059	2137	2112	2112
query29	604	604	469	469
query30	274	228	193	193
query31	884	862	771	771
query32	78	67	76	67
query33	480	375	330	330
query34	775	864	512	512
query35	785	845	752	752
query36	940	1012	881	881
query37	122	103	79	79
query38	4186	4264	4144	4144
query39	1497	1441	1437	1437
query40	217	118	108	108
query41	55	52	53	52
query42	119	110	113	110
query43	500	505	457	457
query44	1318	849	826	826
query45	174	173	171	171
query46	834	1046	631	631
query47	1846	1913	1798	1798
query48	383	426	320	320
query49	687	512	432	432
query50	641	696	426	426
query51	4209	4244	4172	4172
query52	110	108	98	98
query53	221	264	183	183
query54	590	579	518	518
query55	82	82	84	82
query56	318	314	295	295
query57	1153	1196	1111	1111
query58	271	257	257	257
query59	2772	2795	2711	2711
query60	340	320	311	311
query61	129	125	134	125
query62	733	766	680	680
query63	230	188	191	188
query64	1475	1042	691	691
query65	4461	4365	4231	4231
query66	704	409	306	306
query67	15700	15625	15282	15282
query68	7511	861	495	495
query69	536	310	263	263
query70	1223	1114	1108	1108
query71	500	320	280	280
query72	5576	4734	4651	4651
query73	1449	572	338	338
query74	9268	9237	8901	8901
query75	3786	3206	2698	2698
query76	4274	1179	734	734
query77	633	375	278	278
query78	9907	9966	9207	9207
query79	6104	795	537	537
query80	660	513	430	430
query81	481	261	215	215
query82	667	138	98	98
query83	354	252	227	227
query84	293	122	84	84
query85	794	345	308	308
query86	349	303	287	287
query87	4364	4376	4348	4348
query88	3283	2217	2305	2217
query89	460	307	279	279
query90	1954	215	216	215
query91	146	147	113	113
query92	79	62	55	55
query93	2919	933	558	558
query94	693	411	311	311
query95	367	289	286	286
query96	491	574	269	269
query97	3181	3220	3108	3108
query98	229	210	200	200
query99	1422	1406	1275	1275
Total cold run time: 302275 ms
Total hot run time: 191935 ms

yujun777 · 2025-04-23T07:21:51Z

run feut

doris-robot · 2025-04-23T07:23:43Z

ClickBench: Total hot run time: 29.16 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.10	0.11
query3	0.25	0.19	0.19
query4	1.58	0.20	0.10
query5	0.57	0.55	0.55
query6	1.19	0.74	0.71
query7	0.02	0.02	0.02
query8	0.05	0.04	0.04
query9	0.58	0.53	0.53
query10	0.58	0.58	0.56
query11	0.16	0.11	0.11
query12	0.14	0.11	0.11
query13	0.61	0.59	0.59
query14	1.20	1.16	1.18
query15	0.86	0.85	0.84
query16	0.39	0.39	0.41
query17	1.02	1.04	1.06
query18	0.20	0.19	0.20
query19	1.90	1.82	1.81
query20	0.02	0.01	0.01
query21	15.39	0.92	0.56
query22	0.74	1.21	0.76
query23	14.85	1.39	0.55
query24	6.75	1.50	0.52
query25	0.51	0.20	0.07
query26	0.55	0.17	0.13
query27	0.06	0.05	0.04
query28	9.19	0.94	0.43
query29	12.56	3.96	3.31
query30	0.26	0.09	0.07
query31	2.81	0.60	0.38
query32	3.23	0.55	0.47
query33	3.02	3.05	3.04
query34	15.80	5.06	4.47
query35	4.46	4.53	4.48
query36	0.67	0.49	0.48
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.17	0.14	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 102.82 s
Total hot run time: 29.16 s

yujun777 · 2025-04-23T07:29:58Z

run feut

yujun777 · 2025-04-23T07:43:19Z

run cloud_p0

yujun777 · 2025-04-23T09:26:51Z

run buildall

doris-robot · 2025-04-23T09:48:38Z

TPC-H: Total hot run time: 34224 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

------ Round 1 ----------------------------------
q1	25813	5082	5056	5056
q2	2062	272	199	199
q3	10486	1264	717	717
q4	10256	1011	527	527
q5	8373	2436	2323	2323
q6	190	164	135	135
q7	907	748	617	617
q8	9314	1293	1115	1115
q9	6918	5150	5153	5150
q10	6830	2312	1924	1924
q11	458	278	261	261
q12	354	353	221	221
q13	17801	3726	3134	3134
q14	242	225	230	225
q15	530	488	485	485
q16	453	443	403	403
q17	603	841	371	371
q18	7509	7165	7106	7106
q19	1396	973	587	587
q20	337	335	228	228
q21	4319	3439	2485	2485
q22	1065	984	955	955
Total cold run time: 116216 ms
Total hot run time: 34224 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5175	5116	5528	5116
q2	244	321	226	226
q3	2178	2686	2337	2337
q4	1442	1807	1360	1360
q5	4255	4094	4129	4094
q6	208	161	127	127
q7	1897	1813	1661	1661
q8	2511	2488	2404	2404
q9	6798	6754	6819	6754
q10	2909	3110	2631	2631
q11	565	502	480	480
q12	667	706	593	593
q13	3372	3678	3185	3185
q14	266	285	267	267
q15	510	485	459	459
q16	456	493	461	461
q17	1098	1503	1351	1351
q18	7299	7354	7101	7101
q19	798	809	831	809
q20	1948	1974	1812	1812
q21	5147	4893	4657	4657
q22	1078	1035	966	966
Total cold run time: 50821 ms
Total hot run time: 48851 ms

doris-robot · 2025-04-23T10:00:12Z

TPC-DS: Total hot run time: 185734 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

query1	993	476	491	476
query2	6555	1775	1806	1775
query3	6771	212	217	212
query4	26237	23625	23315	23315
query5	5381	618	447	447
query6	285	193	194	193
query7	4629	482	283	283
query8	297	254	256	254
query9	8643	2568	2578	2568
query10	495	331	253	253
query11	15768	15051	14827	14827
query12	166	111	103	103
query13	1657	519	402	402
query14	11571	6061	6062	6061
query15	219	189	168	168
query16	7699	641	481	481
query17	1536	761	541	541
query18	2003	393	298	298
query19	224	185	150	150
query20	119	120	109	109
query21	212	123	103	103
query22	4304	4304	4015	4015
query23	34141	32908	33029	32908
query24	7082	2368	2350	2350
query25	509	457	379	379
query26	1228	268	144	144
query27	2555	473	325	325
query28	4403	2114	2101	2101
query29	727	532	426	426
query30	283	219	184	184
query31	919	860	769	769
query32	74	65	66	65
query33	558	402	304	304
query34	805	826	517	517
query35	786	808	737	737
query36	986	973	901	901
query37	110	107	72	72
query38	4103	4154	4147	4147
query39	1464	1403	1413	1403
query40	215	118	109	109
query41	57	59	53	53
query42	120	106	106	106
query43	482	506	475	475
query44	1269	799	815	799
query45	178	173	163	163
query46	812	1021	646	646
query47	1752	1804	1733	1733
query48	376	411	294	294
query49	778	543	454	454
query50	644	680	397	397
query51	4103	4131	4078	4078
query52	111	102	94	94
query53	224	256	194	194
query54	583	584	515	515
query55	84	82	84	82
query56	328	304	289	289
query57	1162	1212	1099	1099
query58	265	255	247	247
query59	2542	2579	2539	2539
query60	326	308	294	294
query61	127	124	128	124
query62	773	748	657	657
query63	226	194	181	181
query64	4262	1016	685	685
query65	4352	4233	4190	4190
query66	994	406	317	317
query67	15746	15545	15269	15269
query68	6607	869	567	567
query69	465	297	259	259
query70	1162	1100	1109	1100
query71	421	312	307	307
query72	5696	4900	4843	4843
query73	664	613	352	352
query74	8796	9218	8882	8882
query75	3149	3256	2710	2710
query76	3204	1189	767	767
query77	480	364	289	289
query78	9961	10074	9310	9310
query79	2154	814	548	548
query80	658	515	441	441
query81	490	267	212	212
query82	403	129	95	95
query83	258	256	234	234
query84	245	105	97	97
query85	751	352	322	322
query86	396	303	298	298
query87	4423	4371	4378	4371
query88	3067	2203	2213	2203
query89	385	312	289	289
query90	2079	202	203	202
query91	140	140	108	108
query92	78	58	57	57
query93	2616	935	580	580
query94	674	422	297	297
query95	380	301	288	288
query96	480	572	274	274
query97	3135	3249	3083	3083
query98	246	213	208	208
query99	1357	1423	1292	1292
Total cold run time: 274408 ms
Total hot run time: 185734 ms

doris-robot · 2025-04-23T10:05:23Z

ClickBench: Total hot run time: 29.56 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit c3245758e870d71acef3e135eb8a616777a61c32, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.11	0.11
query3	0.26	0.20	0.19
query4	1.59	0.20	0.20
query5	0.61	0.57	0.58
query6	1.17	0.71	0.72
query7	0.03	0.01	0.02
query8	0.04	0.03	0.04
query9	0.56	0.51	0.51
query10	0.57	0.57	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.61	0.60	0.60
query14	1.20	1.16	1.18
query15	0.87	0.86	0.86
query16	0.39	0.39	0.38
query17	1.01	1.05	1.04
query18	0.21	0.20	0.20
query19	1.93	1.85	1.81
query20	0.01	0.02	0.01
query21	15.41	0.92	0.55
query22	0.75	1.08	0.71
query23	15.00	1.38	0.64
query24	6.75	1.93	0.61
query25	0.48	0.21	0.08
query26	0.63	0.16	0.14
query27	0.04	0.05	0.06
query28	9.53	0.93	0.46
query29	12.55	4.03	3.31
query30	0.25	0.09	0.07
query31	2.82	0.59	0.40
query32	3.22	0.54	0.46
query33	2.99	3.09	3.08
query34	15.61	5.19	4.49
query35	4.60	4.53	4.58
query36	0.68	0.50	0.49
query37	0.09	0.07	0.06
query38	0.06	0.03	0.03
query39	0.03	0.02	0.03
query40	0.18	0.13	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 103.35 s
Total hot run time: 29.56 s

yujun777 · 2025-04-24T02:49:55Z

run p0

### What problem does this PR solve? apache#44574 make AND's child size may exceeds 2, need consider.

pick #41222 #46468 #44574 #48034 #50265 #47385

morrySnow requested a review from Copilot April 22, 2025 02:26

Copilot AI reviewed Apr 22, 2025

View reviewed changes

morrySnow previously approved these changes Apr 22, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 22, 2025

github-actions bot added the reviewed label Apr 22, 2025

yujun777 dismissed morrySnow’s stale review via 891ec92 April 22, 2025 03:02

github-actions bot removed the approved Indicates a PR has been approved by one committer. label Apr 22, 2025

morrySnow approved these changes Apr 22, 2025

View reviewed changes

github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 22, 2025

lsy3993 approved these changes Apr 22, 2025

View reviewed changes

yujun777 added 2 commits April 23, 2025 09:57

fix AND extract uniform slots

0338e77

fix ShowSnapshotCommand

c324575

yujun777 force-pushed the fix-extract-uniform-slot branch from 891ec92 to c324575 Compare April 23, 2025 01:57

englefly approved these changes Apr 23, 2025

View reviewed changes

englefly merged commit 9ccfab2 into apache:master Apr 24, 2025
24 checks passed

koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025

[fix](nereids) fix AND extract uniform slots (apache#50265)

40bad3f

### What problem does this PR solve? apache#44574 make AND's child size may exceeds 2, need consider.

englefly mentioned this pull request Jun 18, 2025

branch-3.1: [opt](nereids) infer in-predicate from or-predicate (#46468) #51869

Merged

morrySnow pushed a commit that referenced this pull request Jun 20, 2025

branch-3.1: [opt](nereids) infer in-predicate from or-predicate (#51869)

622e21e

pick #41222 #46468 #44574 #48034 #50265 #47385

morrySnow added the dev/3.1.0-merged label Jun 20, 2025

[fix](nereids) fix AND extract uniform slots #50265

[fix](nereids) fix AND extract uniform slots #50265

Uh oh!

Conversation

yujun777 commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

hello-stephen commented Apr 22, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

doris-robot commented Apr 22, 2025

Uh oh!

github-actions bot commented Apr 22, 2025

Uh oh!

doris-robot commented Apr 22, 2025

Uh oh!

doris-robot commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 22, 2025

Uh oh!

yujun777 commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

yujun777 commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

yujun777 commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

yujun777 commented Apr 23, 2025

Uh oh!

yujun777 commented Apr 23, 2025

Uh oh!

yujun777 commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

doris-robot commented Apr 23, 2025

Uh oh!

yujun777 commented Apr 22, 2025 •

edited

Loading