Skip to content

[opt](nereids)flattern and/or #44574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
englefly merged 6 commits into from
Nov 30, 2024
Merged

[opt](nereids)flattern and/or #44574

englefly merged 6 commits into from
Nov 30, 2024

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Nov 25, 2024 •
edited
Loading

What problem does this PR solve?

And/or expressions are represented by binary trees. The depth of the tree causes stack overflow in recursive program calls. To solve this problem, this pr will flatten the binary tree when processing and/or, reducing the number of recursions. At the same time, we also rewrite some recursive programs into non-recursive forms to avoid stack overflow.

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@doris-robot
Copy link

doris-robot commented Nov 25, 2024

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Nov 25, 2024

run buildall

@englefly englefly marked this pull request as draft November 25, 2024 13:13
@englefly
Copy link
Contributor Author

englefly commented Nov 26, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 26, 2024

run buildall

2 similar comments
@englefly
Copy link
Contributor Author

englefly commented Nov 26, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 27, 2024

run buildall

@englefly englefly marked this pull request as ready for review November 27, 2024 14:29
@englefly
Copy link
Contributor Author

englefly commented Nov 28, 2024

run buildall

3 similar comments
@englefly
Copy link
Contributor Author

englefly commented Nov 28, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 28, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 28, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 28, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 29, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 29, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 29, 2024

run compile

@englefly
Copy link
Contributor Author

englefly commented Nov 30, 2024

run buildall

@englefly
Copy link
Contributor Author

englefly commented Nov 30, 2024

run cloud_p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Nov 30, 2024
@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Nov 30, 2024

PR approved by anyone and no changes requested.

eldenmoon
eldenmoon approved these changes Nov 30, 2024
View reviewed changes
Copy link
Member

@eldenmoon eldenmoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@englefly englefly merged commit 42a7734 into apache:master Nov 30, 2024
15 of 16 checks passed
@924060929 924060929 mentioned this pull request Feb 18, 2025
Merged
16 tasks
924060929 added a commit that referenced this pull request Feb 19, 2025
@924060929
[fix](nereids) fix prune partitions wrong (#48034)
2a76ef9 
fix prune partitions wrong, introduced by #44574
lzyy2024 pushed a commit to lzyy2024/doris that referenced this pull request Feb 21, 2025
@924060929 @lzyy2024
[fix](nereids) fix prune partitions wrong (apache#48034)
7f7c126 
fix prune partitions wrong, introduced by apache#44574
@morrySnow morrySnow mentioned this pull request Apr 22, 2025
Merged
16 tasks
englefly pushed a commit that referenced this pull request Apr 24, 2025
@yujun777
[fix](nereids) fix AND extract uniform slots (#50265)
9ccfab2 
### What problem does this PR solve?

#44574 make AND's child size may exceeds 2, need consider.
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@924060929 @koarz
[fix](nereids) fix prune partitions wrong (apache#48034)
3aac59a 
fix prune partitions wrong, introduced by apache#44574
koarz pushed a commit to koarz/doris that referenced this pull request Jun 4, 2025
@yujun777 @koarz
[fix](nereids) fix AND extract uniform slots (apache#50265)
40bad3f 
### What problem does this PR solve?

apache#44574 make AND's child size may exceeds 2, need consider.
@englefly englefly mentioned this pull request Jun 18, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
@englefly
branch-3.1: [opt](nereids) infer in-predicate from or-predicate (#51869)
622e21e 
pick 
#41222
#46468
#44574
#48034
#50265
#47385
@englefly englefly mentioned this pull request Jun 26, 2025
Merged
16 tasks
englefly added a commit that referenced this pull request Jul 1, 2025
@englefly
[fix](nereids) add "Check expression limit" back (#52378)
d58e068 
### What problem does this PR solve?

previous pr #44574 removes Expression.checkLimit().
this function is still useful, add it back
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@englefly
[fix](nereids) add "Check expression limit" back (#52378)
0d9d743 
### What problem does this PR solve?

previous pr #44574 removes Expression.checkLimit().
this function is still useful, add it back
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly @koarz
[fix](nereids) add "Check expression limit" back (apache#52378)
82eff54 
### What problem does this PR solve?

previous pr apache#44574 removes Expression.checkLimit().
this function is still useful, add it back
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly @koarz
[fix](nereids) add "Check expression limit" back (apache#52378)
c752af8 
### What problem does this PR solve?

previous pr apache#44574 removes Expression.checkLimit().
this function is still useful, add it back
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly @koarz
[fix](nereids) add "Check expression limit" back (apache#52378)
f63ef32 
### What problem does this PR solve?

previous pr apache#44574 removes Expression.checkLimit().
this function is still useful, add it back
@feiniaofeiafei feiniaofeiafei mentioned this pull request Aug 8, 2025
Merged
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

@eldenmoon eldenmoon eldenmoon approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@englefly @doris-robot @starocean999 @eldenmoon @morrySnow