Skip to content

[fix](nereids) add "Check expression limit" back #52378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
englefly merged 2 commits into from
Jul 1, 2025
Merged

[fix](nereids) add "Check expression limit" back #52378

englefly merged 2 commits into from
Jul 1, 2025

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Jun 26, 2025

What problem does this PR solve?

previous pr #44574 removes Expression.checkLimit().
this function is still useful, add it back

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jun 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Jun 26, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 26, 2025

TPC-H: Total hot run time: 33926 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eb6e5bfc2f085ca7f77469c8ad48aba5e5eb2207, data reload: false

------ Round 1 ----------------------------------
q1	17595	5183	5041	5041
q2	1938	285	190	190
q3	10308	1264	766	766
q4	10211	1012	532	532
q5	7600	2385	2231	2231
q6	181	156	125	125
q7	877	744	605	605
q8	9311	1285	1065	1065
q9	6900	5107	5144	5107
q10	6877	2368	1967	1967
q11	474	300	276	276
q12	338	353	212	212
q13	17755	3626	3121	3121
q14	220	228	221	221
q15	523	475	469	469
q16	437	439	386	386
q17	575	847	361	361
q18	7536	7295	7183	7183
q19	1198	939	548	548
q20	341	343	219	219
q21	3805	3153	2368	2368
q22	1008	1011	933	933
Total cold run time: 106008 ms
Total hot run time: 33926 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5077	5073	5063	5063
q2	237	332	230	230
q3	2176	2684	2315	2315
q4	1359	1790	1320	1320
q5	4237	4338	4488	4338
q6	218	168	125	125
q7	1992	1932	1797	1797
q8	2589	2590	2589	2589
q9	7229	7126	7180	7126
q10	3012	3252	2839	2839
q11	583	489	489	489
q12	683	757	622	622
q13	3576	3888	3306	3306
q14	274	301	291	291
q15	531	469	483	469
q16	461	498	449	449
q17	1145	1539	1362	1362
q18	7779	7643	7462	7462
q19	829	826	882	826
q20	1965	2035	1953	1953
q21	4884	4508	4255	4255
q22	1084	1014	970	970
Total cold run time: 51920 ms
Total hot run time: 50196 ms

@doris-robot
Copy link

doris-robot commented Jun 26, 2025

TPC-DS: Total hot run time: 185455 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eb6e5bfc2f085ca7f77469c8ad48aba5e5eb2207, data reload: false

query1	1005	383	389	383
query2	6533	1758	1738	1738
query3	6752	214	213	213
query4	26265	23677	23491	23491
query5	4327	590	458	458
query6	310	221	208	208
query7	4624	511	302	302
query8	276	223	220	220
query9	8637	2603	2620	2603
query10	462	337	287	287
query11	15396	15135	14849	14849
query12	165	109	116	109
query13	1655	549	428	428
query14	8499	5766	5654	5654
query15	212	191	174	174
query16	7159	663	470	470
query17	962	742	613	613
query18	1978	401	316	316
query19	199	197	165	165
query20	121	117	117	117
query21	209	128	105	105
query22	4053	4220	4002	4002
query23	33965	33073	33075	33073
query24	8418	2392	2402	2392
query25	572	461	411	411
query26	1232	276	151	151
query27	2742	519	340	340
query28	4320	2135	2122	2122
query29	787	578	444	444
query30	282	224	193	193
query31	926	857	779	779
query32	72	66	63	63
query33	560	359	314	314
query34	801	879	538	538
query35	803	803	752	752
query36	985	944	866	866
query37	111	107	76	76
query38	4130	4151	4013	4013
query39	1478	1415	1418	1415
query40	214	120	105	105
query41	58	54	52	52
query42	134	121	108	108
query43	496	515	493	493
query44	1378	858	833	833
query45	172	170	162	162
query46	886	1047	652	652
query47	1751	1835	1714	1714
query48	379	415	307	307
query49	746	469	387	387
query50	669	721	424	424
query51	4142	4143	4191	4143
query52	111	113	102	102
query53	227	267	192	192
query54	568	565	519	519
query55	82	84	81	81
query56	324	312	271	271
query57	1194	1198	1135	1135
query58	264	255	259	255
query59	2661	2738	2569	2569
query60	323	330	308	308
query61	125	116	126	116
query62	835	745	654	654
query63	221	197	193	193
query64	4391	1016	658	658
query65	4266	4184	4174	4174
query66	1137	405	315	315
query67	15922	15739	15307	15307
query68	8338	928	535	535
query69	537	294	282	282
query70	1233	1109	1048	1048
query71	485	317	301	301
query72	5338	4712	4667	4667
query73	682	601	354	354
query74	9208	9233	8844	8844
query75	3762	3215	2739	2739
query76	3658	1184	743	743
query77	785	403	308	308
query78	10031	10196	9394	9394
query79	2286	803	576	576
query80	626	525	463	463
query81	471	314	229	229
query82	416	124	99	99
query83	279	256	230	230
query84	283	109	82	82
query85	785	347	319	319
query86	339	303	276	276
query87	4486	4443	4337	4337
query88	3315	2374	2316	2316
query89	399	317	291	291
query90	1936	207	203	203
query91	133	136	109	109
query92	80	59	56	56
query93	1303	969	606	606
query94	661	418	303	303
query95	374	289	289	289
query96	485	565	282	282
query97	2742	2780	2642	2642
query98	231	208	205	205
query99	1449	1391	1251	1251
Total cold run time: 272795 ms
Total hot run time: 185455 ms

@doris-robot
Copy link

doris-robot commented Jun 26, 2025

ClickBench: Total hot run time: 29.18 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eb6e5bfc2f085ca7f77469c8ad48aba5e5eb2207, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.05
query3	0.25	0.07	0.08
query4	1.61	0.11	0.11
query5	0.44	0.42	0.43
query6	1.15	0.65	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.60	0.52	0.53
query10	0.57	0.58	0.57
query11	0.16	0.11	0.12
query12	0.15	0.12	0.12
query13	0.62	0.64	0.62
query14	0.78	0.81	0.80
query15	0.88	0.88	0.87
query16	0.40	0.39	0.38
query17	1.05	1.03	1.05
query18	0.23	0.22	0.21
query19	1.91	1.81	1.86
query20	0.02	0.01	0.01
query21	15.42	0.92	0.55
query22	0.76	1.12	0.67
query23	15.02	1.40	0.63
query24	7.08	1.56	0.31
query25	0.41	0.14	0.07
query26	0.66	0.16	0.15
query27	0.06	0.06	0.04
query28	9.71	0.88	0.43
query29	12.63	4.02	3.35
query30	0.24	0.09	0.06
query31	2.85	0.62	0.40
query32	3.24	0.55	0.47
query33	3.03	3.16	3.15
query34	16.08	5.36	4.84
query35	4.90	4.80	4.84
query36	0.70	0.51	0.50
query37	0.08	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.03	0.03
query40	0.17	0.15	0.13
query41	0.08	0.02	0.03
query42	0.04	0.03	0.03
query43	0.04	0.02	0.02
Total cold run time: 104.3 s
Total hot run time: 29.18 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 26, 2025

FE UT Coverage Report

Increment line coverage 33.33% (3/9) 🎉
Increment coverage report
Complete coverage report

@englefly
Copy link
Contributor Author

englefly commented Jun 27, 2025

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 30, 2025

PR approved by anyone and no changes requested.

yujun777
yujun777 approved these changes Jun 30, 2025
View reviewed changes
Copy link
Contributor

@yujun777 yujun777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@englefly englefly merged commit d58e068 into apache:master Jul 1, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 1, 2025
@englefly
[fix](nereids) add "Check expression limit" back (#52378)
0d9d743 
### What problem does this PR solve?

previous pr #44574 removes Expression.checkLimit().
this function is still useful, add it back
@github-actions github-actions bot mentioned this pull request Jul 1, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 2, 2025
@github-actions @englefly
branch-3.1: [fix](nereids) add "Check expression limit" back #52378 (#…
adcae17 
…52565)

Cherry-picked from #52378

Co-authored-by: minghong <zhouminghong@selectdb.com>
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly @koarz
[fix](nereids) add "Check expression limit" back (apache#52378)
82eff54 
### What problem does this PR solve?

previous pr apache#44574 removes Expression.checkLimit().
this function is still useful, add it back
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly @koarz
[fix](nereids) add "Check expression limit" back (apache#52378)
c752af8 
### What problem does this PR solve?

previous pr apache#44574 removes Expression.checkLimit().
this function is still useful, add it back
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@englefly @koarz
[fix](nereids) add "Check expression limit" back (apache#52378)
f63ef32 
### What problem does this PR solve?

previous pr apache#44574 removes Expression.checkLimit().
this function is still useful, add it back
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@starocean999 starocean999 starocean999 approved these changes

+1 more reviewer

@yujun777 yujun777 yujun777 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@englefly @Thearas @doris-robot @hello-stephen @yujun777 @starocean999 @morrySnow