Skip to content

branch-3.1: [fix](nereids) add "Check expression limit" back #52378 #52565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 2, 2025
Merged

branch-3.1: [fix](nereids) add "Check expression limit" back #52378 #52565

morrySnow merged 1 commit into from
Jul 2, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2025

Cherry-picked from #52378

@englefly
[fix](nereids) add "Check expression limit" back (#52378)
0d9d743 
### What problem does this PR solve?

previous pr #44574 removes Expression.checkLimit().
this function is still useful, add it back
@github-actions github-actions bot requested a review from morrySnow as a code owner July 1, 2025 03:06
@morrySnow morrySnow closed this Jul 1, 2025
@morrySnow morrySnow reopened this Jul 1, 2025
@morrySnow
Copy link
Contributor

morrySnow commented Jul 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

TPC-H: Total hot run time: 40441 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 0d9d7433464d65520c99ef9333fad222134fecea, data reload: false

------ Round 1 ----------------------------------
q1	17648	6856	6641	6641
q2	2069	204	172	172
q3	10634	1164	1186	1164
q4	10403	800	780	780
q5	7772	2968	2866	2866
q6	222	138	139	138
q7	1033	647	617	617
q8	9376	1997	2048	1997
q9	6661	6423	6450	6423
q10	7022	2247	2330	2247
q11	476	274	280	274
q12	411	224	218	218
q13	17774	2988	3016	2988
q14	257	218	211	211
q15	502	463	483	463
q16	466	395	389	389
q17	1010	612	556	556
q18	7445	6807	6776	6776
q19	1338	1029	991	991
q20	498	222	219	219
q21	3944	3317	3329	3317
q22	1109	1018	994	994
Total cold run time: 108070 ms
Total hot run time: 40441 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6651	6684	6723	6684
q2	329	231	235	231
q3	3052	2962	2972	2962
q4	2049	1849	1848	1848
q5	5764	5781	5770	5770
q6	212	135	131	131
q7	2281	1804	1803	1803
q8	3360	3557	3590	3557
q9	8913	9060	8910	8910
q10	3575	3552	3581	3552
q11	607	496	509	496
q12	879	608	606	606
q13	9758	3167	3239	3167
q14	313	288	283	283
q15	505	475	473	473
q16	502	450	450	450
q17	1890	1660	1660	1660
q18	8286	8033	7684	7684
q19	1713	1625	1584	1584
q20	2122	1883	1870	1870
q21	5356	5032	5096	5032
q22	1149	1090	1043	1043
Total cold run time: 69266 ms
Total hot run time: 59796 ms

@morrySnow morrySnow merged commit adcae17 into branch-3.1 Jul 2, 2025
20 of 22 checks passed
@morrySnow morrySnow deleted the auto-pick-52378-branch-3.1 branch July 2, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@morrySnow @doris-robot @englefly