Skip to content

[fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or #54353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
englefly merged 4 commits into from
Aug 11, 2025
Merged

[fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or #54353

englefly merged 4 commits into from
Aug 11, 2025

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Aug 5, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 5, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

englefly commented Aug 6, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

TPC-H: Total hot run time: 33499 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 030a8bef4a13bc9edd91eed98a264e053cc69693, data reload: false

------ Round 1 ----------------------------------
q1	17597	5283	5131	5131
q2	1908	274	179	179
q3	10342	1380	718	718
q4	10216	1014	531	531
q5	7557	2322	2297	2297
q6	178	166	130	130
q7	860	762	613	613
q8	9293	1183	1055	1055
q9	6762	5055	5068	5055
q10	6903	2381	1967	1967
q11	452	284	260	260
q12	351	369	222	222
q13	17778	3507	2988	2988
q14	226	247	232	232
q15	532	456	466	456
q16	428	426	371	371
q17	556	821	345	345
q18	7360	7004	6947	6947
q19	1431	976	545	545
q20	316	316	218	218
q21	3546	3023	2257	2257
q22	1062	1064	982	982
Total cold run time: 105654 ms
Total hot run time: 33499 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5564	5293	5369	5293
q2	252	318	220	220
q3	2131	2551	2176	2176
q4	1307	1702	1324	1324
q5	4110	4306	4455	4306
q6	252	179	133	133
q7	1991	1908	1813	1813
q8	2480	2408	2421	2408
q9	7341	7330	7126	7126
q10	3486	3367	2897	2897
q11	554	488	503	488
q12	738	789	658	658
q13	3387	3712	3283	3283
q14	305	316	290	290
q15	498	454	503	454
q16	477	514	470	470
q17	1270	1467	1475	1467
q18	8930	7527	7860	7527
q19	12279	864	863	863
q20	3571	1981	1839	1839
q21	15441	4850	4221	4221
q22	1132	1028	996	996
Total cold run time: 77496 ms
Total hot run time: 50252 ms

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

TPC-DS: Total hot run time: 170899 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 030a8bef4a13bc9edd91eed98a264e053cc69693, data reload: false

============================================
query1	1005	384	416	384
query2	6509	1750	1670	1670
query3	6747	227	227	227
query4	26865	23850	23178	23178
query5	4385	639	530	530
query6	334	245	222	222
query7	4631	519	303	303
query8	283	241	232	232
query9	8603	2970	2993	2970
query10	460	343	316	316
query11	15790	15043	14749	14749
query12	195	138	130	130
query13	1665	569	431	431
query14	8605	5991	5890	5890
query15	211	204	172	172
query16	7142	675	492	492
query17	995	771	636	636
query18	2023	449	326	326
query19	225	212	195	195
query20	157	141	143	141
query21	217	126	111	111
query22	4056	4044	3885	3885
query23	34718	34234	34411	34234
query24	8172	2399	2445	2399
query25	574	523	458	458
query26	1227	292	162	162
query27	2720	503	344	344
query28	4388	2348	2346	2346
query29	803	602	488	488
query30	300	239	204	204
query31	892	788	746	746
query32	88	76	84	76
query33	621	431	378	378
query34	816	843	521	521
query35	822	831	764	764
query36	1038	1055	921	921
query37	151	109	94	94
query38	3968	3986	3883	3883
query39	1440	1371	1353	1353
query40	248	137	129	129
query41	62	60	54	54
query42	140	123	130	123
query43	499	511	484	484
query44	1410	880	863	863
query45	199	183	183	183
query46	951	1069	686	686
query47	1790	1850	1728	1728
query48	422	445	308	308
query49	728	531	422	422
query50	671	683	409	409
query51	4251	4161	4294	4161
query52	130	135	119	119
query53	262	289	216	216
query54	653	647	555	555
query55	87	91	91	91
query56	350	359	362	359
query57	1211	1218	1167	1167
query58	333	335	345	335
query59	2635	2625	2590	2590
query60	403	393	379	379
query61	126	123	163	123
query62	835	720	649	649
query63	256	219	212	212
query64	4391	1110	792	792
query65	4247	4140	4163	4140
query66	1170	447	333	333
query67	query68	18412	891	989	891
query69	990	282	308	282
query70	1402	1115	1127	1115
query71	646	324	324	324
query72	9043	2272	2222	2222
query73	4645	698	362	362
query74	9028	8945	8962	8945
query75	6825	3136	2781	2781
query76	8353	1234	828	828
query77	1158	429	353	353
query78	9713	11462	9422	9422
query79	15433	585	581	581
query80	1530	590	480	480
query81	563	262	235	235
query82	470	151	118	118
query83	371	284	266	266
query84	301	99	87	87
query85	989	398	339	339
query86	364	314	282	282
query87	4152	4185	4135	4135
query88	5517	2275	2299	2275
query89	486	363	310	310
query90	2585	231	232	231
query91	148	155	112	112
query92	90	71	66	66
query93	6438	1022	658	658
query94	1138	396	286	286
query95	415	334	330	330
query96	508	587	284	284
query97	2681	2716	2594	2594
query98	249	233	222	222
query99	1477	1416	1312	1312
Total cold run time: 308421 ms
Total hot run time: 170899 ms

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

ClickBench: Total hot run time: 32.81 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 030a8bef4a13bc9edd91eed98a264e053cc69693, data reload: false

query1	0.04	0.04	0.04
query2	0.08	0.04	0.05
query3	0.24	0.07	0.07
query4	1.61	0.11	0.11
query5	0.43	0.40	0.42
query6	1.15	0.66	0.66
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.56	0.48	0.47
query10	0.52	0.52	0.52
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.66	0.63	0.65
query14	0.93	1.17	0.99
query15	0.94	0.90	0.89
query16	0.39	0.40	0.40
query17	1.07	1.08	1.06
query18	0.22	0.21	0.20
query19	2.04	1.88	1.81
query20	0.02	0.01	0.01
query21	15.42	0.86	0.55
query22	0.78	1.14	0.60
query23	15.02	1.24	0.63
query24	6.44	1.93	0.63
query25	0.52	0.20	0.06
query26	0.53	0.17	0.13
query27	0.06	0.06	0.05
query28	9.99	0.86	0.44
query29	12.58	3.78	3.28
query30	3.03	2.98	3.00
query31	2.82	0.56	0.40
query32	3.24	0.58	0.51
query33	3.03	3.22	3.26
query34	16.10	5.33	4.97
query35	4.92	4.91	5.00
query36	0.70	0.53	0.51
query37	0.10	0.08	0.07
query38	0.05	0.04	0.05
query39	0.04	0.03	0.03
query40	0.17	0.14	0.14
query41	0.09	0.04	0.03
query42	0.04	0.03	0.03
query43	0.05	0.04	0.03
Total cold run time: 107 s
Total hot run time: 32.81 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 6, 2025

FE UT Coverage Report

Increment line coverage 27.27% (3/11) 🎉
Increment coverage report
Complete coverage report

morrySnow
morrySnow reviewed Aug 6, 2025
View reviewed changes
fe/fe-core/src/main/java/org/apache/doris/nereids/glue/translator/ExpressionTranslator.java Outdated
Comment on lines 370 to 374
boolean nullable = left.getNullableFromNereids().isPresent() && left.getNullableFromNereids().get()
|| left.isNullable()
|| right.getNullableFromNereids().isPresent() && right.getNullableFromNereids().get()
|| right.isNullable();
cp.setNullableFromNereids(nullable);
Copy link
Contributor

@morrySnow morrySnow Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think we should only rely on NullableFromNereids. in which case NullableFromNereids is not present?

Copy link
Contributor Author

@englefly englefly Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@englefly
Copy link
Contributor Author

englefly commented Aug 6, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

TPC-H: Total hot run time: 33602 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a50a2965e48be5fbdcdc89e430f0a8b054f08b67, data reload: false

------ Round 1 ----------------------------------
q1	17579	5189	5186	5186
q2	2014	292	184	184
q3	10227	1367	691	691
q4	10231	1032	545	545
q5	7519	2401	2307	2307
q6	175	162	134	134
q7	894	767	604	604
q8	9293	1250	1046	1046
q9	6809	5033	5024	5024
q10	6888	2343	1981	1981
q11	457	281	263	263
q12	354	363	230	230
q13	17764	3495	3013	3013
q14	231	242	217	217
q15	528	466	463	463
q16	413	421	369	369
q17	571	824	343	343
q18	7387	7013	7016	7013
q19	1256	992	542	542
q20	323	312	215	215
q21	3382	3028	2251	2251
q22	1024	1054	981	981
Total cold run time: 105319 ms
Total hot run time: 33602 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5294	5367	5421	5367
q2	238	304	218	218
q3	2095	2557	2206	2206
q4	1284	1724	1321	1321
q5	4106	4256	4527	4256
q6	216	176	130	130
q7	2014	1924	1783	1783
q8	2484	2553	2495	2495
q9	7304	7386	7466	7386
q10	3215	3321	2901	2901
q11	563	514	478	478
q12	715	760	611	611
q13	3333	3745	3278	3278
q14	318	302	296	296
q15	504	452	447	447
q16	447	511	444	444
q17	2061	1540	1376	1376
q18	7860	7662	7741	7662
q19	13209	962	915	915
q20	3620	2073	1850	1850
q21	15655	4661	4322	4322
q22	1108	1023	1006	1006
Total cold run time: 77643 ms
Total hot run time: 50748 ms

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

TPC-DS: Total hot run time: 169465 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a50a2965e48be5fbdcdc89e430f0a8b054f08b67, data reload: false

============================================
query1	1021	381	399	381
query2	6515	1772	1696	1696
query3	6743	239	219	219
query4	26625	23337	22810	22810
query5	4390	616	514	514
query6	330	232	216	216
query7	4648	516	294	294
query8	273	235	223	223
query9	8574	2970	2959	2959
query10	502	354	290	290
query11	15728	15085	14771	14771
query12	190	136	133	133
query13	1659	555	414	414
query14	8603	5973	5881	5881
query15	231	211	187	187
query16	7143	632	444	444
query17	970	758	637	637
query18	2001	444	331	331
query19	238	211	188	188
query20	198	150	143	143
query21	225	120	109	109
query22	3860	4158	3950	3950
query23	34454	34167	34301	34167
query24	8157	2391	2407	2391
query25	539	507	422	422
query26	903	290	159	159
query27	2722	510	348	348
query28	4501	2323	2308	2308
query29	751	607	489	489
query30	305	238	196	196
query31	911	800	704	704
query32	85	82	78	78
query33	599	414	390	390
query34	803	855	510	510
query35	787	815	752	752
query36	1032	1012	931	931
query37	140	109	94	94
query38	3968	3920	3955	3920
query39	1437	1391	1387	1387
query40	245	146	129	129
query41	62	60	55	55
query42	139	120	125	120
query43	514	506	492	492
query44	1392	893	863	863
query45	200	188	186	186
query46	957	1059	709	709
query47	1796	1855	1744	1744
query48	407	432	311	311
query49	695	517	419	419
query50	655	705	420	420
query51	4122	4174	4134	4134
query52	123	140	117	117
query53	262	286	218	218
query54	648	652	551	551
query55	94	89	94	89
query56	358	354	349	349
query57	1184	1230	1127	1127
query58	326	329	324	324
query59	2572	2616	2583	2583
query60	401	416	426	416
query61	128	140	120	120
query62	804	739	649	649
query63	265	220	217	217
query64	3499	1086	778	778
query65	4201	4146	4164	4146
query66	1028	447	334	334
query67	query68	17706	880	852	852
query69	1113	269	275	269
query70	1557	1131	1127	1127
query71	681	315	338	315
query72	9130	2260	2116	2116
query73	3506	684	356	356
query74	8864	8998	8704	8704
query75	7436	3082	2672	2672
query76	8669	1220	812	812
query77	1161	415	345	345
query78	9454	10320	9178	9178
query79	14054	603	582	582
query80	1175	554	501	501
query81	549	258	214	214
query82	422	153	114	114
query83	350	287	270	270
query84	310	99	81	81
query85	822	375	411	375
query86	370	357	303	303
query87	4208	4182	4048	4048
query88	5177	2320	2244	2244
query89	466	352	316	316
query90	2548	233	225	225
query91	143	153	114	114
query92	91	74	71	71
query93	5828	994	655	655
query94	972	414	277	277
query95	399	331	316	316
query96	508	603	283	283
query97	2734	2680	2596	2596
query98	248	237	231	231
query99	1448	1422	1267	1267
Total cold run time: 301937 ms
Total hot run time: 169465 ms

@doris-robot
Copy link

doris-robot commented Aug 6, 2025

ClickBench: Total hot run time: 33.65 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a50a2965e48be5fbdcdc89e430f0a8b054f08b67, data reload: false

query1	0.04	0.04	0.03
query2	0.09	0.04	0.04
query3	0.25	0.07	0.07
query4	1.63	0.11	0.12
query5	0.41	0.40	0.44
query6	1.14	0.66	0.64
query7	0.03	0.02	0.02
query8	0.05	0.04	0.03
query9	0.54	0.49	0.47
query10	0.52	0.52	0.52
query11	0.16	0.10	0.10
query12	0.14	0.10	0.10
query13	0.66	0.65	0.62
query14	0.90	1.11	1.23
query15	0.95	0.86	0.89
query16	0.39	0.38	0.38
query17	1.03	1.09	1.07
query18	0.22	0.20	0.20
query19	1.98	1.80	1.92
query20	0.02	0.01	0.02
query21	15.37	0.85	0.55
query22	0.79	1.21	0.73
query23	14.84	1.16	0.60
query24	6.83	1.24	1.39
query25	0.49	0.25	0.21
query26	0.52	0.15	0.13
query27	0.05	0.06	0.06
query28	9.63	0.84	0.47
query29	12.59	3.87	3.31
query30	3.00	2.96	2.93
query31	2.82	0.56	0.40
query32	3.23	0.55	0.49
query33	2.99	3.25	3.20
query34	16.01	5.30	5.00
query35	4.90	5.00	4.89
query36	0.73	0.52	0.50
query37	0.09	0.07	0.07
query38	0.06	0.04	0.05
query39	0.04	0.03	0.02
query40	0.17	0.14	0.14
query41	0.08	0.03	0.03
query42	0.04	0.03	0.02
query43	0.04	0.04	0.04
Total cold run time: 106.46 s
Total hot run time: 33.65 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Aug 6, 2025

FE UT Coverage Report

Increment line coverage 27.27% (3/11) 🎉
Increment coverage report
Complete coverage report

starocean999
starocean999 previously approved these changes Aug 8, 2025
View reviewed changes
@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 8, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Aug 8, 2025
@englefly
Copy link
Contributor Author

englefly commented Aug 8, 2025

run buildall

@feiniaofeiafei
Copy link
Contributor

feiniaofeiafei commented Aug 8, 2025

can add related pr #44574 in description

@doris-robot
Copy link

doris-robot commented Aug 8, 2025

TPC-H: Total hot run time: 33958 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5c7e1f244e99acfe291fabbe969cba403fef0ab7, data reload: false

------ Round 1 ----------------------------------
q1	17577	5246	5143	5143
q2	1958	298	187	187
q3	10269	1462	722	722
q4	10216	1027	555	555
q5	7491	2312	2294	2294
q6	177	165	134	134
q7	890	748	639	639
q8	9295	1293	1079	1079
q9	6820	5043	5105	5043
q10	6912	2375	1967	1967
q11	466	283	274	274
q12	346	366	239	239
q13	17794	3500	2968	2968
q14	247	248	222	222
q15	525	478	465	465
q16	439	415	385	385
q17	562	740	453	453
q18	7921	7018	7017	7017
q19	1942	984	557	557
q20	325	321	219	219
q21	3334	3152	2379	2379
q22	1052	1018	1017	1017
Total cold run time: 106558 ms
Total hot run time: 33958 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5371	5291	5318	5291
q2	234	313	218	218
q3	2052	2600	2165	2165
q4	1285	1705	1298	1298
q5	4125	4077	4030	4030
q6	214	174	129	129
q7	1798	1793	1669	1669
q8	2452	2353	2320	2320
q9	6824	6805	6801	6801
q10	3033	3217	2773	2773
q11	537	502	485	485
q12	651	729	572	572
q13	3206	3450	3060	3060
q14	268	302	270	270
q15	494	447	437	437
q16	429	454	422	422
q17	1112	1366	1287	1287
q18	13337	7635	6974	6974
q19	9737	860	867	860
q20	1930	1895	1807	1807
q21	14944	4250	4314	4250
q22	1013	1054	1001	1001
Total cold run time: 75046 ms
Total hot run time: 48119 ms

@doris-robot
Copy link

doris-robot commented Aug 8, 2025

TPC-DS: Total hot run time: 160349 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5c7e1f244e99acfe291fabbe969cba403fef0ab7, data reload: false

reason	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:56	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
============================================
query1	995	380	440	380
query2	6529	1833	1661	1661
query3	6747	232	227	227
query4	27161	23164	22919	22919
query5	4363	638	535	535
query6	323	240	238	238
query7	4635	525	289	289
query8	297	259	216	216
query9	8558	2998	2976	2976
query10	470	341	289	289
query11	15987	14962	14717	14717
query12	182	134	133	133
query13	1656	565	452	452
query14	8599	5839	5753	5753
query15	209	196	169	169
query16	7280	671	487	487
query17	1241	787	634	634
query18	2191	444	336	336
query19	264	254	188	188
query20	155	143	139	139
query21	216	128	113	113
query22	3864	4104	4000	4000
query23	34484	34472	34136	34136
query24	8164	2448	2465	2448
query25	564	538	445	445
query26	1236	293	170	170
query27	2634	502	357	357
query28	4243	2348	2331	2331
query29	804	633	500	500
query30	296	228	197	197
query31	920	783	749	749
query32	88	79	78	78
query33	565	409	375	375
query34	811	869	519	519
query35	798	838	762	762
query36	1045	1049	962	962
query37	133	116	94	94
query38	3948	3932	3895	3895
query39	1460	1393	1371	1371
query40	239	144	131	131
query41	67	56	88	56
query42	147	134	131	131
query43	531	522	478	478
query44	1411	879	896	879
query45	203	192	183	183
query46	955	1061	665	665
query47	1808	1824	1775	1775
query48	415	425	323	323
query49	728	505	408	408
query50	680	694	415	415
query51	4205	4239	4091	4091
query52	126	130	126	126
query53	256	295	215	215
query54	652	644	566	566
query55	93	88	90	88
query56	360	378	361	361
query57	1187	1202	1140	1140
query58	348	348	355	348
query59	2615	2570	2546	2546
query60	431	424	409	409
query61	154	146	150	146
query62	801	744	696	696
query63	250	224	217	217
query64	4432	1165	851	851
query65	4235	4139	4092	4092
query66	1175	456	339	339
query67	query68	17603	623	595	595
query69	1010	334	290	290
query70	1438	1118	1107	1107
query71	687	351	351	351
query72	9170	2303	2349	2303
query73	4088	659	350	350
query74	9049	8964	8515	8515
query75	7302	3141	2666	2666
query76	8582	1242	802	802
query77	1201	429	344	344
query78	query79	17198	612	577	577
query80	1844	583	484	484
query81	561	271	244	244
query82	461	162	121	121
query83	346	284	266	266
query84	297	101	82	82
query85	1687	408	342	342
query86	349	333	315	315
query87	4225	4190	4069	4069
query88	5546	2219	2210	2210
query89	506	371	316	316
query90	2582	240	229	229
query91	150	138	114	114
query92	87	75	67	67
query93	6978	999	648	648
query94	1144	399	356	356
query95	424	331	312	312
query96	499	585	280	280
query97	2693	2715	2553	2553
query98	259	223	226	223
query99	1551	1344	1303	1303
Total cold run time: 302136 ms
Total hot run time: 160349 ms

@doris-robot
Copy link

doris-robot commented Aug 8, 2025

ClickBench: Total hot run time: 33.2 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5c7e1f244e99acfe291fabbe969cba403fef0ab7, data reload: false

query1	0.04	0.04	0.03
query2	0.08	0.04	0.04
query3	0.25	0.07	0.08
query4	1.62	0.11	0.11
query5	0.42	0.41	0.43
query6	1.17	0.68	0.68
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.54	0.48	0.47
query10	0.52	0.52	0.54
query11	0.16	0.11	0.11
query12	0.15	0.11	0.11
query13	0.65	0.66	0.65
query14	0.96	1.06	1.18
query15	0.90	0.89	0.90
query16	0.38	0.39	0.42
query17	1.09	1.07	1.07
query18	0.22	0.20	0.20
query19	1.99	1.99	1.97
query20	0.02	0.01	0.01
query21	15.38	0.86	0.56
query22	0.79	1.20	0.69
query23	14.83	1.13	0.66
query24	6.80	1.18	0.51
query25	0.52	0.28	0.06
query26	0.66	0.15	0.13
query27	0.06	0.05	0.05
query28	10.00	0.85	0.46
query29	12.60	3.89	3.35
query30	3.04	3.00	2.95
query31	2.82	0.56	0.40
query32	3.25	0.57	0.49
query33	3.01	3.19	3.24
query34	16.24	5.33	5.03
query35	4.91	5.04	4.95
query36	0.70	0.52	0.51
query37	0.10	0.08	0.07
query38	0.07	0.05	0.04
query39	0.03	0.03	0.03
query40	0.18	0.14	0.14
query41	0.08	0.04	0.03
query42	0.04	0.03	0.03
query43	0.04	0.04	0.03
Total cold run time: 107.38 s
Total hot run time: 33.2 s

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Aug 11, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 11, 2025

PR approved by at least one committer and no changes requested.

@englefly englefly merged commit b1b209a into apache:master Aug 11, 2025
28 of 29 checks passed
@englefly englefly deleted the flattern-nullable branch August 11, 2025 02:52
@morrySnow morrySnow mentioned this pull request Aug 14, 2025
Merged
morrySnow pushed a commit that referenced this pull request Aug 14, 2025
@englefly
branch-3.1: [fix](nereids) set CompoundPredicate.nullableFromNereids …
3488204 
…after flattern and/or #54353 (#54704)

picked from #54353
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow left review comments

@starocean999 starocean999 starocean999 approved these changes

+1 more reviewer

@feiniaofeiafei feiniaofeiafei feiniaofeiafei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@englefly @hello-stephen @doris-robot @feiniaofeiafei @starocean999 @morrySnow