Skip to content

Conversation

@englefly
Copy link
Contributor

@englefly englefly commented Aug 13, 2025

picked from #54353

@englefly englefly requested a review from morrySnow as a code owner August 13, 2025 12:41
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@englefly
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 66.67% (6/9) 🎉
Increment coverage report
Complete coverage report

@englefly
Copy link
Contributor Author

run performance

@doris-robot
Copy link

TPC-H: Total hot run time: 32675 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a895ccc60ad429d2ad1c2de273f19502d789c98e, data reload: false

------ Round 1 ----------------------------------
q1	17594	5533	5568	5533
q2	2032	398	279	279
q3	12182	1236	731	731
q4	10559	869	445	445
q5	9650	2357	2157	2157
q6	192	165	134	134
q7	909	753	607	607
q8	9334	1462	1152	1152
q9	5282	4978	4900	4900
q10	6753	2282	1831	1831
q11	489	268	257	257
q12	329	352	205	205
q13	17766	3632	3018	3018
q14	223	219	201	201
q15	534	466	461	461
q16	420	431	368	368
q17	594	870	358	358
q18	6827	6314	6304	6304
q19	1212	950	570	570
q20	324	325	201	201
q21	2832	2150	1997	1997
q22	1057	1016	966	966
Total cold run time: 107094 ms
Total hot run time: 32675 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5573	5524	5546	5524
q2	237	326	236	236
q3	2231	2688	2294	2294
q4	1303	1822	1381	1381
q5	4409	5026	4928	4928
q6	177	165	133	133
q7	2087	1962	1803	1803
q8	2627	2832	2683	2683
q9	7307	7265	7195	7195
q10	3055	3315	2766	2766
q11	575	526	494	494
q12	684	799	648	648
q13	3401	3840	3199	3199
q14	296	290	287	287
q15	525	475	495	475
q16	428	493	448	448
q17	1234	1751	1251	1251
q18	7781	7428	7295	7295
q19	837	1023	1168	1023
q20	1999	2028	1927	1927
q21	5337	5013	4602	4602
q22	1064	1103	998	998
Total cold run time: 53167 ms
Total hot run time: 51590 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193986 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a895ccc60ad429d2ad1c2de273f19502d789c98e, data reload: false

query1	967	403	405	403
query2	6214	1991	1922	1922
query3	8700	195	194	194
query4	33752	24158	23902	23902
query5	4166	620	460	460
query6	306	193	171	171
query7	4191	499	316	316
query8	297	229	238	229
query9	9463	2572	2548	2548
query10	478	329	261	261
query11	18229	15523	15137	15137
query12	158	115	109	109
query13	1553	542	424	424
query14	9629	7470	7855	7470
query15	218	193	183	183
query16	8087	668	510	510
query17	1593	779	596	596
query18	2111	423	334	334
query19	240	199	159	159
query20	137	129	125	125
query21	215	128	111	111
query22	4629	4697	4448	4448
query23	35067	34612	34119	34119
query24	7364	2738	2713	2713
query25	551	509	433	433
query26	999	280	174	174
query27	2355	511	361	361
query28	5217	2192	2170	2170
query29	679	611	452	452
query30	241	191	159	159
query31	1016	921	843	843
query32	117	63	59	59
query33	528	349	306	306
query34	736	863	511	511
query35	786	827	724	724
query36	995	1064	969	969
query37	107	95	76	76
query38	3974	4012	4023	4012
query39	1536	1488	1473	1473
query40	214	116	102	102
query41	50	47	48	47
query42	128	112	104	104
query43	515	514	503	503
query44	1310	829	833	829
query45	192	179	170	170
query46	904	1064	673	673
query47	1952	1988	1910	1910
query48	419	448	342	342
query49	732	506	443	443
query50	679	694	427	427
query51	7404	7333	7275	7275
query52	107	106	98	98
query53	231	257	188	188
query54	545	541	463	463
query55	80	82	83	82
query56	264	283	257	257
query57	1273	1267	1208	1208
query58	258	214	216	214
query59	3148	3273	3241	3241
query60	293	281	273	273
query61	149	115	138	115
query62	816	748	714	714
query63	228	199	193	193
query64	3667	1025	665	665
query65	3341	3313	3335	3313
query66	807	410	306	306
query67	16802	15766	15585	15585
query68	7248	832	545	545
query69	506	310	265	265
query70	1195	1109	1116	1109
query71	388	289	259	259
query72	5799	3955	3856	3856
query73	630	752	361	361
query74	10300	9505	9208	9208
query75	3243	3135	2625	2625
query76	3050	1164	781	781
query77	511	370	269	269
query78	10329	10411	9719	9719
query79	3168	946	604	604
query80	654	561	451	451
query81	521	265	228	228
query82	581	124	91	91
query83	160	160	150	150
query84	250	107	83	83
query85	780	375	308	308
query86	396	314	294	294
query87	4350	4360	4276	4276
query88	4823	2415	2397	2397
query89	414	322	305	305
query90	1763	197	193	193
query91	138	143	116	116
query92	64	56	53	53
query93	1900	913	556	556
query94	678	413	309	309
query95	346	284	264	264
query96	491	621	294	294
query97	3202	3267	3159	3159
query98	219	217	205	205
query99	1526	1373	1347	1347
Total cold run time: 293732 ms
Total hot run time: 193986 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.39 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a895ccc60ad429d2ad1c2de273f19502d789c98e, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.04	0.03
query3	0.23	0.07	0.06
query4	1.62	0.11	0.11
query5	0.52	0.51	0.53
query6	1.13	0.73	0.72
query7	0.03	0.02	0.01
query8	0.05	0.03	0.03
query9	0.58	0.51	0.49
query10	0.59	0.55	0.56
query11	0.14	0.10	0.10
query12	0.14	0.10	0.10
query13	0.63	0.60	0.60
query14	0.78	0.81	0.79
query15	0.86	0.83	0.82
query16	0.40	0.39	0.38
query17	1.06	1.00	1.01
query18	0.25	0.22	0.23
query19	1.88	1.88	1.76
query20	0.02	0.01	0.00
query21	15.39	0.94	0.59
query22	0.73	0.73	0.70
query23	15.18	1.42	0.53
query24	3.51	1.71	0.58
query25	0.22	0.10	0.07
query26	0.31	0.15	0.13
query27	0.04	0.05	0.04
query28	13.44	1.06	0.46
query29	12.57	3.84	3.22
query30	0.25	0.09	0.07
query31	2.84	0.59	0.38
query32	3.22	0.54	0.46
query33	2.98	3.03	3.02
query34	16.48	5.14	4.53
query35	4.56	4.56	4.53
query36	0.63	0.48	0.47
query37	0.09	0.06	0.05
query38	0.04	0.04	0.03
query39	0.03	0.02	0.02
query40	0.16	0.14	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.82 s
Total hot run time: 28.39 s

@morrySnow morrySnow changed the title branch-3.1 [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or #54353 branch-3.1: [fix](nereids) set CompoundPredicate.nullableFromNereids after flattern and/or #54353 Aug 14, 2025
@morrySnow morrySnow merged commit 3488204 into apache:branch-3.1 Aug 14, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants