Skip to content

[fix](cloud) batch process ttl cache block gc to limit lock held time once in a time (pick#50387) #50402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Apr 25, 2025
Merged

[fix](cloud) batch process ttl cache block gc to limit lock held time once in a time (pick#50387) #50402

dataroaring merged 1 commit into from
Apr 25, 2025

Conversation

@freemandealer
Copy link
Contributor

@freemandealer freemandealer commented Apr 25, 2025 •
edited by dataroaring
Loading

pick #50387

too many ttl cache blocks gc will burst the cache lock latency and thus affect the query latency. limit them into batches to unleash the lock.

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@freemandealer
[fix](cloud) batch process ttl cache block gc to limit lock held time…
ef17252 
… once in a time (pick#50387)

pick#50387pick#50387pick#50387pick#50387pick#50387pick#50387pick#50387

too many ttl cache blocks gc will burst the cache lock latency and thus
affect the query latency. limit them into batches to unleash the lock.

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@hello-stephen
Copy link
Contributor

hello-stephen commented Apr 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

freemandealer commented Apr 25, 2025

run buildall

cambyzju
cambyzju reviewed Apr 25, 2025
View reviewed changes
be/src/common/config.cpp
DEFINE_mBool(enable_file_cache_keep_base_compaction_output, "false");
DEFINE_mInt64(file_cache_remove_block_qps_limit, "1000");
DEFINE_mInt64(file_cache_background_gc_interval_ms, "100");
DEFINE_mInt64(file_cache_background_monitor_interval_ms, "5000");
Copy link
Contributor

@cambyzju cambyzju Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this config do not used?

Copy link
Contributor Author

@freemandealer freemandealer Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cambyzju indeed, I'll delete it in later PR (this is a pick). thanks for pointing that out!

@doris-robot
Copy link

doris-robot commented Apr 25, 2025

BE UT Coverage Report

Increment line coverage 100.00% (13/13) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 40.22% (10556/26247)
Line Coverage 30.99% (89331/288222)
Region Coverage 30.12% (46080/152984)
Branch Coverage 26.63% (23557/88466)

dataroaring
dataroaring approved these changes Apr 25, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Apr 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Apr 25, 2025

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit 54c43a1 into apache:branch-3.0 Apr 25, 2025
21 of 26 checks passed
dataroaring pushed a commit that referenced this pull request Apr 25, 2025
@freemandealer
[fix](cloud) batch process ttl cache block gc to limit lock held time…
de3cb38 
… once in a time (pick#50387) (#50402)

pick#50387

too many ttl cache blocks gc will burst the cache lock latency and thus
affect the query latency. limit them into batches to unleash the lock.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cambyzju cambyzju cambyzju left review comments

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@freemandealer @hello-stephen @doris-robot @cambyzju @dataroaring