Skip to content

[fix](cloud) batch process ttl cache block gc to limit lock held time once in a time (pick#50387) #50402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Apr 25, 2025
Merged

[fix](cloud) batch process ttl cache block gc to limit lock held time once in a time (pick#50387) #50402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions be/src/common/config.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1106,6 +1106,9 @@ DEFINE_mInt64(cache_lock_held_long_tail_threshold_us, "30000000");
DEFINE_mBool(enable_file_cache_keep_base_compaction_output, "false");
DEFINE_mInt64(file_cache_remove_block_qps_limit, "1000");
DEFINE_mInt64(file_cache_background_gc_interval_ms, "100");
DEFINE_mInt64(file_cache_background_monitor_interval_ms, "5000");
Copy link
Contributor

@cambyzju cambyzju Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this config do not used?

Copy link
Contributor Author

@freemandealer freemandealer Apr 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cambyzju indeed, I'll delete it in later PR (this is a pick). thanks for pointing that out!

DEFINE_mInt64(file_cache_background_ttl_gc_interval_ms, "3000");
DEFINE_mInt64(file_cache_background_ttl_gc_batch, "1000");

DEFINE_mInt32(index_cache_entry_stay_time_after_lookup_s, "1800");
DEFINE_mInt32(inverted_index_cache_stale_sweep_time_sec, "600");
Expand Down
4 changes: 4 additions & 0 deletions be/src/common/config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1148,6 +1148,10 @@ DECLARE_mInt64(cache_lock_held_long_tail_threshold_us);
DECLARE_mBool(enable_file_cache_keep_base_compaction_output);
DECLARE_mInt64(file_cache_remove_block_qps_limit);
DECLARE_mInt64(file_cache_background_gc_interval_ms);
DECLARE_mInt64(file_cache_background_monitor_interval_ms);
DECLARE_mInt64(file_cache_background_ttl_gc_interval_ms);
DECLARE_mInt64(file_cache_background_ttl_gc_batch);

// inverted index searcher cache
// cache entry stay time after lookup
DECLARE_mInt32(index_cache_entry_stay_time_after_lookup_s);
Expand Down
18 changes: 13 additions & 5 deletions be/src/io/cache/block_file_cache.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,6 +219,8 @@ BlockFileCache::BlockFileCache(const std::string& cache_base_path,

_recycle_keys_length_recorder = std::make_shared<bvar::LatencyRecorder>(
_cache_base_path.c_str(), "file_cache_recycle_keys_length");
_ttl_gc_latency_us = std::make_shared<bvar::LatencyRecorder>(_cache_base_path.c_str(),
"file_cache_ttl_gc_latency_us");

_disposable_queue = LRUQueue(cache_settings.disposable_queue_size,
cache_settings.disposable_queue_elements, 60 * 60);
Expand Down Expand Up @@ -1829,28 +1831,34 @@ void BlockFileCache::run_background_monitor() {
}
}

void BlockFileCache::run_background_ttl_gc() { // TODO(zhengyu): fix!
int64_t interval_time_seconds = 20;
void BlockFileCache::run_background_ttl_gc() {
while (!_close) {
TEST_SYNC_POINT_CALLBACK("BlockFileCache::set_sleep_time", &interval_time_seconds);
int64_t interval_ms = config::file_cache_background_ttl_gc_interval_ms;
int64_t batch_size = config::file_cache_background_ttl_gc_batch;
TEST_SYNC_POINT_CALLBACK("BlockFileCache::set_sleep_time", &interval_ms);
{
std::unique_lock close_lock(_close_mtx);
_close_cv.wait_for(close_lock, std::chrono::seconds(interval_time_seconds));
_close_cv.wait_for(close_lock, std::chrono::milliseconds(interval_ms));
if (_close) {
break;
}
}
int64_t duration_ns = 0;
{
int64_t cur_time = UnixSeconds();
int64_t count = 0;
SCOPED_CACHE_LOCK(_mutex, this);
SCOPED_RAW_TIMER(&duration_ns);
while (!_time_to_key.empty()) {
auto begin = _time_to_key.begin();
if (cur_time < begin->first) {
if (cur_time < begin->first || count > batch_size) {
break;
}
remove_if_ttl_file_blocks(begin->second, false, cache_lock, false);
++count;
}
}
*_ttl_gc_latency_us << (duration_ns / 1000);
}
}

Expand Down
1 change: 1 addition & 0 deletions be/src/io/cache/block_file_cache.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,6 +574,7 @@ class BlockFileCache {
std::shared_ptr<bvar::LatencyRecorder> _storage_async_remove_latency_us;
std::shared_ptr<bvar::LatencyRecorder> _evict_in_advance_latency_us;
std::shared_ptr<bvar::LatencyRecorder> _recycle_keys_length_recorder;
std::shared_ptr<bvar::LatencyRecorder> _ttl_gc_latency_us;
};

} // namespace doris::io
64 changes: 64 additions & 0 deletions be/test/io/cache/block_file_cache_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2898,6 +2898,70 @@ TEST_F(BlockFileCacheTest, remove_directly_when_normal_change_to_ttl) {
}
}

TEST_F(BlockFileCacheTest, ttl_gc) {
if (fs::exists(cache_base_path)) {
fs::remove_all(cache_base_path);
}
fs::create_directories(cache_base_path);
auto sp = SyncPoint::get_instance();
SyncPoint::CallbackGuard guard1;
sp->enable_processing();
TUniqueId query_id;
query_id.hi = 1;
query_id.lo = 1;
io::FileCacheSettings settings;
settings.query_queue_size = 50;
settings.query_queue_elements = 5;
settings.ttl_queue_size = 500;
settings.ttl_queue_elements = 500;
settings.capacity = 100;
settings.max_file_block_size = 30;
settings.max_query_cache_size = 30;

config::file_cache_background_ttl_gc_batch = 6;
config::file_cache_background_ttl_gc_interval_ms =
3000; // make it big enough to disable auto ttl_gc

io::BlockFileCache cache(cache_base_path, settings);
ASSERT_TRUE(cache.initialize());
for (int i = 0; i < 100; i++) {
if (cache.get_async_open_success()) {
break;
};
std::this_thread::sleep_for(std::chrono::milliseconds(1));
}

io::CacheContext context;
ReadStatistics rstats;
context.stats = &rstats;
context.cache_type = io::FileCacheType::TTL;
context.query_id = query_id;
int64_t cur_time = UnixSeconds();
context.expiration_time = cur_time + 2;

for (int64_t i = 0; i < 12; ++i) {
auto key = io::BlockFileCache::hash(fmt::format("key{}", i));
auto holder = cache.get_or_set(key, 0, 5, context);
auto blocks = fromHolder(holder);
ASSERT_EQ(blocks.size(), 1);
assert_range(1, blocks[0], io::FileBlock::Range(0, 4), io::FileBlock::State::EMPTY);
ASSERT_TRUE(blocks[0]->get_or_set_downloader() == io::FileBlock::get_caller_id());
download(blocks[0]);
assert_range(1, blocks[0], io::FileBlock::Range(0, 4), io::FileBlock::State::DOWNLOADED);
}
ASSERT_EQ(cache._time_to_key.size(), 12);

std::this_thread::sleep_for(std::chrono::milliseconds(3000));
ASSERT_GT(cache._time_to_key.size(), 0);

std::this_thread::sleep_for(std::chrono::milliseconds(3000));
ASSERT_EQ(cache._time_to_key.size(), 0);

if (fs::exists(cache_base_path)) {
fs::remove_all(cache_base_path);
}
}

TEST_F(BlockFileCacheTest, recyle_cache_async) {
if (fs::exists(cache_base_path)) {
fs::remove_all(cache_base_path);
Expand Down
Loading