-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[improvement](statistics)Eliminate null values while sample analyzing ndv. #50574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
run buildall |
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
TPC-H: Total hot run time: 33904 ms |
TPC-DS: Total hot run time: 191818 ms |
ClickBench: Total hot run time: 28.85 s |
morrySnow
reviewed
May 6, 2025
fe/fe-core/src/main/java/org/apache/doris/statistics/BaseAnalysisTask.java
Outdated
Show resolved
Hide resolved
b798eb5 to
32d6168
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33796 ms |
TPC-DS: Total hot run time: 185104 ms |
ClickBench: Total hot run time: 29.08 s |
Contributor
Author
|
run feut |
1 similar comment
Contributor
Author
|
run feut |
Contributor
Author
|
run external |
1 similar comment
Contributor
Author
|
run external |
3540022 to
908c41b
Compare
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 33986 ms |
TPC-DS: Total hot run time: 191800 ms |
ClickBench: Total hot run time: 28.69 s |
Contributor
Author
|
run buildall |
Contributor
Author
|
run buildall |
englefly
approved these changes
Jun 6, 2025
Contributor
|
PR approved by at least one committer and no changes requested. |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 33815 ms |
TPC-DS: Total hot run time: 192645 ms |
ClickBench: Total hot run time: 29.01 s |
Contributor
Author
|
run p0 |
morrySnow
approved these changes
Jun 9, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Jun 9, 2025
… ndv. (#50574) ### What problem does this PR solve? 1. Eliminate null values while sample analyzing ndv. For example, if the values of col1 in table1 are all NULL, the ndv of col1 should be 0, not 1. 2. If ndv=0 and min/max not null and null_num == rowCount, we keep this stats info but set to unknown in stats calculator. This is probably because sampled an all-null tablet.
Jibing-Li
added a commit
to Jibing-Li/incubator-doris
that referenced
this pull request
Jun 11, 2025
… ndv. (apache#50574) 1. Eliminate null values while sample analyzing ndv. For example, if the values of col1 in table1 are all NULL, the ndv of col1 should be 0, not 1. 2. If ndv=0 and min/max not null and null_num == rowCount, we keep this stats info but set to unknown in stats calculator. This is probably because sampled an all-null tablet.
Jibing-Li
added a commit
to Jibing-Li/incubator-doris
that referenced
this pull request
Jun 11, 2025
… ndv. (apache#50574) 1. Eliminate null values while sample analyzing ndv. For example, if the values of col1 in table1 are all NULL, the ndv of col1 should be 0, not 1. 2. If ndv=0 and min/max not null and null_num == rowCount, we keep this stats info but set to unknown in stats calculator. This is probably because sampled an all-null tablet.
Jibing-Li
added a commit
to Jibing-Li/incubator-doris
that referenced
this pull request
Jun 11, 2025
… ndv. (apache#50574) 1. Eliminate null values while sample analyzing ndv. For example, if the values of col1 in table1 are all NULL, the ndv of col1 should be 0, not 1. 2. If ndv=0 and min/max not null and null_num == rowCount, we keep this stats info but set to unknown in stats calculator. This is probably because sampled an all-null tablet.
Jibing-Li
added a commit
to Jibing-Li/incubator-doris
that referenced
this pull request
Jun 11, 2025
… ndv. (apache#50574) 1. Eliminate null values while sample analyzing ndv. For example, if the values of col1 in table1 are all NULL, the ndv of col1 should be 0, not 1. 2. If ndv=0 and min/max not null and null_num == rowCount, we keep this stats info but set to unknown in stats calculator. This is probably because sampled an all-null tablet.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
approved
Indicates a PR has been approved by one committer.
dev/2.1.11-merged
dev/3.0.7-merged
dev/3.1.0-merged
reviewed
usercase
Important user case type label
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Eliminate null values while sample analyzing ndv.
For example, if the values of col1 in table1 are all NULL, the ndv of col1 should be 0, not 1.
If ndv=0 and min/max not null and null_num == rowCount, we keep this stats info but set to unknown in stats calculator. This is probably because sampled an all-null tablet.
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)