Skip to content

branch-2.1:[improvement](statistics)Eliminate null values while sample analyzing ndv. (#50574) #51648

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yiguolei merged 1 commit into from
Jun 13, 2025
Merged

branch-2.1:[improvement](statistics)Eliminate null values while sample analyzing ndv. (#50574) #51648

yiguolei merged 1 commit into from
Jun 13, 2025

Conversation

@Jibing-Li
Copy link
Contributor

@Jibing-Li Jibing-Li commented Jun 11, 2025

backport: #50574

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 11, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Jibing-Li Jibing-Li marked this pull request as ready for review June 11, 2025 12:07
@Jibing-Li Jibing-Li requested a review from yiguolei as a code owner June 11, 2025 12:07
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 11, 2025

run buildall

@Jibing-Li
[improvement](statistics)Eliminate null values while sample analyzing…
41045b9 
… ndv. (apache#50574)

1. Eliminate null values while sample analyzing ndv.
For example, if the values of col1 in table1 are all NULL, the ndv of
col1 should be 0, not 1.

2. If ndv=0 and min/max not null and null_num == rowCount, we keep this
stats info but set to unknown in stats calculator. This is probably
because sampled an all-null tablet.
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 11, 2025

run buildall

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run feut

6 similar comments
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run feut

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run feut

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run feut

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run feut

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run feut

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run feut

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 12, 2025

run buildall

1 similar comment
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 13, 2025

run buildall

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 13, 2025

run feut

2 similar comments
@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 13, 2025

run feut

@Jibing-Li
Copy link
Contributor Author

Jibing-Li commented Jun 13, 2025

run feut

@yiguolei yiguolei merged commit 1a16493 into apache:branch-2.1 Jun 13, 2025
19 of 20 checks passed
@Jibing-Li Jibing-Li deleted the null2.1 branch June 13, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Jibing-Li @hello-stephen @yiguolei