[fix](parquet/orc) Disable string dictionary filtering when predicate express is not binary pred and in pred #50749

suxiaogang223 · 2025-05-09T06:19:24Z

What problem does this PR solve?

Related PR: #42113

Problem Summary:
In the previous fix, the conditions for when dictionary filtering can be performed were wrong.

Release note

None

Check List (For Author)

Test
- Regression test
- Unit Test
- Manual test (add detailed scripts or steps below)
- No need to test or manual test. Explain why:
  - This is a refactor/code format and no logic has been changed.
  - Previous test can cover this change.
  - No code files have been changed.
  - Other reason
Behavior changed:
- No.
- Yes.
Does this need documentation?
- No.
- Yes.

Check List (For Reviewer who merge this PR)

Confirm the release note
Confirm test cases
Confirm document
Add branch pick label

hello-stephen · 2025-05-09T06:19:29Z

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

What problem was fixed (it's best to include specific error reporting information). How it was fixed.
Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
What features were added. Why was this function added?
Which code was refactored and why was this part of the code refactored?
Which functions were optimized and what is the difference before and after the optimization?

suxiaogang223 · 2025-05-09T09:44:27Z

run buildall

doris-robot · 2025-05-09T10:07:17Z

TPC-H: Total hot run time: 34128 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2ec931675b91999cd001e3a564d257ce6e51ac2b, data reload: false

------ Round 1 ----------------------------------
q1	26065	5109	5058	5058
q2	2064	266	177	177
q3	10438	1254	706	706
q4	10214	1025	538	538
q5	7513	2378	2398	2378
q6	179	164	142	142
q7	914	747	625	625
q8	9322	1343	1141	1141
q9	6774	5093	5051	5051
q10	6831	2285	1879	1879
q11	475	272	263	263
q12	344	343	217	217
q13	17742	3639	3065	3065
q14	230	233	210	210
q15	523	478	488	478
q16	420	427	374	374
q17	607	862	374	374
q18	7692	7158	7170	7158
q19	1092	950	583	583
q20	331	340	229	229
q21	4577	3388	2517	2517
q22	1062	999	965	965
Total cold run time: 115409 ms
Total hot run time: 34128 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5130	5068	5077	5068
q2	242	328	238	238
q3	2132	2694	2290	2290
q4	1350	1781	1414	1414
q5	4568	4470	4407	4407
q6	209	166	128	128
q7	1973	1937	1726	1726
q8	2548	2428	2575	2428
q9	7294	7210	7134	7134
q10	3024	3195	2713	2713
q11	567	513	481	481
q12	695	773	610	610
q13	3509	3848	3328	3328
q14	289	294	268	268
q15	510	481	463	463
q16	443	500	433	433
q17	1184	1541	1365	1365
q18	7669	7637	7383	7383
q19	849	861	992	861
q20	1977	2008	1879	1879
q21	5008	4540	4600	4540
q22	1067	998	956	956
Total cold run time: 52237 ms
Total hot run time: 50113 ms

doris-robot · 2025-05-09T10:18:49Z

TPC-DS: Total hot run time: 185185 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2ec931675b91999cd001e3a564d257ce6e51ac2b, data reload: false

query1	1002	482	476	476
query2	6584	1833	1807	1807
query3	6749	235	227	227
query4	26477	23843	23410	23410
query5	4346	632	444	444
query6	323	206	195	195
query7	4627	484	292	292
query8	299	241	233	233
query9	8625	2538	2555	2538
query10	470	316	282	282
query11	15510	15001	14674	14674
query12	160	110	103	103
query13	1637	520	380	380
query14	9513	6097	6246	6097
query15	201	194	164	164
query16	7314	663	499	499
query17	1199	722	584	584
query18	1973	403	298	298
query19	191	190	159	159
query20	122	119	118	118
query21	213	123	108	108
query22	3992	4109	4008	4008
query23	33906	32888	32796	32796
query24	8492	2400	2411	2400
query25	572	481	421	421
query26	1238	267	159	159
query27	2729	488	335	335
query28	4338	2082	2075	2075
query29	729	541	429	429
query30	279	219	183	183
query31	969	838	756	756
query32	69	64	62	62
query33	546	378	303	303
query34	792	847	521	521
query35	761	786	713	713
query36	934	969	889	889
query37	108	103	77	77
query38	4073	4206	4148	4148
query39	1529	1387	1369	1369
query40	210	115	108	108
query41	58	55	52	52
query42	117	105	104	104
query43	504	515	477	477
query44	1278	793	780	780
query45	172	174	161	161
query46	821	1024	641	641
query47	1763	1785	1733	1733
query48	369	401	297	297
query49	771	493	421	421
query50	666	677	391	391
query51	4091	4038	4061	4038
query52	108	117	99	99
query53	221	250	185	185
query54	579	562	494	494
query55	85	84	79	79
query56	303	293	271	271
query57	1158	1138	1122	1122
query58	267	252	245	245
query59	2663	2823	2683	2683
query60	317	314	298	298
query61	143	121	121	121
query62	817	726	649	649
query63	224	204	188	188
query64	4292	986	650	650
query65	4274	4211	4225	4211
query66	1172	412	331	331
query67	15664	15396	15138	15138
query68	8156	877	505	505
query69	458	295	263	263
query70	1224	1061	1079	1061
query71	470	307	300	300
query72	5494	4815	4845	4815
query73	730	646	355	355
query74	8830	9099	8675	8675
query75	3836	3180	2716	2716
query76	3712	1170	750	750
query77	783	380	287	287
query78	9914	10211	9248	9248
query79	2267	813	565	565
query80	658	505	444	444
query81	467	246	225	225
query82	422	127	92	92
query83	280	252	238	238
query84	295	111	88	88
query85	784	341	297	297
query86	331	301	283	283
query87	4400	4412	4305	4305
query88	3133	2194	2220	2194
query89	390	301	281	281
query90	1952	210	214	210
query91	144	143	111	111
query92	75	58	60	58
query93	1598	921	580	580
query94	664	400	303	303
query95	379	299	290	290
query96	495	564	280	280
query97	3133	3205	3143	3143
query98	234	209	208	208
query99	1450	1383	1316	1316
Total cold run time: 273856 ms
Total hot run time: 185185 ms

doris-robot · 2025-05-09T10:23:59Z

ClickBench: Total hot run time: 29.07 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2ec931675b91999cd001e3a564d257ce6e51ac2b, data reload: false

query1	0.04	0.03	0.03
query2	0.12	0.10	0.10
query3	0.26	0.19	0.19
query4	1.61	0.20	0.19
query5	0.60	0.60	0.59
query6	1.19	0.72	0.72
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.52	0.50
query10	0.57	0.56	0.57
query11	0.16	0.10	0.11
query12	0.15	0.12	0.11
query13	0.61	0.60	0.60
query14	0.78	0.81	0.80
query15	0.86	0.84	0.85
query16	0.39	0.38	0.38
query17	1.02	1.03	1.02
query18	0.21	0.19	0.19
query19	1.94	1.78	1.80
query20	0.01	0.01	0.02
query21	15.41	0.94	0.55
query22	0.75	1.24	0.67
query23	14.98	1.39	0.60
query24	6.99	1.27	0.76
query25	0.55	0.20	0.13
query26	0.59	0.15	0.14
query27	0.05	0.04	0.04
query28	10.12	0.87	0.42
query29	12.55	3.93	3.27
query30	0.24	0.10	0.06
query31	2.81	0.59	0.38
query32	3.21	0.54	0.45
query33	3.13	3.04	3.04
query34	15.77	5.12	4.52
query35	4.52	4.48	4.48
query36	0.67	0.50	0.48
query37	0.08	0.07	0.06
query38	0.06	0.04	0.04
query39	0.02	0.02	0.02
query40	0.16	0.12	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.98 s
Total hot run time: 29.07 s

hello-stephen · 2025-05-09T11:24:30Z

BE UT Coverage Report

Increment line coverage 0.00% (0/8) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	55.71% (14870/26693)
Line Coverage	44.52% (131532/295468)
Region Coverage	43.58% (66148/151784)
Branch Coverage	38.17% (33879/88768)

suxiaogang223 · 2025-05-14T09:23:29Z

run external

hello-stephen · 2025-05-14T10:47:58Z

BE Regression && UT Coverage Report

Increment line coverage 75.00% (6/8) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	79.39% (20849/26261)
Line Coverage	72.58% (214408/295409)
Region Coverage	70.78% (126195/178284)
Branch Coverage	64.50% (65384/101376)

suxiaogang223 · 2025-05-15T15:30:36Z

run buildall

doris-robot · 2025-05-15T15:57:21Z

TPC-H: Total hot run time: 33718 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a046364b577a16bbc502ef4db24832e34e2fd9f1, data reload: false

------ Round 1 ----------------------------------
q1	26326	5012	5016	5012
q2	2076	278	177	177
q3	10395	1223	686	686
q4	10221	996	503	503
q5	7530	2396	2313	2313
q6	185	165	129	129
q7	899	746	628	628
q8	9308	1276	1111	1111
q9	6898	5073	5117	5073
q10	6800	2297	1892	1892
q11	487	287	271	271
q12	337	348	208	208
q13	17768	3659	3055	3055
q14	220	218	211	211
q15	524	490	496	490
q16	408	432	372	372
q17	590	854	365	365
q18	7631	7208	7104	7104
q19	1078	950	558	558
q20	337	338	222	222
q21	3861	2558	2354	2354
q22	1037	999	984	984
Total cold run time: 114916 ms
Total hot run time: 33718 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5049	5057	5069	5057
q2	246	326	232	232
q3	2136	2702	2314	2314
q4	1349	1738	1340	1340
q5	4388	4391	4435	4391
q6	219	179	129	129
q7	1968	1879	1756	1756
q8	2552	2483	2446	2446
q9	7195	7123	7138	7123
q10	3007	3163	2738	2738
q11	584	496	470	470
q12	661	767	601	601
q13	3414	3827	3333	3333
q14	296	291	264	264
q15	534	492	476	476
q16	439	510	438	438
q17	1129	1525	1363	1363
q18	7821	7495	7358	7358
q19	799	808	847	808
q20	1999	2070	1904	1904
q21	4891	4245	4289	4245
q22	1028	1012	989	989
Total cold run time: 51704 ms
Total hot run time: 49775 ms

doris-robot · 2025-05-15T16:08:55Z

TPC-DS: Total hot run time: 186074 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a046364b577a16bbc502ef4db24832e34e2fd9f1, data reload: false

query1	1024	464	486	464
query2	6580	1767	1752	1752
query3	6742	220	214	214
query4	32588	23812	23248	23248
query5	5547	640	451	451
query6	279	213	207	207
query7	4055	483	290	290
query8	287	253	226	226
query9	5186	2583	2615	2583
query10	480	322	255	255
query11	15256	14993	14777	14777
query12	165	109	106	106
query13	1007	510	413	413
query14	9249	6067	6085	6067
query15	221	193	164	164
query16	7425	633	469	469
query17	1175	721	589	589
query18	2131	406	309	309
query19	198	196	176	176
query20	119	117	114	114
query21	221	131	107	107
query22	4175	4307	4142	4142
query23	33840	33128	33140	33128
query24	8329	2388	2388	2388
query25	571	527	403	403
query26	1234	263	157	157
query27	2747	501	330	330
query28	4298	2103	2083	2083
query29	743	556	436	436
query30	280	212	186	186
query31	934	885	752	752
query32	76	69	69	69
query33	527	405	302	302
query34	789	834	521	521
query35	787	790	749	749
query36	937	982	886	886
query37	120	99	74	74
query38	4200	4151	4138	4138
query39	1451	1405	1424	1405
query40	210	126	107	107
query41	58	54	59	54
query42	127	111	104	104
query43	491	481	475	475
query44	1287	803	802	802
query45	177	172	166	166
query46	838	1019	643	643
query47	1786	1846	1777	1777
query48	385	443	303	303
query49	778	515	425	425
query50	652	710	399	399
query51	4131	4206	4050	4050
query52	111	107	97	97
query53	226	255	181	181
query54	571	557	497	497
query55	86	84	82	82
query56	289	307	296	296
query57	1145	1129	1092	1092
query58	272	252	250	250
query59	2563	2629	2506	2506
query60	333	339	327	327
query61	130	124	127	124
query62	817	728	656	656
query63	217	186	184	184
query64	4410	1020	680	680
query65	4344	4233	4311	4233
query66	1038	408	324	324
query67	15863	15798	15582	15582
query68	8989	875	560	560
query69	495	303	270	270
query70	1210	1085	1127	1085
query71	483	329	303	303
query72	5244	4658	4621	4621
query73	917	570	338	338
query74	9125	9121	9078	9078
query75	4196	3211	2719	2719
query76	4092	1192	744	744
query77	797	392	304	304
query78	10031	10254	9393	9393
query79	1609	827	578	578
query80	636	526	453	453
query81	469	257	224	224
query82	385	137	99	99
query83	286	265	235	235
query84	308	106	87	87
query85	750	360	311	311
query86	359	319	296	296
query87	4495	4485	4373	4373
query88	2839	2266	2286	2266
query89	393	313	285	285
query90	1963	210	207	207
query91	143	143	111	111
query92	77	64	56	56
query93	1087	949	586	586
query94	683	462	294	294
query95	368	298	287	287
query96	499	572	279	279
query97	2678	2734	2623	2623
query98	221	212	214	212
query99	1433	1384	1251	1251
Total cold run time: 276568 ms
Total hot run time: 186074 ms

doris-robot · 2025-05-15T16:14:07Z

ClickBench: Total hot run time: 28.95 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a046364b577a16bbc502ef4db24832e34e2fd9f1, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.10	0.11
query3	0.25	0.20	0.20
query4	1.59	0.19	0.11
query5	0.46	0.42	0.42
query6	1.17	0.65	0.66
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.58	0.51	0.54
query10	0.56	0.58	0.57
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.61	0.60	0.60
query14	0.78	0.81	0.82
query15	0.88	0.83	0.86
query16	0.37	0.38	0.37
query17	1.03	1.06	1.03
query18	0.22	0.21	0.20
query19	1.92	1.78	1.79
query20	0.02	0.01	0.01
query21	15.41	0.93	0.54
query22	0.74	1.17	0.67
query23	14.97	1.36	0.61
query24	7.36	1.10	0.80
query25	0.51	0.20	0.07
query26	0.59	0.16	0.14
query27	0.05	0.05	0.05
query28	9.94	0.88	0.43
query29	12.61	4.06	3.38
query30	0.24	0.09	0.06
query31	2.84	0.62	0.38
query32	3.23	0.54	0.46
query33	3.01	3.13	3.10
query34	15.75	5.07	4.51
query35	4.50	4.51	4.46
query36	0.69	0.50	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.18	0.13	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.9 s
Total hot run time: 28.95 s

suxiaogang223 · 2025-05-16T03:57:39Z

run buildall

doris-robot · 2025-05-16T04:17:56Z

TPC-H: Total hot run time: 33932 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 10aedd458677081d90d865859c7a330c65b511c4, data reload: false

------ Round 1 ----------------------------------
q1	26285	5012	4971	4971
q2	2072	280	191	191
q3	10378	1216	710	710
q4	10231	1001	538	538
q5	7488	2364	2353	2353
q6	178	166	128	128
q7	901	738	612	612
q8	9324	1296	1098	1098
q9	6778	5072	5124	5072
q10	6807	2290	1867	1867
q11	473	284	270	270
q12	336	350	208	208
q13	17747	3637	3042	3042
q14	225	222	211	211
q15	542	491	502	491
q16	409	432	367	367
q17	594	859	386	386
q18	7458	7267	7286	7267
q19	1069	940	549	549
q20	357	336	240	240
q21	3851	3197	2385	2385
q22	1050	1030	976	976
Total cold run time: 114553 ms
Total hot run time: 33932 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5057	5015	5054	5015
q2	245	326	230	230
q3	2146	2670	2302	2302
q4	1316	1781	1364	1364
q5	4456	4448	4404	4404
q6	223	172	126	126
q7	1945	1905	1728	1728
q8	2550	2515	2453	2453
q9	7283	7063	7156	7063
q10	2993	3190	2697	2697
q11	567	503	484	484
q12	631	753	627	627
q13	3464	3831	3232	3232
q14	273	288	268	268
q15	548	496	502	496
q16	475	484	443	443
q17	1140	1570	1368	1368
q18	7765	7636	7356	7356
q19	808	757	818	757
q20	1978	2053	1903	1903
q21	4837	4347	4219	4219
q22	1047	1049	976	976
Total cold run time: 51747 ms
Total hot run time: 49511 ms

doris-robot · 2025-05-16T04:29:35Z

TPC-DS: Total hot run time: 186341 ms

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 10aedd458677081d90d865859c7a330c65b511c4, data reload: false

query1	1004	461	488	461
query2	6583	1830	1770	1770
query3	6745	221	222	221
query4	26699	23181	23402	23181
query5	4342	656	479	479
query6	305	196	192	192
query7	4622	478	291	291
query8	282	241	235	235
query9	8585	2634	2649	2634
query10	474	325	277	277
query11	15942	14992	14956	14956
query12	156	109	115	109
query13	1651	532	411	411
query14	10171	6137	6018	6018
query15	200	200	175	175
query16	7235	630	468	468
query17	1193	709	590	590
query18	1973	402	301	301
query19	195	192	162	162
query20	117	118	118	118
query21	216	128	116	116
query22	4443	4463	4351	4351
query23	34106	33195	33163	33163
query24	7686	2411	2443	2411
query25	561	500	426	426
query26	1246	265	163	163
query27	2611	486	352	352
query28	4311	2146	2131	2131
query29	810	577	528	528
query30	279	209	184	184
query31	956	832	759	759
query32	76	63	72	63
query33	548	373	302	302
query34	808	819	524	524
query35	792	805	738	738
query36	963	1006	868	868
query37	120	106	75	75
query38	4088	4105	4072	4072
query39	1458	1423	1406	1406
query40	212	118	105	105
query41	56	54	53	53
query42	132	122	113	113
query43	502	490	469	469
query44	1308	820	831	820
query45	182	168	164	164
query46	826	1033	640	640
query47	1785	1816	1761	1761
query48	402	442	319	319
query49	763	541	435	435
query50	647	692	430	430
query51	4158	4266	4094	4094
query52	107	109	105	105
query53	215	251	180	180
query54	583	576	497	497
query55	87	84	84	84
query56	305	310	296	296
query57	1147	1180	1105	1105
query58	268	263	248	248
query59	2708	2739	2543	2543
query60	318	332	304	304
query61	126	125	126	125
query62	820	721	656	656
query63	224	193	191	191
query64	4355	1037	703	703
query65	4334	4277	4232	4232
query66	1126	427	312	312
query67	15890	15607	15356	15356
query68	8631	899	510	510
query69	476	310	272	272
query70	1195	1063	1118	1063
query71	479	328	305	305
query72	5740	4620	4619	4619
query73	700	568	352	352
query74	8896	8999	9051	8999
query75	4047	3191	2677	2677
query76	3730	1171	746	746
query77	786	372	293	293
query78	10094	10254	9338	9338
query79	3848	833	569	569
query80	693	545	447	447
query81	463	267	222	222
query82	678	133	97	97
query83	283	245	237	237
query84	293	111	84	84
query85	786	358	318	318
query86	338	276	306	276
query87	4293	4466	4317	4317
query88	2995	2322	2329	2322
query89	455	324	288	288
query90	1970	212	216	212
query91	144	145	114	114
query92	74	61	57	57
query93	2390	967	573	573
query94	664	430	266	266
query95	383	296	287	287
query96	506	591	289	289
query97	2763	2761	2634	2634
query98	226	223	240	223
query99	1470	1412	1314	1314
Total cold run time: 278627 ms
Total hot run time: 186341 ms

doris-robot · 2025-05-16T04:34:43Z

ClickBench: Total hot run time: 28.76 s

machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 10aedd458677081d90d865859c7a330c65b511c4, data reload: false

query1	0.03	0.04	0.03
query2	0.12	0.11	0.10
query3	0.25	0.20	0.20
query4	1.59	0.20	0.20
query5	0.46	0.44	0.44
query6	1.15	0.65	0.66
query7	0.02	0.01	0.02
query8	0.04	0.03	0.03
query9	0.57	0.51	0.51
query10	0.58	0.58	0.56
query11	0.15	0.11	0.11
query12	0.15	0.12	0.12
query13	0.61	0.61	0.60
query14	0.78	0.81	0.82
query15	0.87	0.86	0.84
query16	0.39	0.38	0.38
query17	1.05	1.04	1.05
query18	0.23	0.21	0.21
query19	1.86	1.85	1.86
query20	0.02	0.01	0.01
query21	15.41	0.91	0.57
query22	0.75	1.21	0.71
query23	14.84	1.37	0.64
query24	6.89	1.39	0.54
query25	0.49	0.27	0.07
query26	0.51	0.16	0.15
query27	0.05	0.05	0.04
query28	9.56	0.88	0.43
query29	12.56	3.91	3.24
query30	0.25	0.10	0.07
query31	2.82	0.59	0.38
query32	3.22	0.56	0.46
query33	3.13	3.10	3.05
query34	15.77	5.05	4.44
query35	4.53	4.48	4.50
query36	0.67	0.50	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.03	0.03	0.02
query40	0.16	0.13	0.13
query41	0.08	0.03	0.02
query42	0.03	0.03	0.02
query43	0.03	0.03	0.03
Total cold run time: 102.84 s
Total hot run time: 28.76 s

doris-robot · 2025-05-16T05:49:55Z

BE UT Coverage Report

Increment line coverage 0.00% (0/10) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	55.88% (14885/26639)
Line Coverage	44.66% (131902/295329)
Region Coverage	43.77% (66412/151723)
Branch Coverage	38.37% (34027/88690)

kaka11chen

LGTM

github-actions · 2025-05-16T06:17:46Z

PR approved by at least one committer and no changes requested.

github-actions · 2025-05-16T06:17:49Z

PR approved by anyone and no changes requested.

hello-stephen · 2025-05-16T06:48:17Z

BE Regression && UT Coverage Report

Increment line coverage 70.00% (7/10) 🎉

Increment coverage report
Complete coverage report

Category	Coverage
Function Coverage	79.37% (20815/26226)
Line Coverage	72.63% (214499/295340)
Region Coverage	70.81% (126240/178272)
Branch Coverage	64.56% (65412/101318)

… express is not binary pred and in pred (apache#50749) Related PR: apache#42113 Problem Summary: In the previous fix, the conditions for when dictionary filtering can be performed were wrong.

…n predicate express is not binary pred and in pred (#50749) (#51266) cherry-pick: #50749

… express is not binary pred and in pred (apache#50749) ### What problem does this PR solve? Related PR: apache#42113 Problem Summary: In the previous fix, the conditions for when dictionary filtering can be performed were wrong.

…n predicate express is not binary pred and in pred (#50749) (#51267) cherry-pick: #50749

fix

2ec9316

morningman added dev/2.1.x dev/3.0.x labels May 15, 2025

fix

a046364

add cases

10aedd4

kaka11chen approved these changes May 16, 2025

View reviewed changes

github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels May 16, 2025

morningman approved these changes May 21, 2025

View reviewed changes

morningman merged commit ae3a880 into apache:master May 21, 2025
23 of 26 checks passed

github-actions bot added dev/3.0.x-conflict dev/2.1.x-conflict labels May 21, 2025

suxiaogang223 mentioned this pull request May 26, 2025

branch-2.1:[fix](parquet/orc) Disable string dictionary filtering when predicate express is not binary pred and in pred (#50749) #51266

Merged

suxiaogang223 mentioned this pull request May 26, 2025

branch-3.0:[fix](parquet/orc) Disable string dictionary filtering when predicate express is not binary pred and in pred (#50749) #51267

Merged

morningman added the p0_w label May 27, 2025

yiguolei pushed a commit that referenced this pull request May 27, 2025

branch-2.1:[fix](parquet/orc) Disable string dictionary filtering whe…

dd89a78

…n predicate express is not binary pred and in pred (#50749) (#51266) cherry-pick: #50749

yiguolei added dev/2.1.11-merged and removed dev/2.1.x dev/2.1.x-conflict labels May 27, 2025

dataroaring pushed a commit that referenced this pull request Jun 11, 2025

branch-3.0:[fix](parquet/orc) Disable string dictionary filtering whe…

80eae07

…n predicate express is not binary pred and in pred (#50749) (#51267) cherry-pick: #50749

dataroaring added dev/3.0.7-merged and removed dev/3.0.x dev/3.0.x-conflict labels Jun 11, 2025

morrySnow added the dev/3.1.0-merged label Jun 17, 2025

suxiaogang223 deleted the fix_dict_filter branch July 10, 2025 09:01

[fix](parquet/orc) Disable string dictionary filtering when predicate express is not binary pred and in pred #50749

[fix](parquet/orc) Disable string dictionary filtering when predicate express is not binary pred and in pred #50749

Uh oh!

Conversation

suxiaogang223 commented May 9, 2025

What problem does this PR solve?

Release note

Check List (For Author)

Check List (For Reviewer who merge this PR)

Uh oh!

hello-stephen commented May 9, 2025

Uh oh!

suxiaogang223 commented May 9, 2025

Uh oh!

doris-robot commented May 9, 2025

Uh oh!

doris-robot commented May 9, 2025

Uh oh!

doris-robot commented May 9, 2025

Uh oh!

hello-stephen commented May 9, 2025

BE UT Coverage Report

Uh oh!

suxiaogang223 commented May 14, 2025

Uh oh!

hello-stephen commented May 14, 2025

BE Regression && UT Coverage Report

Uh oh!

suxiaogang223 commented May 15, 2025

Uh oh!

doris-robot commented May 15, 2025

Uh oh!

doris-robot commented May 15, 2025

Uh oh!

doris-robot commented May 15, 2025

Uh oh!

suxiaogang223 commented May 16, 2025

Uh oh!

doris-robot commented May 16, 2025

Uh oh!

doris-robot commented May 16, 2025

Uh oh!

doris-robot commented May 16, 2025

Uh oh!

doris-robot commented May 16, 2025

BE UT Coverage Report

Uh oh!

kaka11chen left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

github-actions bot commented May 16, 2025

Uh oh!

hello-stephen commented May 16, 2025

BE Regression && UT Coverage Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants