Skip to content

Conversation

@suxiaogang223
Copy link
Contributor

cherry-pick: #50749

… express is not binary pred and in pred (apache#50749)

Related PR: apache#42113

Problem Summary:
In the previous fix, the conditions for when dictionary filtering can be
performed were wrong.
@suxiaogang223 suxiaogang223 requested a review from yiguolei as a code owner May 26, 2025 15:40
@Thearas
Copy link
Contributor

Thearas commented May 26, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 39.02% (10322/26456)
Line Coverage 30.03% (85770/285615)
Region Coverage 28.68% (44246/154250)
Branch Coverage 25.40% (22634/89112)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 58.33% (7/12) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.55% (19429/26061)
Line Coverage 69.32% (196725/283811)
Region Coverage 66.84% (120024/179579)
Branch Coverage 59.89% (60354/100778)

@yiguolei yiguolei merged commit dd89a78 into apache:branch-2.1 May 27, 2025
18 of 20 checks passed
@suxiaogang223 suxiaogang223 deleted the fix_dict_21 branch June 27, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants