Skip to content

Conversation

@swjtu-zhanglei
Copy link
Contributor

@swjtu-zhanglei swjtu-zhanglei commented May 22, 2025

obj_info mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "ak": "new_ak",
            "sk": "new_sk"
         }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "role_arn": "new_role_arn",
            "external_id": "new_external_id"
         }
}'

s3 vault mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "ak": "test-ak2",
            "sk": "test-sk2"
        }
    }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "role_arn": "test-role-arn",
            "external_id": "test-external-id"
        }
    }
}'

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 67.74% (63/93) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.18% (18721/28290)
Region Coverage 65.90% (9302/14115)
Branch Coverage 55.70% (5011/8996)

@doris-robot
Copy link

TPC-H: Total hot run time: 34181 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 256612768bdaff8fa1fe1fcff3990dbe760ede50, data reload: false

------ Round 1 ----------------------------------
q1	27370	5077	5340	5077
q2	2063	286	201	201
q3	10437	1313	739	739
q4	10219	1025	565	565
q5	8102	2412	2402	2402
q6	186	166	136	136
q7	953	774	617	617
q8	9327	1370	1050	1050
q9	6918	5148	5114	5114
q10	6879	2340	1924	1924
q11	489	294	279	279
q12	362	350	229	229
q13	17789	3775	3090	3090
q14	234	227	219	219
q15	528	501	503	501
q16	440	432	383	383
q17	634	871	369	369
q18	7778	7209	7057	7057
q19	1756	970	577	577
q20	342	340	226	226
q21	4286	3456	2450	2450
q22	1030	1047	976	976
Total cold run time: 118122 ms
Total hot run time: 34181 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5232	5109	5081	5081
q2	244	332	236	236
q3	2235	2722	2424	2424
q4	1511	1912	1475	1475
q5	4515	4459	4354	4354
q6	217	171	128	128
q7	2013	1922	1802	1802
q8	2613	2550	2558	2550
q9	7146	7248	7166	7166
q10	3043	3215	2775	2775
q11	572	513	511	511
q12	683	798	633	633
q13	3528	3936	3212	3212
q14	274	316	277	277
q15	529	491	477	477
q16	461	503	452	452
q17	1197	1593	1414	1414
q18	7780	7532	7470	7470
q19	888	891	962	891
q20	1994	2010	1834	1834
q21	4948	4554	4454	4454
q22	1076	1057	1004	1004
Total cold run time: 52699 ms
Total hot run time: 50620 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187292 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 256612768bdaff8fa1fe1fcff3990dbe760ede50, data reload: false

query1	1024	493	495	493
query2	6560	1913	1900	1900
query3	6749	226	239	226
query4	26761	23744	23099	23099
query5	4351	618	465	465
query6	287	203	188	188
query7	4622	501	297	297
query8	299	250	232	232
query9	8622	2645	2647	2645
query10	480	329	264	264
query11	15670	15150	14797	14797
query12	162	115	105	105
query13	1652	541	425	425
query14	9160	6278	6342	6278
query15	212	193	178	178
query16	7160	659	523	523
query17	1226	742	617	617
query18	1984	411	323	323
query19	192	194	170	170
query20	123	121	122	121
query21	214	130	112	112
query22	4046	4166	4040	4040
query23	34154	33024	33038	33024
query24	8460	2475	2453	2453
query25	565	493	427	427
query26	1257	286	163	163
query27	2722	505	351	351
query28	4292	2146	2134	2134
query29	814	601	480	480
query30	295	221	192	192
query31	1007	874	788	788
query32	75	67	63	63
query33	555	357	320	320
query34	815	847	536	536
query35	789	824	732	732
query36	966	1008	907	907
query37	123	103	76	76
query38	4191	4161	4217	4161
query39	1497	1395	1443	1395
query40	217	120	113	113
query41	57	57	55	55
query42	127	109	107	107
query43	520	508	472	472
query44	1337	818	834	818
query45	181	171	169	169
query46	839	1033	643	643
query47	1780	1777	1720	1720
query48	396	425	326	326
query49	799	533	466	466
query50	679	679	410	410
query51	4165	4217	4177	4177
query52	114	112	95	95
query53	232	267	190	190
query54	596	590	520	520
query55	88	88	84	84
query56	327	291	311	291
query57	1165	1123	1118	1118
query58	267	272	268	268
query59	2553	2655	2680	2655
query60	327	333	323	323
query61	129	133	129	129
query62	791	732	657	657
query63	236	191	189	189
query64	4344	1022	695	695
query65	4370	4227	4240	4227
query66	1134	409	325	325
query67	16038	16040	15528	15528
query68	8576	912	520	520
query69	486	327	267	267
query70	1192	1134	1118	1118
query71	476	347	298	298
query72	5606	4785	4781	4781
query73	729	631	356	356
query74	8892	9271	8898	8898
query75	3950	3255	2684	2684
query76	3693	1205	812	812
query77	790	394	322	322
query78	9964	10178	9403	9403
query79	3737	806	571	571
query80	682	511	459	459
query81	473	253	227	227
query82	555	133	107	107
query83	294	276	262	262
query84	299	109	98	98
query85	800	432	325	325
query86	345	307	269	269
query87	4397	4497	4377	4377
query88	2967	2307	2353	2307
query89	453	326	286	286
query90	1947	218	218	218
query91	146	153	116	116
query92	80	62	60	60
query93	2233	987	628	628
query94	662	407	308	308
query95	384	294	291	291
query96	504	575	284	284
query97	2728	2779	2680	2680
query98	239	217	215	215
query99	1433	1394	1275	1275
Total cold run time: 277653 ms
Total hot run time: 187292 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.27 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 256612768bdaff8fa1fe1fcff3990dbe760ede50, data reload: false

query1	0.04	0.03	0.04
query2	0.12	0.10	0.12
query3	0.25	0.19	0.20
query4	1.61	0.20	0.11
query5	0.43	0.42	0.42
query6	1.18	0.67	0.66
query7	0.02	0.02	0.02
query8	0.04	0.04	0.04
query9	0.59	0.52	0.53
query10	0.57	0.57	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	0.79	0.83	0.83
query15	0.91	0.87	0.85
query16	0.38	0.40	0.38
query17	1.05	1.03	1.08
query18	0.23	0.22	0.21
query19	2.02	1.85	1.84
query20	0.02	0.01	0.01
query21	15.39	0.93	0.56
query22	0.76	1.24	0.74
query23	14.84	1.39	0.64
query24	7.42	1.21	0.56
query25	0.54	0.15	0.07
query26	0.66	0.18	0.15
query27	0.06	0.05	0.04
query28	8.85	0.90	0.46
query29	12.68	4.11	3.45
query30	0.24	0.10	0.07
query31	2.83	0.60	0.40
query32	3.24	0.56	0.47
query33	3.11	3.10	3.15
query34	15.78	5.16	4.59
query35	4.57	4.53	4.56
query36	0.66	0.52	0.48
query37	0.09	0.07	0.06
query38	0.05	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.14	0.13
query41	0.09	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.31 s
Total hot run time: 29.27 s

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 67.74% (63/93) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.22% (18735/28290)
Region Coverage 65.88% (9299/14115)
Branch Coverage 55.70% (5011/8996)

@doris-robot
Copy link

TPC-H: Total hot run time: 34072 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 256612768bdaff8fa1fe1fcff3990dbe760ede50, data reload: false

------ Round 1 ----------------------------------
q1	26443	5929	5134	5134
q2	2080	308	188	188
q3	10359	1278	690	690
q4	10234	1019	542	542
q5	7539	2440	2373	2373
q6	188	168	133	133
q7	953	764	612	612
q8	9321	1304	1061	1061
q9	6787	5172	5164	5164
q10	6869	2341	1907	1907
q11	498	295	289	289
q12	353	356	214	214
q13	17764	3713	3139	3139
q14	237	241	212	212
q15	543	492	480	480
q16	437	446	387	387
q17	618	879	376	376
q18	7712	7083	7182	7083
q19	2035	976	561	561
q20	341	337	225	225
q21	3768	2629	2341	2341
q22	1069	997	961	961
Total cold run time: 116148 ms
Total hot run time: 34072 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5259	5135	5187	5135
q2	247	337	233	233
q3	2173	2646	2326	2326
q4	1367	1830	1465	1465
q5	4500	4494	4444	4444
q6	218	168	127	127
q7	1987	1945	1786	1786
q8	2636	2626	2565	2565
q9	7202	7170	7205	7170
q10	3069	3174	2748	2748
q11	600	518	490	490
q12	681	772	607	607
q13	3590	3997	3368	3368
q14	314	312	267	267
q15	537	511	491	491
q16	452	486	443	443
q17	1200	1599	1407	1407
q18	7774	7484	7469	7469
q19	845	876	980	876
q20	2065	1987	1830	1830
q21	4899	4602	4434	4434
q22	1045	1057	1011	1011
Total cold run time: 52660 ms
Total hot run time: 50692 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193352 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 256612768bdaff8fa1fe1fcff3990dbe760ede50, data reload: false

query1	1414	1093	1067	1067
query2	6314	1833	1822	1822
query3	11059	4602	4489	4489
query4	55753	24474	23553	23553
query5	5052	527	463	463
query6	314	210	187	187
query7	4863	508	294	294
query8	296	268	227	227
query9	5418	2700	2687	2687
query10	446	338	273	273
query11	14995	14996	14790	14790
query12	165	109	104	104
query13	1032	528	408	408
query14	10303	6480	6432	6432
query15	208	202	174	174
query16	7226	637	487	487
query17	1105	765	604	604
query18	1650	419	319	319
query19	216	205	175	175
query20	148	127	127	127
query21	206	127	108	108
query22	4234	4533	4367	4367
query23	34201	33467	33533	33467
query24	6368	2496	2403	2403
query25	476	474	410	410
query26	687	281	157	157
query27	2376	515	342	342
query28	3315	2198	2177	2177
query29	588	570	450	450
query30	271	220	194	194
query31	881	858	803	803
query32	72	64	64	64
query33	443	394	300	300
query34	810	866	548	548
query35	833	820	769	769
query36	949	1017	917	917
query37	119	109	79	79
query38	4383	4290	4141	4141
query39	1505	1446	1489	1446
query40	211	128	123	123
query41	58	60	53	53
query42	126	114	108	108
query43	505	520	494	494
query44	1417	845	846	845
query45	180	175	171	171
query46	866	1035	674	674
query47	1806	1906	1810	1810
query48	410	425	337	337
query49	669	533	470	470
query50	676	695	414	414
query51	4249	4318	4153	4153
query52	109	105	100	100
query53	242	265	189	189
query54	610	589	509	509
query55	84	85	86	85
query56	306	321	309	309
query57	1150	1174	1147	1147
query58	271	253	262	253
query59	2672	2768	2664	2664
query60	356	321	331	321
query61	124	127	127	127
query62	803	741	639	639
query63	224	184	187	184
query64	1667	1041	688	688
query65	4338	4238	4250	4238
query66	708	405	311	311
query67	16106	15579	15317	15317
query68	7864	897	527	527
query69	546	311	275	275
query70	1189	1150	1103	1103
query71	497	349	296	296
query72	5985	4861	5007	4861
query73	1287	694	356	356
query74	9243	9103	8957	8957
query75	3825	3206	2717	2717
query76	4100	1198	792	792
query77	629	376	293	293
query78	10283	10074	9362	9362
query79	3582	830	576	576
query80	828	511	503	503
query81	498	255	223	223
query82	464	131	98	98
query83	356	260	236	236
query84	295	106	87	87
query85	791	349	314	314
query86	405	292	281	281
query87	4347	4493	4391	4391
query88	3655	2307	2304	2304
query89	405	316	280	280
query90	1789	213	213	213
query91	153	218	108	108
query92	77	59	60	59
query93	2665	945	579	579
query94	659	419	267	267
query95	369	300	295	295
query96	498	575	284	284
query97	2738	2733	2661	2661
query98	230	219	205	205
query99	1438	1379	1292	1292
Total cold run time: 303327 ms
Total hot run time: 193352 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.87 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 256612768bdaff8fa1fe1fcff3990dbe760ede50, data reload: false

query1	0.03	0.03	0.03
query2	0.15	0.12	0.11
query3	0.38	0.20	0.20
query4	1.60	0.20	0.20
query5	0.49	0.46	0.49
query6	1.17	0.67	0.67
query7	0.02	0.02	0.02
query8	0.06	0.05	0.04
query9	0.64	0.52	0.53
query10	0.57	0.58	0.58
query11	0.27	0.12	0.13
query12	0.25	0.13	0.14
query13	0.64	0.62	0.62
query14	0.79	0.84	0.83
query15	0.97	0.88	0.87
query16	0.38	0.38	0.37
query17	1.03	1.05	1.07
query18	0.19	0.19	0.18
query19	1.98	1.91	1.85
query20	0.02	0.02	0.01
query21	15.39	0.95	0.66
query22	0.93	1.04	0.79
query23	14.73	1.57	0.77
query24	5.20	0.62	0.31
query25	0.17	0.09	0.08
query26	0.56	0.22	0.18
query27	0.09	0.08	0.09
query28	10.99	1.24	0.59
query29	12.51	4.15	3.43
query30	0.30	0.08	0.07
query31	2.85	0.64	0.43
query32	3.23	0.61	0.51
query33	3.15	3.14	3.18
query34	16.05	5.19	4.37
query35	4.50	4.49	4.42
query36	0.64	0.52	0.51
query37	0.19	0.17	0.18
query38	0.18	0.18	0.15
query39	0.05	0.04	0.04
query40	0.20	0.17	0.16
query41	0.11	0.06	0.05
query42	0.06	0.05	0.06
query43	0.05	0.05	0.05
Total cold run time: 103.76 s
Total hot run time: 29.87 s

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 67.74% (63/93) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.18% (18721/28290)
Region Coverage 65.91% (9303/14115)
Branch Coverage 55.71% (5012/8996)

@doris-robot
Copy link

TPC-H: Total hot run time: 33838 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit aeea41bc407d6ee280252b096919a088d889c413, data reload: false

------ Round 1 ----------------------------------
q1	26404	5111	5022	5022
q2	2075	284	198	198
q3	10737	1310	699	699
q4	10272	984	532	532
q5	8249	2376	2386	2376
q6	182	164	132	132
q7	908	725	614	614
q8	9316	1280	1092	1092
q9	6877	5034	5120	5034
q10	6821	2335	1895	1895
q11	507	286	272	272
q12	339	352	214	214
q13	17776	3633	3089	3089
q14	236	234	215	215
q15	532	487	490	487
q16	431	423	375	375
q17	594	861	374	374
q18	7649	7200	7144	7144
q19	1700	953	539	539
q20	324	326	223	223
q21	3644	3164	2336	2336
q22	1043	1032	976	976
Total cold run time: 116616 ms
Total hot run time: 33838 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5237	5480	5104	5104
q2	241	327	237	237
q3	2180	2646	2305	2305
q4	1329	1782	1486	1486
q5	4458	4370	4427	4370
q6	212	167	133	133
q7	1970	1959	1752	1752
q8	2600	2522	2479	2479
q9	7298	7234	7102	7102
q10	2997	3176	2747	2747
q11	593	519	504	504
q12	684	755	613	613
q13	3507	3863	3310	3310
q14	316	315	276	276
q15	523	479	472	472
q16	436	485	452	452
q17	1153	1541	1354	1354
q18	7768	7676	7435	7435
q19	806	826	894	826
q20	1994	1974	1837	1837
q21	4814	4462	4328	4328
q22	1103	1084	1043	1043
Total cold run time: 52219 ms
Total hot run time: 50165 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195200 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit aeea41bc407d6ee280252b096919a088d889c413, data reload: false

query1	1431	1088	1081	1081
query2	6261	1805	1832	1805
query3	11076	4668	4769	4668
query4	26009	24007	23524	23524
query5	3925	659	483	483
query6	330	231	201	201
query7	3989	544	294	294
query8	325	267	248	248
query9	8527	2659	2661	2659
query10	482	339	285	285
query11	15586	15340	14798	14798
query12	167	118	115	115
query13	1567	542	412	412
query14	9281	6667	6695	6667
query15	216	202	175	175
query16	7667	660	520	520
query17	1168	833	621	621
query18	2045	491	309	309
query19	199	198	164	164
query20	128	129	131	129
query21	212	141	111	111
query22	4548	4585	4376	4376
query23	34980	33814	33989	33814
query24	8828	2504	2575	2504
query25	553	507	423	423
query26	1182	295	156	156
query27	2876	547	358	358
query28	4416	2170	2182	2170
query29	722	611	456	456
query30	276	260	206	206
query31	986	920	797	797
query32	76	78	94	78
query33	538	397	351	351
query34	842	945	547	547
query35	850	891	764	764
query36	1036	1029	923	923
query37	124	111	81	81
query38	4226	4235	4301	4235
query39	1579	1501	1491	1491
query40	216	123	117	117
query41	61	55	56	55
query42	125	110	113	110
query43	540	525	465	465
query44	1414	867	846	846
query45	198	185	182	182
query46	930	1123	696	696
query47	1859	1865	1789	1789
query48	401	449	330	330
query49	775	557	445	445
query50	702	730	408	408
query51	4358	4454	4317	4317
query52	116	115	106	106
query53	240	276	200	200
query54	616	605	538	538
query55	96	92	86	86
query56	325	302	307	302
query57	1211	1229	1161	1161
query58	277	285	277	277
query59	2747	2747	2620	2620
query60	349	349	317	317
query61	134	121	124	121
query62	832	799	715	715
query63	262	199	203	199
query64	4389	1046	735	735
query65	4534	4388	4357	4357
query66	954	455	335	335
query67	15876	15711	15375	15375
query68	8920	922	533	533
query69	485	318	276	276
query70	1266	1103	1088	1088
query71	484	333	308	308
query72	5608	4654	4655	4654
query73	694	602	361	361
query74	9409	9159	9132	9132
query75	4172	3408	2784	2784
query76	3758	1332	836	836
query77	786	496	301	301
query78	10306	10380	9411	9411
query79	2105	891	592	592
query80	626	559	463	463
query81	502	271	235	235
query82	466	137	104	104
query83	254	262	242	242
query84	252	104	88	88
query85	786	420	319	319
query86	377	327	294	294
query87	4517	4588	4317	4317
query88	3800	2346	2284	2284
query89	455	356	298	298
query90	1838	219	216	216
query91	141	143	113	113
query92	77	64	59	59
query93	1698	1008	593	593
query94	655	430	308	308
query95	374	298	292	292
query96	513	623	284	284
query97	2768	2783	2705	2705
query98	233	202	213	202
query99	1511	1473	1305	1305
Total cold run time: 283602 ms
Total hot run time: 195200 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.81 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit aeea41bc407d6ee280252b096919a088d889c413, data reload: false

query1	0.03	0.03	0.03
query2	0.15	0.11	0.11
query3	0.35	0.20	0.19
query4	1.59	0.20	0.21
query5	0.47	0.45	0.45
query6	1.15	0.67	0.66
query7	0.03	0.02	0.01
query8	0.05	0.05	0.05
query9	0.62	0.52	0.53
query10	0.59	0.60	0.57
query11	0.26	0.12	0.12
query12	0.26	0.14	0.13
query13	0.64	0.63	0.64
query14	0.79	0.81	0.82
query15	0.96	0.89	0.90
query16	0.37	0.38	0.36
query17	1.02	1.05	1.06
query18	0.18	0.18	0.18
query19	1.97	1.80	1.90
query20	0.01	0.01	0.01
query21	15.40	0.97	0.65
query22	0.92	1.02	0.82
query23	14.67	1.56	0.78
query24	5.57	0.53	0.28
query25	0.16	0.09	0.09
query26	0.55	0.22	0.19
query27	0.08	0.08	0.09
query28	11.10	1.20	0.58
query29	12.51	4.11	3.37
query30	0.29	0.08	0.06
query31	2.84	0.65	0.43
query32	3.25	0.60	0.50
query33	3.05	3.17	3.09
query34	16.43	5.11	4.45
query35	4.47	4.48	4.50
query36	0.63	0.50	0.50
query37	0.20	0.17	0.18
query38	0.18	0.16	0.16
query39	0.05	0.05	0.04
query40	0.19	0.16	0.16
query41	0.11	0.06	0.06
query42	0.06	0.05	0.06
query43	0.05	0.05	0.05
Total cold run time: 104.25 s
Total hot run time: 29.81 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.00% (14920/26642)
Line Coverage 44.80% (132734/296294)
Region Coverage 43.86% (66723/152110)
Branch Coverage 38.50% (34235/88920)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.48% (20844/26225)
Line Coverage 72.67% (215321/296281)
Region Coverage 70.82% (126514/178654)
Branch Coverage 64.57% (65576/101558)

@swjtu-zhanglei
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 67.74% (63/93) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.25% (1113/1337)
Line Coverage 66.13% (18709/28291)
Region Coverage 65.79% (9288/14117)
Branch Coverage 55.62% (5005/8998)

@doris-robot
Copy link

TPC-H: Total hot run time: 34037 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 836edfc2e1e7f0ddb8aa76c3b1cbab81ca02095d, data reload: false

------ Round 1 ----------------------------------
q1	26411	5163	5101	5101
q2	2089	306	199	199
q3	10347	1263	703	703
q4	10240	1036	525	525
q5	7509	2340	2384	2340
q6	178	164	135	135
q7	905	763	608	608
q8	9318	1273	1115	1115
q9	6830	5151	5103	5103
q10	6878	2320	1915	1915
q11	493	288	279	279
q12	357	367	217	217
q13	17787	3650	3060	3060
q14	246	226	210	210
q15	539	491	484	484
q16	431	436	384	384
q17	619	877	382	382
q18	7871	7265	7156	7156
q19	1905	986	561	561
q20	343	350	231	231
q21	3897	3200	2360	2360
q22	1039	990	969	969
Total cold run time: 116232 ms
Total hot run time: 34037 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5273	5115	5087	5087
q2	244	333	235	235
q3	2176	2646	2256	2256
q4	1402	1816	1433	1433
q5	4506	4413	4431	4413
q6	217	176	134	134
q7	2056	1985	1764	1764
q8	2615	2641	2598	2598
q9	7295	7051	7121	7051
q10	3040	3180	2768	2768
q11	569	496	482	482
q12	718	789	591	591
q13	3560	3883	3321	3321
q14	314	300	283	283
q15	513	467	482	467
q16	436	501	469	469
q17	1159	1532	1400	1400
q18	7777	7531	7428	7428
q19	836	865	847	847
q20	1980	2004	1839	1839
q21	4853	4469	4388	4388
q22	1111	1069	1031	1031
Total cold run time: 52650 ms
Total hot run time: 50285 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193651 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 836edfc2e1e7f0ddb8aa76c3b1cbab81ca02095d, data reload: false

query1	1433	1102	1047	1047
query2	6234	1838	1835	1835
query3	11002	4648	4529	4529
query4	56022	25995	23661	23661
query5	5035	503	478	478
query6	344	214	208	208
query7	4886	512	299	299
query8	325	264	237	237
query9	5449	2658	2659	2658
query10	440	353	287	287
query11	15079	15008	14832	14832
query12	161	111	106	106
query13	1031	536	412	412
query14	10187	6196	6190	6190
query15	208	198	182	182
query16	7146	645	506	506
query17	1091	711	574	574
query18	1623	403	310	310
query19	216	197	186	186
query20	127	125	124	124
query21	219	128	105	105
query22	4679	4570	4388	4388
query23	34263	33597	33642	33597
query24	6507	2423	2446	2423
query25	487	484	424	424
query26	681	279	165	165
query27	2185	527	351	351
query28	3004	2170	2164	2164
query29	625	597	479	479
query30	278	226	194	194
query31	876	869	792	792
query32	80	68	61	61
query33	457	385	308	308
query34	769	899	562	562
query35	779	834	800	800
query36	957	1020	902	902
query37	106	97	77	77
query38	4260	4256	4191	4191
query39	1507	1456	1461	1456
query40	218	123	105	105
query41	56	54	51	51
query42	130	111	117	111
query43	510	516	515	515
query44	1343	862	861	861
query45	184	182	171	171
query46	866	1052	670	670
query47	1900	1893	1824	1824
query48	403	445	317	317
query49	653	508	453	453
query50	648	713	416	416
query51	4187	4262	4214	4214
query52	108	111	106	106
query53	223	269	186	186
query54	593	584	522	522
query55	89	98	86	86
query56	313	314	324	314
query57	1198	1212	1150	1150
query58	270	251	265	251
query59	2692	2853	2628	2628
query60	328	335	346	335
query61	143	147	125	125
query62	736	739	683	683
query63	224	188	186	186
query64	1627	995	669	669
query65	4313	4236	4290	4236
query66	708	402	303	303
query67	15962	15617	15468	15468
query68	5654	839	525	525
query69	526	298	270	270
query70	1227	1088	1081	1081
query71	451	316	305	305
query72	5853	4794	4913	4794
query73	1328	642	364	364
query74	9297	9223	8892	8892
query75	3480	3191	2686	2686
query76	3728	1194	735	735
query77	563	382	302	302
query78	10204	9928	9427	9427
query79	2705	835	574	574
query80	646	502	446	446
query81	476	261	221	221
query82	635	126	96	96
query83	253	248	231	231
query84	296	109	88	88
query85	781	342	305	305
query86	434	316	306	306
query87	4418	4469	4333	4333
query88	3619	2327	2312	2312
query89	416	318	287	287
query90	1912	210	213	210
query91	140	163	116	116
query92	77	60	60	60
query93	2439	926	578	578
query94	685	411	310	310
query95	376	294	285	285
query96	498	562	288	288
query97	2750	2796	2651	2651
query98	241	227	209	209
query99	1659	1402	1308	1308
Total cold run time: 299150 ms
Total hot run time: 193651 ms

@swjtu-zhanglei
Copy link
Contributor Author

run feut

@doris-robot
Copy link

ClickBench: Total hot run time: 29.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 836edfc2e1e7f0ddb8aa76c3b1cbab81ca02095d, data reload: false

query1	0.04	0.04	0.03
query2	0.15	0.10	0.11
query3	0.34	0.20	0.20
query4	1.60	0.19	0.20
query5	0.48	0.45	0.46
query6	1.18	0.65	0.66
query7	0.03	0.02	0.02
query8	0.05	0.05	0.04
query9	0.62	0.52	0.51
query10	0.57	0.58	0.58
query11	0.26	0.13	0.12
query12	0.26	0.13	0.13
query13	0.63	0.62	0.61
query14	0.80	0.83	0.82
query15	0.97	0.87	0.87
query16	0.37	0.37	0.37
query17	1.04	1.07	1.06
query18	0.18	0.18	0.18
query19	1.96	1.81	1.82
query20	0.01	0.02	0.01
query21	15.40	0.98	0.67
query22	0.92	1.03	0.80
query23	14.68	1.49	0.76
query24	5.19	0.58	0.30
query25	0.16	0.09	0.08
query26	0.57	0.21	0.18
query27	0.08	0.09	0.09
query28	11.02	1.18	0.58
query29	12.53	4.11	3.44
query30	0.27	0.09	0.06
query31	2.82	0.64	0.44
query32	3.23	0.59	0.50
query33	3.06	3.10	3.08
query34	16.46	5.12	4.42
query35	4.55	4.48	4.49
query36	0.63	0.50	0.50
query37	0.19	0.18	0.17
query38	0.17	0.16	0.16
query39	0.06	0.04	0.05
query40	0.20	0.17	0.16
query41	0.11	0.05	0.05
query42	0.06	0.04	0.05
query43	0.05	0.05	0.05
Total cold run time: 103.95 s
Total hot run time: 29.8 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.00% (14920/26644)
Line Coverage 44.82% (132843/296391)
Region Coverage 43.89% (66769/152119)
Branch Coverage 38.52% (34263/88944)

@doris-robot
Copy link

TPC-DS: Total hot run time: 193372 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 7fb1561df3f4f2c44744f97d4f77490d85c03a0e, data reload: false

query1	1399	1109	1081	1081
query2	6252	1820	1803	1803
query3	11034	4575	4566	4566
query4	52694	24181	23184	23184
query5	5264	597	457	457
query6	344	217	201	201
query7	4898	511	293	293
query8	282	219	199	199
query9	5390	2608	2605	2605
query10	447	320	271	271
query11	15133	15353	14858	14858
query12	155	108	104	104
query13	1029	515	409	409
query14	10347	6315	6294	6294
query15	204	208	176	176
query16	7174	664	506	506
query17	1097	726	574	574
query18	1572	389	305	305
query19	199	197	170	170
query20	129	129	153	129
query21	207	126	104	104
query22	4522	4483	4335	4335
query23	34527	33642	33788	33642
query24	6696	2466	2467	2466
query25	458	480	448	448
query26	696	278	163	163
query27	2372	514	345	345
query28	3390	2172	2185	2172
query29	630	591	461	461
query30	278	221	197	197
query31	855	865	774	774
query32	83	71	68	68
query33	452	366	329	329
query34	776	865	538	538
query35	837	849	759	759
query36	939	1007	925	925
query37	119	106	88	88
query38	4247	4254	4209	4209
query39	1527	1473	1468	1468
query40	234	133	113	113
query41	72	66	99	66
query42	129	118	108	108
query43	493	526	483	483
query44	1321	848	867	848
query45	189	172	166	166
query46	856	1044	659	659
query47	1876	1917	1825	1825
query48	395	441	333	333
query49	667	515	432	432
query50	659	711	417	417
query51	4227	4254	4242	4242
query52	111	107	96	96
query53	228	266	188	188
query54	617	586	544	544
query55	83	91	87	87
query56	307	316	297	297
query57	1210	1254	1168	1168
query58	265	263	253	253
query59	2689	2832	2799	2799
query60	341	312	318	312
query61	132	128	124	124
query62	745	741	639	639
query63	227	188	195	188
query64	1873	1070	697	697
query65	4267	4140	4156	4140
query66	710	395	303	303
query67	16321	15829	15620	15620
query68	7112	896	540	540
query69	524	302	267	267
query70	1207	1074	1098	1074
query71	498	308	288	288
query72	6044	4870	4914	4870
query73	1496	669	351	351
query74	8900	9017	8772	8772
query75	4199	3235	2760	2760
query76	4222	1216	750	750
query77	789	379	288	288
query78	10069	10070	9504	9504
query79	2612	781	580	580
query80	600	501	448	448
query81	547	246	220	220
query82	465	127	96	96
query83	277	247	225	225
query84	298	105	93	93
query85	762	358	317	317
query86	367	312	299	299
query87	4424	4430	4299	4299
query88	3783	2301	2278	2278
query89	395	316	290	290
query90	1836	201	206	201
query91	140	143	117	117
query92	78	68	66	66
query93	1982	947	598	598
query94	652	413	316	316
query95	364	296	284	284
query96	503	566	279	279
query97	2718	2746	2600	2600
query98	236	207	199	199
query99	1425	1379	1280	1280
Total cold run time: 299422 ms
Total hot run time: 193372 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.3 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 7fb1561df3f4f2c44744f97d4f77490d85c03a0e, data reload: false

query1	0.04	0.04	0.04
query2	0.15	0.10	0.10
query3	0.34	0.20	0.20
query4	1.59	0.21	0.21
query5	0.47	0.47	0.46
query6	1.15	0.65	0.66
query7	0.02	0.01	0.01
query8	0.05	0.05	0.05
query9	0.62	0.53	0.52
query10	0.57	0.58	0.57
query11	0.26	0.12	0.13
query12	0.26	0.14	0.14
query13	0.63	0.62	0.61
query14	0.79	0.83	0.84
query15	0.96	0.89	0.87
query16	0.37	0.36	0.36
query17	1.06	1.03	1.09
query18	0.18	0.19	0.19
query19	2.02	1.88	1.91
query20	0.02	0.02	0.01
query21	15.43	0.99	0.67
query22	0.92	1.09	0.79
query23	14.76	1.52	0.76
query24	5.09	0.61	0.32
query25	0.16	0.10	0.09
query26	0.55	0.22	0.18
query27	0.10	0.09	0.09
query28	11.05	1.17	0.58
query29	12.53	4.14	3.54
query30	0.28	0.08	0.07
query31	2.82	0.64	0.43
query32	3.24	0.59	0.51
query33	3.08	3.13	3.17
query34	16.60	5.11	4.60
query35	4.53	4.51	4.54
query36	0.64	0.53	0.52
query37	0.20	0.17	0.18
query38	0.16	0.16	0.15
query39	0.05	0.05	0.04
query40	0.19	0.17	0.16
query41	0.10	0.05	0.05
query42	0.06	0.05	0.06
query43	0.05	0.04	0.05
Total cold run time: 104.14 s
Total hot run time: 30.3 s

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.40% (15069/26718)
Line Coverage 45.17% (134681/298177)
Region Coverage 44.27% (67772/153094)
Branch Coverage 38.83% (34753/89502)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.86% (21001/26297)
Line Coverage 72.82% (217029/298031)
Region Coverage 71.03% (127913/180089)
Branch Coverage 64.72% (66216/102314)

.alterCluster(request);
}

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not remove it?

return w.executeRequest((client) -> client.removeDeleteBitmapUpdateLock(request));
}

/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Jun 11, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

1 similar comment
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit 4af1935 into apache:master Jun 12, 2025
24 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 12, 2025
…nfo (#51162)

```
obj_info mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "ak": "new_ak",
            "sk": "new_sk"
         }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "role_arn": "new_role_arn",
            "external_id": "new_external_id"
         }
}'

s3 vault mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "ak": "test-ak2",
            "sk": "test-sk2"
        }
    }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "role_arn": "test-role-arn",
            "external_id": "test-external-id"
        }
    }
}'
```
dataroaring pushed a commit that referenced this pull request Jun 18, 2025
…nfo (#51162)

```
obj_info mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "ak": "new_ak",
            "sk": "new_sk"
         }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "role_arn": "new_role_arn",
            "external_id": "new_external_id"
         }
}'

s3 vault mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "ak": "test-ak2",
            "sk": "test-sk2"
        }
    }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "role_arn": "test-role-arn",
            "external_id": "test-external-id"
        }
    }
}'
```
dataroaring pushed a commit that referenced this pull request Jun 19, 2025
… vault obj_info #51162 (#51685)

Cherry-picked from #51162

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jun 20, 2025
…nfo (#51162)

```
obj_info mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "ak": "new_ak",
            "sk": "new_sk"
         }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "role_arn": "new_role_arn",
            "external_id": "new_external_id"
         }
}'

s3 vault mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "ak": "test-ak2",
            "sk": "test-sk2"
        }
    }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "role_arn": "test-role-arn",
            "external_id": "test-external-id"
        }
    }
}'
```
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
… vault obj_info #51162 (#52030)

Cherry-picked from #51162

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.0.7-merged dev/3.1.0-merged p0_b reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants