-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[feat](cloud) Support alter operation for obj_info and s3 vault obj_info #51162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
3dd3ada to
2566127
Compare
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34181 ms |
TPC-DS: Total hot run time: 187292 ms |
ClickBench: Total hot run time: 29.27 s |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34072 ms |
TPC-DS: Total hot run time: 193352 ms |
ClickBench: Total hot run time: 29.87 s |
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 33838 ms |
TPC-DS: Total hot run time: 195200 ms |
ClickBench: Total hot run time: 29.81 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
Cloud UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-H: Total hot run time: 34037 ms |
TPC-DS: Total hot run time: 193651 ms |
|
run feut |
ClickBench: Total hot run time: 29.8 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 193372 ms |
ClickBench: Total hot run time: 30.3 s |
FE UT Coverage ReportIncrement line coverage |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
| .alterCluster(request); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not remove it?
| return w.executeRequest((client) -> client.removeDeleteBitmapUpdateLock(request)); | ||
| } | ||
|
|
||
| /** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
1 similar comment
|
PR approved by anyone and no changes requested. |
sollhui
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…nfo (#51162) ``` obj_info mode: curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "obj": { "id": "1", "ak": "new_ak", "sk": "new_sk" } }' curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "obj": { "id": "1", "role_arn": "new_role_arn", "external_id": "new_external_id" } }' s3 vault mode: curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "vault": { "name": "built_in_storage_vault", "obj_info": { "ak": "test-ak2", "sk": "test-sk2" } } }' curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "vault": { "name": "built_in_storage_vault", "obj_info": { "role_arn": "test-role-arn", "external_id": "test-external-id" } } }' ```
…nfo (#51162) ``` obj_info mode: curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "obj": { "id": "1", "ak": "new_ak", "sk": "new_sk" } }' curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "obj": { "id": "1", "role_arn": "new_role_arn", "external_id": "new_external_id" } }' s3 vault mode: curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "vault": { "name": "built_in_storage_vault", "obj_info": { "ak": "test-ak2", "sk": "test-sk2" } } }' curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "vault": { "name": "built_in_storage_vault", "obj_info": { "role_arn": "test-role-arn", "external_id": "test-external-id" } } }' ```
…nfo (#51162) ``` obj_info mode: curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "obj": { "id": "1", "ak": "new_ak", "sk": "new_sk" } }' curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "obj": { "id": "1", "role_arn": "new_role_arn", "external_id": "new_external_id" } }' s3 vault mode: curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "vault": { "name": "built_in_storage_vault", "obj_info": { "ak": "test-ak2", "sk": "test-sk2" } } }' curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{ "cloud_unique_id": "${cloud_unique_id}", "vault": { "name": "built_in_storage_vault", "obj_info": { "role_arn": "test-role-arn", "external_id": "test-external-id" } } }' ```
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)