Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #51162

@github-actions github-actions bot requested a review from dataroaring as a code owner June 12, 2025 14:10
@Thearas
Copy link
Contributor

Thearas commented Jun 12, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 12, 2025
@Thearas
Copy link
Contributor

Thearas commented Jun 12, 2025

run buildall

…nfo (#51162)

```
obj_info mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "ak": "new_ak",
            "sk": "new_sk"
         }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_obj_info?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
        "obj": {
            "id": "1",
            "role_arn": "new_role_arn",
            "external_id": "new_external_id"
         }
}'

s3 vault mode:

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "ak": "test-ak2",
            "sk": "test-sk2"
        }
    }
}'

curl '127.0.0.1:5000/MetaService/http/v1/?alter_s3_vault?token=greedisgood9999' -d '{
    "cloud_unique_id": "${cloud_unique_id}",
    "vault": {
        "name": "built_in_storage_vault",
        "obj_info": {
            "role_arn": "test-role-arn",
            "external_id": "test-external-id"
        }
    }
}'
```
@dataroaring dataroaring force-pushed the auto-pick-51162-branch-3.0 branch from a4f6226 to f9a8200 Compare June 18, 2025 04:20
@dataroaring
Copy link
Contributor

run buildall

@hello-stephen
Copy link
Contributor

Cloud UT Coverage Report

Increment line coverage 67.74% (63/93) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.14% (1095/1317)
Line Coverage 66.37% (18337/27628)
Region Coverage 66.15% (9085/13734)
Branch Coverage 56.09% (4931/8792)

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.16% (10902/26487)
Line Coverage 31.98% (93263/291660)
Region Coverage 31.05% (48084/154883)
Branch Coverage 27.51% (24631/89520)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 66681cf into branch-3.0 Jun 19, 2025
23 of 30 checks passed
@github-actions github-actions bot deleted the auto-pick-51162-branch-3.0 branch June 19, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants