-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[enhancement](cloud) monitor evict size of file cache active gc #51197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
monitor file cache gc, i.e. eviction caused by bad compaction, tablet meta removal(drop table/partion or rebalance) Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
be/src/io/cache/block_file_cache.cpp
Outdated
| _total_evict_size_metrics = std::make_shared<bvar::Adder<size_t>>( | ||
| _cache_base_path.c_str(), "file_cache_total_evict_size"); | ||
| _gc_evict_size_metrics = std::make_shared<bvar::Adder<size_t>>( | ||
| _cache_base_path.c_str(), "file_cache_gc_evict_size"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add a count
Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
TPC-H: Total hot run time: 34284 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
TPC-DS: Total hot run time: 195090 ms |
ClickBench: Total hot run time: 29.8 s |
|
run buildall |
TPC-H: Total hot run time: 33841 ms |
TPC-DS: Total hot run time: 192474 ms |
ClickBench: Total hot run time: 29.08 s |
|
run buildall |
TPC-H: Total hot run time: 33929 ms |
TPC-DS: Total hot run time: 193082 ms |
ClickBench: Total hot run time: 29.13 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
monitor file cache gc, i.e. eviction caused by bad compaction, tablet meta removal(drop table/partion or rebalance) Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
monitor file cache gc, i.e. eviction caused by bad compaction, tablet meta removal(drop table/partion or rebalance) Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
monitor file cache gc, i.e. eviction caused by bad compaction, tablet meta removal(drop table/partion or rebalance)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)