Skip to content

Conversation

@freemandealer
Copy link
Contributor

monitor file cache gc, i.e. eviction caused by bad compaction, tablet meta removal(drop table/partion or rebalance)

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

monitor file cache gc, i.e. eviction caused by bad compaction,
tablet meta removal(drop table/partion or rebalance)

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@Thearas
Copy link
Contributor

Thearas commented May 23, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@freemandealer
Copy link
Contributor Author

run buildall

_total_evict_size_metrics = std::make_shared<bvar::Adder<size_t>>(
_cache_base_path.c_str(), "file_cache_total_evict_size");
_gc_evict_size_metrics = std::make_shared<bvar::Adder<size_t>>(
_cache_base_path.c_str(), "file_cache_gc_evict_size");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also add a count

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@doris-robot
Copy link

TPC-H: Total hot run time: 34284 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit db6c635230a0adc037fc14c1db6f50c1fcafdf5f, data reload: false

------ Round 1 ----------------------------------
q1	27502	5022	5047	5022
q2	2093	299	212	212
q3	10465	1263	724	724
q4	10250	990	542	542
q5	7699	2456	2316	2316
q6	188	166	136	136
q7	911	750	629	629
q8	9343	1303	1103	1103
q9	6827	5137	5072	5072
q10	6896	2326	1913	1913
q11	495	293	284	284
q12	350	354	225	225
q13	17754	3702	3148	3148
q14	235	241	213	213
q15	543	499	482	482
q16	431	438	385	385
q17	620	861	369	369
q18	8034	7316	7322	7316
q19	1607	952	554	554
q20	351	340	230	230
q21	4144	3229	2396	2396
q22	1070	1040	1013	1013
Total cold run time: 117808 ms
Total hot run time: 34284 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5162	5055	5091	5055
q2	248	324	238	238
q3	2259	2672	2322	2322
q4	1378	1919	1470	1470
q5	4468	4398	4510	4398
q6	218	170	129	129
q7	2102	1931	1777	1777
q8	2631	2457	2464	2457
q9	7325	7060	7292	7060
q10	3080	3211	2786	2786
q11	587	519	491	491
q12	699	762	610	610
q13	3494	4020	3372	3372
q14	282	306	269	269
q15	528	470	494	470
q16	458	514	445	445
q17	1174	1623	1394	1394
q18	7871	7691	7533	7533
q19	839	817	859	817
q20	1944	2010	1868	1868
q21	5087	4610	4484	4484
q22	1126	1087	1063	1063
Total cold run time: 52960 ms
Total hot run time: 50508 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 66.67% (2/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.01% (14922/26643)
Line Coverage 44.83% (132862/296384)
Region Coverage 43.90% (66779/152112)
Branch Coverage 38.53% (34270/88942)

@doris-robot
Copy link

TPC-DS: Total hot run time: 195090 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit db6c635230a0adc037fc14c1db6f50c1fcafdf5f, data reload: false

query1	1453	1133	1091	1091
query2	6208	1918	1912	1912
query3	11192	4483	4743	4483
query4	24805	23445	22945	22945
query5	4309	664	474	474
query6	322	229	213	213
query7	3992	518	305	305
query8	307	260	248	248
query9	8493	2823	2809	2809
query10	495	341	292	292
query11	15369	15246	14844	14844
query12	179	114	113	113
query13	1580	585	441	441
query14	9594	6377	6322	6322
query15	238	189	164	164
query16	7599	654	499	499
query17	1399	756	622	622
query18	2028	418	321	321
query19	203	209	182	182
query20	137	126	132	126
query21	234	126	114	114
query22	4537	4770	4378	4378
query23	34676	34151	33765	33765
query24	8253	2452	2459	2452
query25	506	476	408	408
query26	736	283	158	158
query27	2871	537	365	365
query28	4712	2369	2259	2259
query29	630	579	449	449
query30	283	231	196	196
query31	930	898	777	777
query32	71	66	67	66
query33	595	410	358	358
query34	876	913	561	561
query35	842	844	770	770
query36	1033	1031	961	961
query37	125	101	90	90
query38	4341	4294	4287	4287
query39	1531	1497	1506	1497
query40	218	122	112	112
query41	66	58	57	57
query42	131	121	118	118
query43	548	547	523	523
query44	1419	905	922	905
query45	188	178	172	172
query46	891	1070	687	687
query47	1879	1881	1817	1817
query48	412	468	362	362
query49	715	534	469	469
query50	682	714	428	428
query51	4415	4311	4200	4200
query52	116	118	104	104
query53	237	260	191	191
query54	625	610	552	552
query55	94	90	96	90
query56	366	351	331	331
query57	1169	1195	1148	1148
query58	283	264	277	264
query59	2783	2886	2746	2746
query60	355	346	338	338
query61	128	122	125	122
query62	765	739	684	684
query63	245	211	210	210
query64	2925	1065	723	723
query65	4490	4429	4398	4398
query66	946	412	305	305
query67	16053	15538	15573	15538
query68	8269	948	563	563
query69	492	343	286	286
query70	1247	1110	1156	1110
query71	465	336	334	334
query72	5555	4867	4880	4867
query73	716	652	387	387
query74	9063	9340	8895	8895
query75	3990	3212	2723	2723
query76	3608	1206	764	764
query77	797	395	292	292
query78	10252	10248	9429	9429
query79	2328	849	613	613
query80	614	528	473	473
query81	509	262	219	219
query82	473	132	103	103
query83	253	260	240	240
query84	246	107	89	89
query85	796	362	328	328
query86	387	319	297	297
query87	4372	4445	4331	4331
query88	3555	2451	2450	2450
query89	415	322	290	290
query90	1843	215	219	215
query91	142	143	115	115
query92	76	62	58	58
query93	1891	964	613	613
query94	667	405	305	305
query95	394	314	306	306
query96	539	606	301	301
query97	2787	2772	2685	2685
query98	241	209	207	207
query99	1443	1446	1291	1291
Total cold run time: 279253 ms
Total hot run time: 195090 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.8 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit db6c635230a0adc037fc14c1db6f50c1fcafdf5f, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.11	0.10
query3	0.27	0.19	0.19
query4	1.59	0.20	0.11
query5	0.43	0.43	0.42
query6	1.17	0.67	0.65
query7	0.02	0.02	0.02
query8	0.04	0.03	0.04
query9	0.60	0.50	0.53
query10	0.57	0.60	0.57
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.62	0.60	0.60
query14	0.79	0.82	0.83
query15	0.88	0.86	0.85
query16	0.39	0.38	0.38
query17	1.06	1.08	1.07
query18	0.23	0.22	0.22
query19	1.94	1.86	1.85
query20	0.02	0.01	0.01
query21	15.40	0.94	0.56
query22	0.77	1.33	0.83
query23	14.76	1.45	0.65
query24	7.17	1.51	1.18
query25	0.47	0.17	0.08
query26	0.66	0.18	0.13
query27	0.06	0.06	0.04
query28	9.39	0.89	0.44
query29	12.62	4.05	3.32
query30	0.26	0.09	0.07
query31	2.81	0.62	0.39
query32	3.24	0.57	0.48
query33	3.05	3.17	3.11
query34	15.83	5.19	4.50
query35	4.57	4.56	4.57
query36	0.67	0.50	0.48
query37	0.08	0.06	0.06
query38	0.06	0.04	0.03
query39	0.03	0.03	0.03
query40	0.17	0.14	0.14
query41	0.08	0.02	0.02
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.32 s
Total hot run time: 29.8 s

@freemandealer
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33841 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 3a1b7b9c96a660366a976c61e21a28664bf5ada2, data reload: false

------ Round 1 ----------------------------------
q1	26386	5206	5045	5045
q2	1965	300	193	193
q3	10421	1215	677	677
q4	10228	1007	511	511
q5	7678	2364	2349	2349
q6	186	167	135	135
q7	896	737	612	612
q8	9316	1283	1080	1080
q9	6776	5048	5135	5048
q10	6871	2302	1915	1915
q11	483	299	270	270
q12	336	354	215	215
q13	17768	3690	3072	3072
q14	226	230	215	215
q15	572	492	476	476
q16	418	431	372	372
q17	601	861	360	360
q18	7566	7294	7213	7213
q19	1755	970	565	565
q20	331	342	224	224
q21	3729	2549	2319	2319
q22	1092	1027	975	975
Total cold run time: 115600 ms
Total hot run time: 33841 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5082	5043	5064	5043
q2	243	321	220	220
q3	2195	2669	2282	2282
q4	1352	1755	1384	1384
q5	4369	4382	4501	4382
q6	228	178	126	126
q7	2036	1919	1785	1785
q8	2568	2659	2580	2580
q9	7277	7164	6930	6930
q10	3048	3209	2804	2804
q11	576	517	497	497
q12	696	728	618	618
q13	3502	3865	3242	3242
q14	299	310	272	272
q15	536	489	490	489
q16	488	488	447	447
q17	1166	1529	1388	1388
q18	7871	7630	7467	7467
q19	814	807	839	807
q20	2044	2027	1946	1946
q21	4724	4456	4396	4396
q22	1109	1077	1023	1023
Total cold run time: 52223 ms
Total hot run time: 50128 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192474 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 3a1b7b9c96a660366a976c61e21a28664bf5ada2, data reload: false

query1	1416	1104	1075	1075
query2	6296	1822	1806	1806
query3	11065	4593	4536	4536
query4	52794	25973	22922	22922
query5	5080	490	442	442
query6	333	205	199	199
query7	4880	540	291	291
query8	286	224	206	206
query9	5332	2637	2622	2622
query10	443	329	275	275
query11	14987	15045	15025	15025
query12	157	109	108	108
query13	1019	550	405	405
query14	10208	6337	6377	6337
query15	209	193	178	178
query16	7066	622	477	477
query17	1091	724	572	572
query18	1564	412	305	305
query19	190	184	171	171
query20	126	160	124	124
query21	208	130	115	115
query22	4334	4456	4245	4245
query23	34502	33817	33693	33693
query24	6581	2411	2444	2411
query25	488	493	441	441
query26	693	276	158	158
query27	2266	518	347	347
query28	3043	2180	2148	2148
query29	607	584	451	451
query30	274	230	205	205
query31	856	875	773	773
query32	80	68	66	66
query33	458	395	322	322
query34	791	876	532	532
query35	807	852	786	786
query36	933	990	902	902
query37	119	109	81	81
query38	4236	4272	4213	4213
query39	1521	1465	1506	1465
query40	212	124	111	111
query41	65	58	74	58
query42	145	122	111	111
query43	507	520	477	477
query44	1344	825	832	825
query45	187	181	173	173
query46	850	1038	652	652
query47	1859	1864	1782	1782
query48	382	432	352	352
query49	659	476	409	409
query50	652	689	401	401
query51	4158	4388	4248	4248
query52	106	118	98	98
query53	236	255	185	185
query54	591	581	522	522
query55	92	91	89	89
query56	321	318	319	318
query57	1204	1199	1147	1147
query58	270	270	277	270
query59	2685	2741	2717	2717
query60	349	322	328	322
query61	130	120	130	120
query62	750	758	663	663
query63	240	193	189	189
query64	1480	1009	677	677
query65	4251	4186	4128	4128
query66	784	395	300	300
query67	16088	15748	15409	15409
query68	7874	900	519	519
query69	552	310	278	278
query70	1147	1080	1114	1080
query71	498	325	321	321
query72	6049	4761	4877	4761
query73	1328	681	351	351
query74	8964	9148	8752	8752
query75	3794	3236	2710	2710
query76	4192	1193	755	755
query77	604	370	286	286
query78	10098	10160	9408	9408
query79	2520	843	599	599
query80	657	527	451	451
query81	503	244	220	220
query82	436	133	100	100
query83	387	251	240	240
query84	294	102	87	87
query85	816	405	317	317
query86	398	305	293	293
query87	4380	4454	4268	4268
query88	3447	2269	2250	2250
query89	405	314	296	296
query90	1791	222	217	217
query91	146	137	108	108
query92	75	65	56	56
query93	2050	960	571	571
query94	677	413	299	299
query95	373	299	289	289
query96	499	585	283	283
query97	2703	2754	2628	2628
query98	230	208	200	200
query99	1447	1415	1298	1298
Total cold run time: 297270 ms
Total hot run time: 192474 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.08 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 3a1b7b9c96a660366a976c61e21a28664bf5ada2, data reload: false

query1	0.03	0.04	0.04
query2	0.12	0.11	0.11
query3	0.24	0.20	0.19
query4	1.59	0.19	0.18
query5	0.44	0.45	0.44
query6	1.47	0.66	0.67
query7	0.04	0.01	0.02
query8	0.05	0.04	0.04
query9	0.57	0.51	0.51
query10	0.56	0.59	0.56
query11	0.16	0.11	0.10
query12	0.15	0.11	0.12
query13	0.62	0.60	0.60
query14	0.79	0.80	0.79
query15	0.89	0.84	0.85
query16	0.39	0.37	0.39
query17	1.08	1.09	1.05
query18	0.23	0.22	0.21
query19	1.93	1.83	1.90
query20	0.01	0.01	0.01
query21	15.39	0.91	0.56
query22	0.77	1.20	0.66
query23	14.94	1.37	0.59
query24	7.08	1.40	0.84
query25	0.46	0.16	0.10
query26	0.68	0.15	0.13
query27	0.06	0.05	0.05
query28	9.42	0.93	0.45
query29	12.55	4.01	3.36
query30	0.26	0.09	0.06
query31	2.82	0.58	0.37
query32	3.25	0.56	0.47
query33	3.09	3.02	3.11
query34	15.69	5.16	4.45
query35	4.48	4.50	4.53
query36	0.67	0.50	0.49
query37	0.09	0.06	0.07
query38	0.05	0.04	0.04
query39	0.04	0.03	0.02
query40	0.16	0.14	0.13
query41	0.08	0.03	0.03
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.46 s
Total hot run time: 29.08 s

@freemandealer
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 33929 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 28ffec726e4cdd9bbc9f899c0d64308f33f7c357, data reload: false

------ Round 1 ----------------------------------
q1	26373	5073	5035	5035
q2	1950	275	178	178
q3	10299	1257	687	687
q4	10240	975	526	526
q5	7549	2392	2307	2307
q6	179	164	132	132
q7	924	729	624	624
q8	9313	1240	1128	1128
q9	6808	5105	5063	5063
q10	6828	2285	1937	1937
q11	488	299	282	282
q12	352	358	218	218
q13	17774	3650	3094	3094
q14	231	220	215	215
q15	568	497	478	478
q16	426	437	382	382
q17	612	889	394	394
q18	7554	7146	7126	7126
q19	1237	953	566	566
q20	350	353	248	248
q21	3689	3137	2375	2375
q22	1047	1037	934	934
Total cold run time: 114791 ms
Total hot run time: 33929 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5172	5020	5046	5020
q2	245	322	223	223
q3	2188	2694	2271	2271
q4	1340	1824	1370	1370
q5	4465	4408	4416	4408
q6	221	170	125	125
q7	2030	1954	1791	1791
q8	2598	2522	2610	2522
q9	7211	7111	6909	6909
q10	3015	3209	2786	2786
q11	579	522	504	504
q12	701	795	668	668
q13	3600	3953	3358	3358
q14	279	287	260	260
q15	533	503	471	471
q16	486	487	425	425
q17	1169	1588	1387	1387
q18	7753	7641	7430	7430
q19	842	833	983	833
q20	2010	2081	1867	1867
q21	4746	4394	4476	4394
q22	1087	1049	1029	1029
Total cold run time: 52270 ms
Total hot run time: 50051 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193082 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 28ffec726e4cdd9bbc9f899c0d64308f33f7c357, data reload: false

query1	1401	1087	1066	1066
query2	6316	1886	1832	1832
query3	11024	4426	4448	4426
query4	55871	26434	23265	23265
query5	5238	479	480	479
query6	382	200	209	200
query7	5045	520	286	286
query8	308	237	214	214
query9	6478	2629	2622	2622
query10	438	345	284	284
query11	15079	15021	14828	14828
query12	161	107	105	105
query13	1151	511	435	435
query14	10211	6480	6357	6357
query15	216	215	196	196
query16	7140	683	479	479
query17	1109	758	581	581
query18	1591	398	307	307
query19	198	206	166	166
query20	123	120	121	120
query21	207	124	109	109
query22	4586	4453	4447	4447
query23	34293	33728	33549	33549
query24	6555	2400	2438	2400
query25	477	480	401	401
query26	689	273	147	147
query27	2369	514	350	350
query28	3421	2178	2186	2178
query29	589	549	447	447
query30	282	233	186	186
query31	848	868	810	810
query32	72	65	62	62
query33	446	367	315	315
query34	769	878	534	534
query35	807	850	796	796
query36	920	1006	884	884
query37	107	104	82	82
query38	4245	4331	4334	4331
query39	1515	1485	1454	1454
query40	205	126	109	109
query41	61	57	54	54
query42	130	110	118	110
query43	492	505	503	503
query44	1323	842	831	831
query45	179	173	170	170
query46	847	1032	672	672
query47	1863	1875	1850	1850
query48	405	442	332	332
query49	667	493	415	415
query50	656	711	410	410
query51	4220	4270	4197	4197
query52	124	113	104	104
query53	224	257	184	184
query54	579	592	509	509
query55	85	82	82	82
query56	314	305	310	305
query57	1234	1240	1191	1191
query58	275	263	266	263
query59	2786	2856	2806	2806
query60	341	331	325	325
query61	126	125	126	125
query62	737	730	669	669
query63	226	187	188	187
query64	1556	1017	688	688
query65	4220	4168	4204	4168
query66	725	399	304	304
query67	16023	15677	15406	15406
query68	7707	835	522	522
query69	550	301	268	268
query70	1222	1102	1112	1102
query71	498	330	296	296
query72	5813	4771	4987	4771
query73	1263	640	354	354
query74	9193	9201	8910	8910
query75	3686	3201	2667	2667
query76	4251	1183	756	756
query77	605	368	344	344
query78	10206	10134	9324	9324
query79	2617	818	594	594
query80	650	495	443	443
query81	491	253	217	217
query82	468	127	104	104
query83	398	249	239	239
query84	286	106	89	89
query85	812	350	381	350
query86	424	311	274	274
query87	4431	4412	4281	4281
query88	3395	2290	2263	2263
query89	396	329	287	287
query90	1949	203	203	203
query91	139	145	110	110
query92	85	61	55	55
query93	1238	939	582	582
query94	696	398	309	309
query95	362	293	288	288
query96	495	573	282	282
query97	2802	2725	2636	2636
query98	233	209	198	198
query99	1444	1396	1265	1265
Total cold run time: 302105 ms
Total hot run time: 193082 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.13 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 28ffec726e4cdd9bbc9f899c0d64308f33f7c357, data reload: false

query1	0.04	0.04	0.03
query2	0.12	0.11	0.11
query3	0.24	0.19	0.20
query4	1.59	0.19	0.19
query5	0.46	0.45	0.44
query6	1.52	0.66	0.67
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.51	0.51
query10	0.57	0.58	0.56
query11	0.15	0.10	0.11
query12	0.15	0.11	0.11
query13	0.62	0.60	0.59
query14	0.79	0.82	0.81
query15	0.88	0.84	0.84
query16	0.39	0.38	0.39
query17	1.01	1.05	1.05
query18	0.23	0.21	0.20
query19	1.92	1.84	1.80
query20	0.01	0.01	0.01
query21	15.40	0.89	0.54
query22	0.77	1.16	0.99
query23	14.71	1.39	0.64
query24	6.58	1.36	0.61
query25	0.55	0.28	0.06
query26	0.46	0.16	0.14
query27	0.06	0.05	0.05
query28	9.30	0.90	0.43
query29	12.55	3.98	3.34
query30	0.26	0.09	0.07
query31	2.82	0.61	0.39
query32	3.24	0.56	0.46
query33	3.04	3.05	3.06
query34	15.80	5.09	4.47
query35	4.48	4.51	4.47
query36	0.66	0.50	0.49
query37	0.09	0.07	0.06
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 102.49 s
Total hot run time: 29.13 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.40% (15076/26732)
Line Coverage 45.15% (134681/298297)
Region Coverage 44.24% (67760/153154)
Branch Coverage 38.80% (34749/89558)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 66.67% (4/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.84% (21007/26310)
Line Coverage 72.80% (217045/298144)
Region Coverage 71.01% (127921/180154)
Branch Coverage 64.71% (66245/102376)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 12, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 36c63b9 into apache:master Jun 17, 2025
25 of 28 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 17, 2025
monitor file cache gc, i.e. eviction caused by bad compaction, tablet
meta removal(drop table/partion or rebalance)

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
dataroaring pushed a commit that referenced this pull request Jun 20, 2025
…ive gc #51197 (#51793)

Cherry-picked from #51197

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jun 20, 2025
monitor file cache gc, i.e. eviction caused by bad compaction, tablet
meta removal(drop table/partion or rebalance)

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
…ive gc #51197 (#52023)

Cherry-picked from #51197

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
Co-authored-by: zhengyu <zhangzhengyu@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. cloud dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants