Skip to content

[fix](mow) remove enable_delete_bitmap_merge_on_compaction #51479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
zhannngchen merged 1 commit into from
Jun 6, 2025
Merged

[fix](mow) remove enable_delete_bitmap_merge_on_compaction #51479

zhannngchen merged 1 commit into from
Jun 6, 2025

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Jun 4, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

remove code of #40204 and #41636

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 4, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi mymeiyi force-pushed the remove-mow-code branch from a4d1696 to 2c4d868 Compare June 4, 2025 07:43
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Jun 4, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 4, 2025

TPC-H: Total hot run time: 33855 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 2c4d8685f48e7fc897d6aafd2b6af02463893c00, data reload: false

------ Round 1 ----------------------------------
q1	26361	5143	4996	4996
q2	1985	285	173	173
q3	10386	1218	713	713
q4	10243	1009	534	534
q5	7566	2359	2540	2359
q6	185	162	133	133
q7	902	737	632	632
q8	9311	1276	1062	1062
q9	6662	5065	5112	5065
q10	6865	2320	1897	1897
q11	492	295	269	269
q12	355	351	213	213
q13	17773	3739	3094	3094
q14	218	228	212	212
q15	576	506	478	478
q16	450	427	374	374
q17	584	866	380	380
q18	7652	7098	7156	7098
q19	2017	992	577	577
q20	327	343	215	215
q21	3969	3165	2406	2406
q22	1015	1011	975	975
Total cold run time: 115894 ms
Total hot run time: 33855 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5217	5076	5133	5076
q2	232	325	225	225
q3	2200	2633	2263	2263
q4	1333	1796	1327	1327
q5	4477	4453	4430	4430
q6	223	165	129	129
q7	2002	1944	1746	1746
q8	2581	2548	2504	2504
q9	7164	7150	7084	7084
q10	3038	3161	2749	2749
q11	583	512	489	489
q12	693	776	615	615
q13	3501	3952	3324	3324
q14	313	317	265	265
q15	508	468	474	468
q16	444	469	449	449
q17	1195	1512	1396	1396
q18	7820	7666	7468	7468
q19	806	781	846	781
q20	1962	1996	1845	1845
q21	4938	4444	4397	4397
q22	1158	1064	1023	1023
Total cold run time: 52388 ms
Total hot run time: 50053 ms

@doris-robot
Copy link

doris-robot commented Jun 4, 2025

TPC-DS: Total hot run time: 193254 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 2c4d8685f48e7fc897d6aafd2b6af02463893c00, data reload: false

query1	1406	1105	1061	1061
query2	6389	1868	1846	1846
query3	10987	4503	4499	4499
query4	55325	25335	23102	23102
query5	5204	543	471	471
query6	353	216	202	202
query7	4883	509	302	302
query8	309	245	219	219
query9	5780	2635	2664	2635
query10	453	316	275	275
query11	15559	15048	14849	14849
query12	163	110	108	108
query13	1044	545	428	428
query14	10153	6519	6395	6395
query15	216	207	194	194
query16	7147	658	525	525
query17	1079	791	574	574
query18	1538	406	316	316
query19	199	200	173	173
query20	137	125	150	125
query21	205	123	106	106
query22	4365	4453	4392	4392
query23	34240	33673	33477	33477
query24	6552	2427	2491	2427
query25	456	483	410	410
query26	666	280	152	152
query27	2221	537	364	364
query28	2958	2192	2170	2170
query29	576	562	455	455
query30	275	220	195	195
query31	874	866	762	762
query32	72	61	62	61
query33	459	376	335	335
query34	800	865	539	539
query35	806	836	754	754
query36	961	1025	902	902
query37	113	97	77	77
query38	4309	4329	4235	4235
query39	1497	1485	1482	1482
query40	213	128	114	114
query41	64	58	60	58
query42	142	110	111	110
query43	497	508	490	490
query44	1392	901	869	869
query45	184	175	172	172
query46	855	1035	638	638
query47	1827	1840	1779	1779
query48	404	442	331	331
query49	658	499	404	404
query50	690	694	409	409
query51	4279	4301	4326	4301
query52	119	121	101	101
query53	245	262	191	191
query54	578	597	514	514
query55	91	83	94	83
query56	311	318	303	303
query57	1189	1184	1133	1133
query58	273	283	257	257
query59	2700	2740	2747	2740
query60	343	352	320	320
query61	127	125	143	125
query62	722	756	696	696
query63	234	203	206	203
query64	1475	1030	760	760
query65	4221	4174	4135	4135
query66	707	403	306	306
query67	15848	15613	15369	15369
query68	7130	902	543	543
query69	550	318	267	267
query70	1205	1081	1132	1081
query71	515	340	307	307
query72	6017	4838	4925	4838
query73	1476	734	360	360
query74	8973	9094	9018	9018
query75	3887	3192	2709	2709
query76	4245	1213	788	788
query77	616	396	302	302
query78	10208	10301	9339	9339
query79	2345	850	592	592
query80	652	562	451	451
query81	499	264	275	264
query82	480	126	95	95
query83	261	257	235	235
query84	303	114	91	91
query85	864	376	308	308
query86	383	305	292	292
query87	4453	4380	4290	4290
query88	3646	2306	2300	2300
query89	414	316	291	291
query90	1784	215	211	211
query91	141	138	111	111
query92	72	62	60	60
query93	2104	983	594	594
query94	671	408	292	292
query95	385	294	289	289
query96	514	567	280	280
query97	2760	2782	2658	2658
query98	236	215	214	214
query99	1341	1406	1279	1279
Total cold run time: 300247 ms
Total hot run time: 193254 ms

@doris-robot
Copy link

doris-robot commented Jun 4, 2025

ClickBench: Total hot run time: 29.49 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 2c4d8685f48e7fc897d6aafd2b6af02463893c00, data reload: false

query1	0.04	0.04	0.03
query2	0.13	0.10	0.11
query3	0.24	0.19	0.20
query4	1.59	0.20	0.20
query5	0.45	0.44	0.46
query6	1.19	0.68	0.66
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.60	0.51	0.52
query10	0.57	0.58	0.56
query11	0.15	0.12	0.10
query12	0.15	0.11	0.12
query13	0.62	0.61	0.60
query14	0.79	0.82	0.82
query15	0.88	0.86	0.86
query16	0.40	0.38	0.39
query17	1.06	1.06	1.05
query18	0.22	0.22	0.22
query19	1.96	1.85	1.83
query20	0.01	0.01	0.01
query21	15.40	0.91	0.54
query22	0.75	1.39	0.87
query23	14.71	1.33	0.63
query24	7.10	0.81	1.26
query25	0.46	0.17	0.14
query26	0.60	0.16	0.15
query27	0.06	0.05	0.05
query28	9.23	0.93	0.44
query29	12.58	3.92	3.31
query30	0.25	0.09	0.08
query31	2.82	0.61	0.38
query32	3.23	0.57	0.48
query33	3.09	3.09	3.07
query34	15.76	5.17	4.50
query35	4.53	4.52	4.52
query36	0.67	0.50	0.49
query37	0.09	0.07	0.07
query38	0.05	0.04	0.04
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 102.82 s
Total hot run time: 29.49 s

zhannngchen
zhannngchen approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jun 5, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhannngchen
Copy link
Contributor

zhannngchen commented Jun 6, 2025

run beut

@zhannngchen zhannngchen merged commit d320967 into apache:master Jun 6, 2025
24 of 26 checks passed
@mymeiyi mymeiyi mentioned this pull request Jun 12, 2025
Merged
16 tasks
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Jun 24, 2025
@mymeiyi
[fix](mow) remove enable_delete_bitmap_merge_on_compaction (apache#51479
0dc6de4 
)

Problem Summary:

remove code of apache#40204 and
apache#41636
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Jun 24, 2025
@mymeiyi
[fix](mow) remove enable_delete_bitmap_merge_on_compaction (apache#51479
076035e 
)

Problem Summary:

remove code of apache#40204 and
apache#41636
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Jun 25, 2025
@mymeiyi
[fix](mow) remove enable_delete_bitmap_merge_on_compaction (apache#51479
57ed914 
)

Problem Summary:

remove code of apache#40204 and
apache#41636
@mymeiyi mymeiyi mentioned this pull request Jun 25, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jun 26, 2025
@mymeiyi
branch-3.1: [fix](mow) remove enable_delete_bitmap_merge_on_compaction …
38838ac 
…#51479 (#52262)

Cherry pick from #51479
mymeiyi added a commit to mymeiyi/doris that referenced this pull request Sep 8, 2025
@mymeiyi
[fix](mow) remove enable_delete_bitmap_merge_on_compaction (apache#51479
cfe6dae 
)

Problem Summary:

remove code of apache#40204 and
apache#41636
@mymeiyi mymeiyi mentioned this pull request Sep 8, 2025
Merged
dataroaring pushed a commit that referenced this pull request Sep 8, 2025
@mymeiyi
branch-3.0: [fix](mow) remove enable_delete_bitmap_merge_on_compaction (
8fb70bc 
#51479) (#55758)

pick #51479
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhannngchen zhannngchen zhannngchen approved these changes

@dataroaring dataroaring dataroaring approved these changes

@gavinchou gavinchou Awaiting requested review from gavinchou gavinchou is a code owner

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.9-merged dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mymeiyi @hello-stephen @doris-robot @zhannngchen @dataroaring @morrySnow