Skip to content

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Sep 8, 2025

pick #51479

@mymeiyi mymeiyi requested a review from dataroaring as a code owner September 8, 2025 03:35
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 8, 2025

run buildall

@mymeiyi mymeiyi changed the title [fix](mow) remove enable_delete_bitmap_merge_on_compaction (#51479) branch-3.0: [fix](mow) remove enable_delete_bitmap_merge_on_compaction (#51479) Sep 8, 2025
dataroaring
dataroaring previously approved these changes Sep 8, 2025
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot removed the approved Indicates a PR has been approved by one committer. label Sep 8, 2025
@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 40203 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8b434100fa890454d6698f34a88588f98783c2df, data reload: false

------ Round 1 ----------------------------------
q1	17704	6837	6782	6782
q2	2042	198	174	174
q3	10627	1149	1202	1149
q4	10406	734	747	734
q5	7740	2847	2848	2847
q6	211	130	130	130
q7	956	622	593	593
q8	9354	1922	2036	1922
q9	6696	6456	6433	6433
q10	7045	2240	2309	2240
q11	464	261	253	253
q12	393	221	211	211
q13	17794	3012	2987	2987
q14	240	205	205	205
q15	534	474	468	468
q16	477	374	377	374
q17	994	591	556	556
q18	7591	6635	6849	6635
q19	1464	1081	1049	1049
q20	483	205	209	205
q21	4172	3249	3259	3249
q22	1128	1007	1010	1007
Total cold run time: 108515 ms
Total hot run time: 40203 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6667	6599	6665	6599
q2	339	234	235	234
q3	3021	2973	2950	2950
q4	2108	1882	1842	1842
q5	5724	5788	5730	5730
q6	213	125	130	125
q7	2182	1797	1790	1790
q8	3414	3632	3427	3427
q9	8913	8954	8877	8877
q10	3588	3579	3579	3579
q11	589	493	512	493
q12	824	609	615	609
q13	7532	3149	3174	3149
q14	300	275	272	272
q15	520	469	468	468
q16	504	459	440	440
q17	1868	1643	1586	1586
q18	8302	7735	7744	7735
q19	1643	1558	1517	1517
q20	2067	1893	1868	1868
q21	5289	5219	5162	5162
q22	1144	1059	1066	1059
Total cold run time: 66751 ms
Total hot run time: 59511 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192720 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8b434100fa890454d6698f34a88588f98783c2df, data reload: false

query1	944	405	423	405
query2	6252	1889	1840	1840
query3	8692	201	202	201
query4	33096	23878	23713	23713
query5	3635	472	471	471
query6	310	200	187	187
query7	4214	312	310	310
query8	300	233	233	233
query9	9461	2584	2601	2584
query10	471	269	258	258
query11	17976	15593	15291	15291
query12	156	102	101	101
query13	1547	442	424	424
query14	10142	6678	6741	6678
query15	248	172	179	172
query16	8008	551	494	494
query17	1580	611	619	611
query18	2166	332	329	329
query19	225	173	160	160
query20	121	126	126	126
query21	213	111	108	108
query22	4707	4457	4362	4362
query23	35048	34488	34238	34238
query24	11697	2961	2917	2917
query25	709	446	428	428
query26	1758	176	173	173
query27	2814	360	364	360
query28	7769	2193	2203	2193
query29	1112	462	462	462
query30	276	163	162	162
query31	1108	853	839	839
query32	99	57	58	57
query33	763	311	357	311
query34	941	518	543	518
query35	847	763	741	741
query36	1162	970	957	957
query37	183	70	72	70
query38	4083	3970	3945	3945
query39	1519	1539	1467	1467
query40	253	100	101	100
query41	53	52	48	48
query42	123	106	101	101
query43	516	474	504	474
query44	1236	821	804	804
query45	186	171	172	171
query46	1163	755	715	715
query47	2042	1908	1925	1908
query48	485	396	382	382
query49	1033	401	402	401
query50	826	435	448	435
query51	7363	7316	7182	7182
query52	104	89	105	89
query53	269	190	189	189
query54	1329	480	475	475
query55	83	78	77	77
query56	263	254	236	236
query57	1338	1222	1223	1222
query58	238	211	214	211
query59	3298	3046	3041	3041
query60	307	267	256	256
query61	114	112	119	112
query62	846	716	728	716
query63	238	204	196	196
query64	4963	667	649	649
query65	3395	3293	3296	3293
query66	1359	358	312	312
query67	16596	15657	15472	15472
query68	5608	565	578	565
query69	445	286	261	261
query70	1122	1130	1167	1130
query71	344	255	261	255
query72	6209	3998	3999	3998
query73	744	353	350	350
query74	10818	9284	8956	8956
query75	3376	2649	2688	2649
query76	3380	1170	1027	1027
query77	384	271	287	271
query78	10549	9596	9678	9596
query79	2532	610	628	610
query80	1105	433	436	433
query81	544	220	224	220
query82	609	88	87	87
query83	230	146	142	142
query84	241	79	83	79
query85	1402	309	299	299
query86	456	293	276	276
query87	4423	4221	4372	4221
query88	3894	2402	2368	2368
query89	410	296	298	296
query90	2075	190	190	190
query91	181	151	153	151
query92	61	51	53	51
query93	2359	574	570	570
query94	969	306	305	305
query95	358	274	264	264
query96	608	286	291	286
query97	3281	3151	3150	3150
query98	223	199	198	198
query99	1480	1305	1303	1303
Total cold run time: 306791 ms
Total hot run time: 192720 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 28.92 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8b434100fa890454d6698f34a88588f98783c2df, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.04
query3	0.23	0.06	0.06
query4	1.63	0.11	0.11
query5	0.50	0.49	0.51
query6	1.13	0.73	0.73
query7	0.02	0.01	0.02
query8	0.05	0.03	0.03
query9	0.56	0.50	0.50
query10	0.56	0.54	0.54
query11	0.13	0.10	0.10
query12	0.13	0.10	0.11
query13	0.63	0.60	0.61
query14	0.78	0.78	0.83
query15	0.83	0.82	0.83
query16	0.39	0.38	0.38
query17	1.07	1.08	0.98
query18	0.24	0.23	0.23
query19	1.96	1.83	1.85
query20	0.01	0.01	0.01
query21	15.39	0.56	0.56
query22	2.75	2.17	1.42
query23	16.91	0.93	0.90
query24	3.15	1.65	0.13
query25	0.18	0.12	0.04
query26	0.38	0.13	0.13
query27	0.05	0.06	0.03
query28	10.92	0.49	0.47
query29	12.59	3.20	3.22
query30	0.25	0.07	0.05
query31	2.87	0.39	0.39
query32	3.22	0.46	0.45
query33	3.01	3.07	3.03
query34	17.17	4.48	4.45
query35	4.56	4.55	4.66
query36	0.67	0.47	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.02	0.03
query40	0.16	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.49 s
Total hot run time: 28.92 s

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 8, 2025

run beut

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 42.09% (11243/26712)
Line Coverage 32.62% (96266/295071)
Region Coverage 30.55% (55262/180884)
Branch Coverage 26.87% (27351/101776)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.30% (19733/26205)
Line Coverage 68.59% (201496/293756)
Region Coverage 66.67% (120664/180988)
Branch Coverage 60.05% (61307/102100)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 8fb70bc into apache:branch-3.0 Sep 8, 2025
24 of 26 checks passed
@mymeiyi mymeiyi deleted the branch-3.0-pick-51479 branch September 10, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants