[Enhancement](nereids, function, test) add the cot math function #51574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
ChenMiaoi
changed the title
Contributor
Author
|
run buildall |
zclllyybb
reviewed
Jun 27, 2025
| constexpr double epsilon = 1e-10; | ||
| double remainder = std::fmod(std::abs(x), M_PI); | ||
|
|
||
| return std::abs(x) < epsilon || std::abs(remainder) < epsilon || |
Contributor
There was a problem hiding this comment.
just std::abs(remainder) < epsilon maybe is enough? this check seems could cover other two conditions. could you confirm this?
zclllyybb
reviewed
Jun 27, 2025
Contributor
There was a problem hiding this comment.
also add some test with data in table
zclllyybb
reviewed
Jun 27, 2025
| double value = first.getValue(); | ||
| double remainder = Math.abs(value) % Math.PI; | ||
|
|
||
| if (Math.abs(value) < epsilon || Math.abs(remainder) < epsilon || Math.abs(remainder - Math.PI) < epsilon) { |
zclllyybb
reviewed
Jun 27, 2025
| InputTypeSet input_types = {PrimitiveType::TYPE_DOUBLE}; | ||
|
|
||
| DataSet data_set = {{{-1.0}, -0.6420926159343306}, {{0.5}, 1.830487721712452}, | ||
| {{1.0}, 0.6420926159343306}, {{0.0}, Null()}, |
Contributor
There was a problem hiding this comment.
add a testcase return Null which input is not zero
TPC-H: Total hot run time: 34679 ms |
TPC-DS: Total hot run time: 189507 ms |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
|
finished by another pr:#52872 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Support the cot math function.
Related PR: #48203
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)