Skip to content

[Feature](function) support function cot/sec/cosec #52872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 3 commits into from
Jul 8, 2025
Merged

[Feature](function) support function cot/sec/cosec #52872

BiteTheDDDDt merged 3 commits into from
Jul 8, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Jul 7, 2025 •
edited
Loading

What problem does this PR solve?

support function cot/sec/cosec

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 7, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jul 7, 2025

run buildall

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jul 7, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 7, 2025

FE UT Coverage Report

Increment line coverage 7.69% (3/39) 🎉
Increment coverage report
Complete coverage report

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Jul 7, 2025

run buildall

HappenLee
HappenLee approved these changes Jul 8, 2025
View reviewed changes
Copy link
Contributor

@HappenLee HappenLee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

PR approved by anyone and no changes requested.

@BiteTheDDDDt BiteTheDDDDt merged commit d7ae503 into apache:master Jul 8, 2025
27 of 30 checks passed
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jul 15, 2025
@BiteTheDDDDt
[Feature](function) support function cot/sec/cosec (apache#52872)
6ac76cb 
support function cot/sec/cosec
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jul 15, 2025
Merged
BiteTheDDDDt added a commit to BiteTheDDDDt/incubator-doris that referenced this pull request Jul 15, 2025
@BiteTheDDDDt
[Feature](function) support function cot/sec/cosec (apache#52872)
2a43a0d 
support function cot/sec/cosec
@BiteTheDDDDt BiteTheDDDDt mentioned this pull request Jul 15, 2025
Merged
morrySnow pushed a commit that referenced this pull request Jul 16, 2025
@BiteTheDDDDt
branch-3.1: [Feature](function) support function cot/sec/cosec #52872 (…
7e0800a 
…#53273)

pick from #52872
dataroaring pushed a commit that referenced this pull request Jul 18, 2025
@BiteTheDDDDt
[Feature](function) support function cot/sec/cosec (#52872) (#53274)
f4f6e37 
pick from #52872
@dataroaring dataroaring added usercase Important user case type label and removed dev/3.0.x-conflict labels Jul 18, 2025
zclllyybb
zclllyybb reviewed Jul 18, 2025
View reviewed changes
be/src/vec/functions/math.cpp
Copy link
Contributor

@zclllyybb zclllyybb Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please rename cosec to csc.

This was referenced Jul 18, 2025
Open
Closed
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zclllyybb zclllyybb zclllyybb left review comments

@HappenLee HappenLee HappenLee approved these changes

@zhangstar333 zhangstar333 zhangstar333 approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed usercase Important user case type label

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BiteTheDDDDt @hello-stephen @HappenLee @zclllyybb @zhangstar333 @dataroaring @morrySnow