Skip to content

Conversation

@liutang123
Copy link
Contributor

@liutang123 liutang123 commented Dec 29, 2020

Proposed changes

For #5169

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix Add publish timout param when exec insert #5169), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • [] I have added tests that prove my fix is effective or that my feature works
  • Manual test passed
  • If this change need a document change, I have updated the document
  • [] Any dependent changes have been merged

Further comments

If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...

@morningman morningman self-assigned this Jan 3, 2021
@morningman morningman added area/config Issues or PRs related to configuration area/load Issues or PRs related to all kinds of load labels Jan 3, 2021
15: optional i32 stmtIdx // the idx of the sql in multi statements
16: optional PaloInternalService.TQueryOptions query_options
17: optional Types.TUniqueId query_id // when this is a query, we translate this query id to master
18: optional i64 insert_visible_timeout_ms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should it be set in MasterOpExecutor?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also can add a hint insert /*+ SET_VAR(insert_visible_timeout_ms = 20000)*/ xxx like select hint select /*+ SET_VAR */ and transform this sql with hint to master.
Any other better place?

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jan 9, 2021
@morningman morningman merged commit 05631cf into apache:master Jan 10, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request Jan 26, 2021
Add new session variable to control the timeout of publish task of insert operation.

Change-Id: I33c3e290900397fcad7ba01845b365500adfebd6
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. area/config Issues or PRs related to configuration area/load Issues or PRs related to all kinds of load

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add publish timout param when exec insert

3 participants