-
Notifications
You must be signed in to change notification settings - Fork 3.7k
For #5169 Add publish timout param when exec insert #5170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fe/fe-core/src/main/java/org/apache/doris/qe/SessionVariable.java
Outdated
Show resolved
Hide resolved
| 15: optional i32 stmtIdx // the idx of the sql in multi statements | ||
| 16: optional PaloInternalService.TQueryOptions query_options | ||
| 17: optional Types.TUniqueId query_id // when this is a query, we translate this query id to master | ||
| 18: optional i64 insert_visible_timeout_ms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should it be set in MasterOpExecutor?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also can add a hint insert /*+ SET_VAR(insert_visible_timeout_ms = 20000)*/ xxx like select hint select /*+ SET_VAR */ and transform this sql with hint to master.
Any other better place?
morningman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Add new session variable to control the timeout of publish task of insert operation. Change-Id: I33c3e290900397fcad7ba01845b365500adfebd6
Proposed changes
For #5169
Types of changes
What types of changes does your code introduce to Doris?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...