Skip to content

[fix](http) support show backend config when BE enable http auth #51887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morningman merged 1 commit into from
Jun 18, 2025
Merged

[fix](http) support show backend config when BE enable http auth #51887

morningman merged 1 commit into from
Jun 18, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jun 18, 2025 •
edited
Loading

What problem does this PR solve?

This PR #36525 introduced the show backend config statement to get BE config
via http api. But it only support http api without auth.
If BE enable auth by setting enable_all_http_auth=true, this command will fail.

This PR fix it by adding Auth-Token in http request, so to support both auth/no-auth http api.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@morningman
Copy link
Contributor Author

morningman commented Jun 18, 2025

run buildall

@Thearas
Copy link
Contributor

Thearas commented Jun 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Jun 18, 2025

TPC-H: Total hot run time: 34613 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit eaa78d5f0b7a334631cd8013db579b71445d49f7, data reload: false

------ Round 1 ----------------------------------
q1	17577	5196	5005	5005
q2	1949	271	170	170
q3	10338	1243	764	764
q4	10249	1051	552	552
q5	8018	2345	2296	2296
q6	181	160	133	133
q7	899	742	622	622
q8	9332	1342	1136	1136
q9	6694	4995	5027	4995
q10	6898	2370	1998	1998
q11	472	298	276	276
q12	345	374	222	222
q13	17767	3680	3061	3061
q14	229	226	215	215
q15	564	480	481	480
q16	433	419	395	395
q17	589	844	375	375
q18	7661	7198	7148	7148
q19	1472	973	568	568
q20	327	338	228	228
q21	3805	3173	2993	2993
q22	1057	1029	981	981
Total cold run time: 106856 ms
Total hot run time: 34613 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5093	5091	5091	5091
q2	237	324	232	232
q3	2182	2669	2302	2302
q4	1330	1813	1367	1367
q5	4248	4113	4357	4113
q6	230	177	133	133
q7	2014	1984	1820	1820
q8	2588	2606	2544	2544
q9	7156	7074	7254	7074
q10	3109	3178	2880	2880
q11	560	505	481	481
q12	705	763	633	633
q13	3457	3891	3249	3249
q14	309	310	274	274
q15	521	482	465	465
q16	429	514	435	435
q17	1147	1573	1318	1318
q18	7729	7547	7438	7438
q19	809	853	884	853
q20	1964	2048	1909	1909
q21	5049	4314	4311	4311
q22	1099	1046	982	982
Total cold run time: 51965 ms
Total hot run time: 49904 ms

@doris-robot
Copy link

doris-robot commented Jun 18, 2025

TPC-DS: Total hot run time: 192132 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit eaa78d5f0b7a334631cd8013db579b71445d49f7, data reload: false

query1	1390	1042	997	997
query2	6349	1909	1891	1891
query3	11009	4594	4264	4264
query4	55741	25244	22898	22898
query5	4969	522	467	467
query6	341	208	192	192
query7	4888	529	294	294
query8	323	235	227	227
query9	5631	2659	2685	2659
query10	440	322	275	275
query11	14992	15106	14897	14897
query12	152	114	111	111
query13	1056	518	416	416
query14	10157	6395	6186	6186
query15	208	201	193	193
query16	7189	661	477	477
query17	1160	779	601	601
query18	1718	432	350	350
query19	211	198	180	180
query20	135	132	119	119
query21	214	127	150	127
query22	4566	4522	4446	4446
query23	34222	33395	33505	33395
query24	6479	2502	2473	2473
query25	471	473	425	425
query26	697	267	159	159
query27	2378	527	349	349
query28	3914	2193	2198	2193
query29	577	571	447	447
query30	275	218	191	191
query31	864	835	795	795
query32	72	65	62	62
query33	436	376	307	307
query34	795	888	514	514
query35	808	860	750	750
query36	959	988	894	894
query37	113	106	77	77
query38	4238	4313	4261	4261
query39	1530	1472	1431	1431
query40	219	122	108	108
query41	60	58	55	55
query42	129	117	113	113
query43	524	506	493	493
query44	1424	856	833	833
query45	189	177	168	168
query46	845	1037	665	665
query47	1845	1865	1805	1805
query48	382	442	328	328
query49	665	505	404	404
query50	655	694	427	427
query51	4250	4294	4155	4155
query52	108	125	105	105
query53	224	258	182	182
query54	572	574	527	527
query55	85	83	83	83
query56	309	307	309	307
query57	1209	1237	1167	1167
query58	278	272	259	259
query59	2828	2892	2724	2724
query60	338	336	328	328
query61	131	120	126	120
query62	761	738	689	689
query63	229	188	187	187
query64	1815	1036	675	675
query65	4297	4165	4155	4155
query66	694	409	307	307
query67	16030	15452	15324	15324
query68	7835	905	534	534
query69	550	307	271	271
query70	1228	1128	1148	1128
query71	501	331	297	297
query72	5827	4735	4734	4734
query73	1449	612	358	358
query74	9067	8750	8953	8750
query75	3800	3194	2776	2776
query76	4142	1183	751	751
query77	631	369	298	298
query78	10096	10056	9406	9406
query79	3291	828	567	567
query80	713	520	449	449
query81	492	264	218	218
query82	458	122	93	93
query83	369	241	245	241
query84	299	102	89	89
query85	793	359	309	309
query86	354	310	277	277
query87	4430	4467	4375	4375
query88	3227	2294	2288	2288
query89	394	317	291	291
query90	1978	204	209	204
query91	139	145	115	115
query92	74	63	58	58
query93	1550	924	584	584
query94	693	411	298	298
query95	368	292	284	284
query96	488	570	278	278
query97	2713	2798	2663	2663
query98	226	201	198	198
query99	1445	1382	1267	1267
Total cold run time: 302382 ms
Total hot run time: 192132 ms

@doris-robot
Copy link

doris-robot commented Jun 18, 2025

ClickBench: Total hot run time: 29.11 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit eaa78d5f0b7a334631cd8013db579b71445d49f7, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.07
query4	1.64	0.10	0.11
query5	0.44	0.41	0.42
query6	1.18	0.66	0.67
query7	0.02	0.02	0.01
query8	0.04	0.03	0.04
query9	0.57	0.52	0.51
query10	0.58	0.58	0.57
query11	0.15	0.11	0.12
query12	0.14	0.12	0.11
query13	0.62	0.61	0.61
query14	0.80	0.83	0.80
query15	0.87	0.85	0.87
query16	0.39	0.38	0.39
query17	1.08	1.02	1.06
query18	0.22	0.21	0.21
query19	1.97	1.89	1.82
query20	0.02	0.01	0.01
query21	15.40	0.91	0.55
query22	0.73	1.21	0.75
query23	14.82	1.37	0.61
query24	6.88	0.74	0.42
query25	0.47	0.29	0.08
query26	0.60	0.16	0.14
query27	0.05	0.05	0.05
query28	9.56	0.92	0.44
query29	12.54	4.02	3.30
query30	0.25	0.09	0.06
query31	2.84	0.61	0.40
query32	3.23	0.57	0.47
query33	3.08	3.14	3.14
query34	16.03	5.35	4.79
query35	4.80	4.80	4.76
query36	0.68	0.51	0.50
query37	0.09	0.07	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.03
query40	0.17	0.15	0.14
query41	0.08	0.02	0.03
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.54 s
Total hot run time: 29.11 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 18, 2025

FE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉
Increment coverage report
Complete coverage report

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 18, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 18, 2025

PR approved by anyone and no changes requested.

@morningman morningman merged commit 1b34b1b into apache:master Jun 18, 2025
31 of 33 checks passed
morningman added a commit to morningman/doris that referenced this pull request Jun 24, 2025
@morningman
[fix](http) support show backend config when BE enable http auth (apa…
cd7a3df 
…che#51887)

This PR apache#36525 introduced the `show backend config` statement to get BE
config
via http api. But it only support http api without auth.
If BE enable auth by setting `enable_all_http_auth=true`, this command
will fail.

This PR fix it by adding `Auth-Token` in http request, so to support
both auth/no-auth http api.
@morningman morningman mentioned this pull request Jun 24, 2025
Merged
dataroaring pushed a commit that referenced this pull request Jun 24, 2025
@morningman
[fix](http) support show backend config when BE enable http auth (#51887
0270414 
) (#52202)

bp #51887
morningman added a commit to morningman/doris that referenced this pull request Jun 29, 2025
@morningman
[fix](http) support show backend config when BE enable http auth (apa…
1559de1 
…che#51887)

### What problem does this PR solve?

This PR apache#36525 introduced the `show backend config` statement to get BE
config
via http api. But it only support http api without auth.
If BE enable auth by setting `enable_all_http_auth=true`, this command
will fail.

This PR fix it by adding `Auth-Token` in http request, so to support
both auth/no-auth http api.
@morningman morningman mentioned this pull request Jun 29, 2025
Merged
morningman added a commit to morningman/doris that referenced this pull request Jun 29, 2025
@morningman
[fix](http) support show backend config when BE enable http auth (apa…
dc1d857 
…che#51887)

This PR apache#36525 introduced the `show backend config` statement to get BE
config
via http api. But it only support http api without auth.
If BE enable auth by setting `enable_all_http_auth=true`, this command
will fail.

This PR fix it by adding `Auth-Token` in http request, so to support
both auth/no-auth http api.
morrySnow pushed a commit that referenced this pull request Jun 30, 2025
@morningman
branch-3.1: [fix](http) support show backend config when BE enable ht…
ee761ff 
…tp auth #51887 (#52471)

bp #51887
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Aug 8, 2025
@morningman @gavinchou
[fix](http) support show backend config when BE enable http auth (apa…
11dede6 
…che#51887)

This PR apache#36525 introduced the `show backend config` statement to get BE
config
via http api. But it only support http api without auth.
If BE enable auth by setting `enable_all_http_auth=true`, this command
will fail.

This PR fix it by adding `Auth-Token` in http request, so to support
both auth/no-auth http api.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@CalvinKirs CalvinKirs CalvinKirs approved these changes

@zy-kkk zy-kkk zy-kkk approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged p0_test reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@morningman @Thearas @doris-robot @hello-stephen @CalvinKirs @zy-kkk @dataroaring @morrySnow