Skip to content

[fix](http) support show backend config when BE enable http auth (#51887) #52202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 24, 2025
Merged

[fix](http) support show backend config when BE enable http auth (#51887) #52202

dataroaring merged 1 commit into from
Jun 24, 2025

Conversation

@morningman
Copy link
Contributor

@morningman morningman commented Jun 24, 2025

bp #51887

@morningman
[fix](http) support show backend config when BE enable http auth (apa…
cd7a3df 
…che#51887)

This PR apache#36525 introduced the `show backend config` statement to get BE
config
via http api. But it only support http api without auth.
If BE enable auth by setting `enable_all_http_auth=true`, this command
will fail.

This PR fix it by adding `Auth-Token` in http request, so to support
both auth/no-auth http api.
@morningman morningman requested a review from dataroaring as a code owner June 24, 2025 07:39
@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 24, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morningman
Copy link
Contributor Author

morningman commented Jun 24, 2025

run buildall

dataroaring
dataroaring approved these changes Jun 24, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 0270414 into apache:branch-3.0 Jun 24, 2025
22 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@morningman @hello-stephen @dataroaring