Skip to content

branch-3.0: [fix](filecache) fix load_cache_info_into_memory crash #51684 #51904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jun 19, 2025
Merged

branch-3.0: [fix](filecache) fix load_cache_info_into_memory crash #51684 #51904

dataroaring merged 1 commit into from
Jun 19, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jun 18, 2025

Cherry-picked from #51684

@freemandealer
[fix](filecache) fix load_cache_info_into_memory crash (#51684)
c6a04d0 
keep _storage last so it will deconstruct first
otherwise, load_cache_info_into_memory might crash coz it will use other
members of BlockFileCache
so join this async load thread first

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@github-actions github-actions bot requested a review from dataroaring as a code owner June 18, 2025 13:32
@Thearas
Copy link
Contributor

Thearas commented Jun 18, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 18, 2025
@Thearas
Copy link
Contributor

Thearas commented Jun 18, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jun 18, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.16% (10902/26487)
Line Coverage 31.97% (93256/291696)
Region Coverage 31.05% (48091/154897)
Branch Coverage 27.51% (24626/89528)

dataroaring
dataroaring approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 5970c82 into branch-3.0 Jun 19, 2025
20 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-51684-branch-3.0 branch June 19, 2025 08:25
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Thearas @doris-robot @dataroaring @freemandealer