-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[fix](filecache) fix load_cache_info_into_memory crash #51684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix](filecache) fix load_cache_info_into_memory crash #51684
Conversation
keep _storage last so it will deconstruct first otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache so join this async load thread first Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
zhannngchen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
run buildall |
TPC-H: Total hot run time: 33872 ms |
TPC-DS: Total hot run time: 193475 ms |
ClickBench: Total hot run time: 29.1 s |
|
run vault_p0 |
dataroaring
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
keep _storage last so it will deconstruct first otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache so join this async load thread first Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
keep _storage last so it will deconstruct first otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache so join this async load thread first Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
keep _storage last so it will deconstruct first
otherwise, load_cache_info_into_memory might crash coz it will use other members of BlockFileCache
so join this async load thread first
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)