Skip to content

Conversation

@github-actions
Copy link
Contributor

Cherry-picked from #51684

keep _storage last so it will deconstruct first
otherwise, load_cache_info_into_memory might crash coz it will use other
members of BlockFileCache
so join this async load thread first

Signed-off-by: zhengyu <zhangzhengyu@selectdb.com>
@github-actions github-actions bot requested a review from morrySnow as a code owner June 19, 2025 12:03
@Thearas
Copy link
Contributor

Thearas commented Jun 19, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jun 19, 2025
@Thearas
Copy link
Contributor

Thearas commented Jun 19, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39716 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 5f351820734527b420c7b3cb31a00cbee7329e40, data reload: false

------ Round 1 ----------------------------------
q1	17596	6791	6603	6603
q2	2078	170	162	162
q3	10601	1066	1164	1066
q4	10541	748	714	714
q5	7749	2848	2858	2848
q6	219	135	130	130
q7	975	605	598	598
q8	9355	1958	2033	1958
q9	6572	6373	6458	6373
q10	7013	2253	2288	2253
q11	468	263	256	256
q12	386	211	203	203
q13	17799	2967	2987	2967
q14	243	204	214	204
q15	509	474	462	462
q16	504	382	368	368
q17	979	564	665	564
q18	7251	6666	6696	6666
q19	1431	1018	1070	1018
q20	483	206	210	206
q21	3912	3125	3148	3125
q22	1088	972	977	972
Total cold run time: 107752 ms
Total hot run time: 39716 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6629	6534	6583	6534
q2	339	238	225	225
q3	2888	2740	2863	2740
q4	2024	1753	1738	1738
q5	5825	5707	5686	5686
q6	216	133	131	131
q7	2181	1808	1828	1808
q8	3331	3585	3512	3512
q9	8950	8731	8875	8731
q10	3570	3481	3480	3480
q11	593	514	493	493
q12	796	625	605	605
q13	10601	3136	3189	3136
q14	279	272	273	272
q15	518	456	478	456
q16	493	445	440	440
q17	1845	1625	1596	1596
q18	8315	7852	7654	7654
q19	1710	1552	1640	1552
q20	2069	1784	1795	1784
q21	5204	5066	5013	5013
q22	1117	1050	1010	1010
Total cold run time: 69493 ms
Total hot run time: 58596 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 198310 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 5f351820734527b420c7b3cb31a00cbee7329e40, data reload: false

query1	1316	907	897	897
query2	6371	1913	1894	1894
query3	10804	4199	4280	4199
query4	61304	28279	23511	23511
query5	5095	457	473	457
query6	407	169	165	165
query7	5543	322	315	315
query8	302	223	218	218
query9	8389	2602	2576	2576
query10	426	282	265	265
query11	17995	15606	15593	15593
query12	164	110	112	110
query13	1493	459	441	441
query14	9754	7683	7615	7615
query15	201	177	185	177
query16	7174	477	506	477
query17	1128	559	554	554
query18	1912	302	309	302
query19	220	162	149	149
query20	116	108	105	105
query21	204	100	103	100
query22	4570	4505	4654	4505
query23	34429	34149	34308	34149
query24	6088	2952	2973	2952
query25	543	418	413	413
query26	656	186	173	173
query27	1804	361	360	360
query28	3759	2176	2160	2160
query29	732	500	457	457
query30	240	154	158	154
query31	966	789	829	789
query32	65	57	56	56
query33	408	322	300	300
query34	940	508	519	508
query35	839	741	730	730
query36	1078	957	949	949
query37	118	70	76	70
query38	4055	3951	3988	3951
query39	1503	1472	1468	1468
query40	211	104	104	104
query41	50	51	48	48
query42	122	106	113	106
query43	533	478	479	478
query44	1188	821	827	821
query45	188	173	174	173
query46	1196	735	727	727
query47	2027	1922	1929	1922
query48	494	399	388	388
query49	739	447	408	408
query50	864	445	439	439
query51	7418	7275	7239	7239
query52	102	93	94	93
query53	277	190	182	182
query54	577	467	470	467
query55	79	74	77	74
query56	264	257	236	236
query57	1314	1212	1213	1212
query58	220	212	208	208
query59	3140	3136	3045	3045
query60	279	266	261	261
query61	110	111	120	111
query62	775	684	677	677
query63	223	191	191	191
query64	1400	673	645	645
query65	3307	3230	3210	3210
query66	701	289	292	289
query67	15915	15606	15601	15601
query68	4302	591	594	591
query69	446	268	268	268
query70	1193	1122	1105	1105
query71	351	266	261	261
query72	6350	4043	4201	4043
query73	744	356	358	356
query74	10182	9226	9115	9115
query75	3404	2683	2659	2659
query76	2010	1048	1010	1010
query77	456	279	274	274
query78	10656	9612	9492	9492
query79	1488	592	596	592
query80	888	436	428	428
query81	494	220	215	215
query82	1275	96	89	89
query83	176	149	146	146
query84	288	88	80	80
query85	874	322	295	295
query86	344	302	291	291
query87	4382	4258	4199	4199
query88	3854	2560	2481	2481
query89	419	289	290	289
query90	1978	189	184	184
query91	183	156	156	156
query92	64	51	52	51
query93	1988	589	583	583
query94	758	304	295	295
query95	359	262	262	262
query96	623	284	280	280
query97	3287	3114	3172	3114
query98	216	203	197	197
query99	1572	1290	1302	1290
Total cold run time: 312428 ms
Total hot run time: 198310 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.33 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 5f351820734527b420c7b3cb31a00cbee7329e40, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.03	0.03
query3	0.24	0.06	0.06
query4	1.62	0.10	0.10
query5	0.54	0.52	0.50
query6	1.12	0.72	0.74
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.49	0.50
query10	0.56	0.55	0.56
query11	0.15	0.12	0.10
query12	0.15	0.12	0.11
query13	0.62	0.59	0.58
query14	0.78	0.79	0.82
query15	0.83	0.83	0.83
query16	0.39	0.39	0.39
query17	1.04	1.01	1.06
query18	0.23	0.22	0.21
query19	1.91	1.88	1.78
query20	0.02	0.01	0.01
query21	15.39	0.59	0.58
query22	2.36	1.53	1.52
query23	17.22	0.93	0.87
query24	3.62	0.38	2.15
query25	0.21	0.20	0.10
query26	0.57	0.13	0.15
query27	0.05	0.05	0.04
query28	9.50	0.53	0.52
query29	12.63	3.25	3.24
query30	0.25	0.06	0.06
query31	2.86	0.39	0.38
query32	3.23	0.46	0.47
query33	3.00	3.02	3.02
query34	17.14	4.47	4.55
query35	4.56	4.54	4.44
query36	0.70	0.49	0.48
query37	0.08	0.06	0.06
query38	0.05	0.04	0.04
query39	0.04	0.02	0.03
query40	0.16	0.13	0.13
query41	0.08	0.02	0.03
query42	0.04	0.02	0.02
query43	0.03	0.02	0.02
Total cold run time: 104.7 s
Total hot run time: 29.33 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.17% (10896/26463)
Line Coverage 31.99% (93208/291346)
Region Coverage 31.06% (48080/154779)
Branch Coverage 27.54% (24634/89460)

@freemandealer
Copy link
Contributor

run cloud_p0

@morrySnow morrySnow merged commit 804da5f into branch-3.1 Jun 20, 2025
21 of 24 checks passed
@morrySnow morrySnow deleted the auto-pick-51684-branch-3.1 branch June 20, 2025 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants