Skip to content

Conversation

@HappenLee
Copy link
Contributor

Proposed changes

Types of changes

What types of changes does your code introduce to Doris?
Put an x in the boxes that apply

  • [] Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [] Documentation Update (if none of the other choices apply)
  • [] Code refactor (Modify the code structure, format the code, etc...)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have create an issue on (Fix #ISSUE), and have described the bug/feature there in detail
  • Compiling and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • If this change need a document change, I have updated the document
  • Any dependent changes have been merged

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman self-assigned this Jan 22, 2021
@morningman morningman added the approved Indicates a PR has been approved by one committer. label Jan 22, 2021
@morningman morningman merged commit a5298d6 into apache:master Jan 23, 2021
@yangzhg yangzhg mentioned this pull request Feb 9, 2021
EmmyMiao87 pushed a commit to EmmyMiao87/incubator-doris that referenced this pull request May 14, 2021
…orage Engine. (apache#5207)

Change-Id: Ic5050bfa4b9c7c3741cd8a6fd041a9cf761f0b1e
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
…en transaction fail apache#57092 (apache#5207)

cherry-picks from apache#57092
Related to apache#5195

Co-authored-by: hui lai <laihui@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants