Skip to content

Conversation

@sollhui
Copy link
Contributor

@sollhui sollhui commented Oct 17, 2025

What problem does this PR solve?

Now, when transaction fail, routine load task will retry as soon as possible, when meet some temporarily unrecoverable errors like too_many_version, it will retry too many times in a short time and take huge pressure to upstream system like Kafka.

To solve this problem, we delay load task schedule when transaction fail to reduce retry times when meet error and restore normal schedule if transactions resume normal execution.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Oct 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@sollhui
Copy link
Contributor Author

sollhui commented Oct 17, 2025

run buildall

@doris-robot
Copy link

ClickBench: Total hot run time: 30.35 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a8d6375675071b57c68e08d19746092259278aa6, data reload: false

query1	0.06	0.05	0.05
query2	0.11	0.06	0.05
query3	0.25	0.09	0.09
query4	1.61	0.12	0.12
query5	0.30	0.27	0.26
query6	1.19	0.68	0.67
query7	0.03	0.03	0.03
query8	0.07	0.05	0.05
query9	0.62	0.55	0.55
query10	0.59	0.60	0.60
query11	0.18	0.11	0.12
query12	0.16	0.13	0.13
query13	0.64	0.63	0.62
query14	1.04	1.03	1.05
query15	0.88	0.86	0.93
query16	0.42	0.40	0.41
query17	1.07	1.07	1.07
query18	0.23	0.22	0.21
query19	1.96	1.87	1.88
query20	0.02	0.01	0.02
query21	15.42	0.96	0.61
query22	0.76	1.14	0.68
query23	14.97	1.39	0.68
query24	6.55	1.46	0.34
query25	0.29	0.11	0.09
query26	0.44	0.17	0.14
query27	0.08	0.06	0.06
query28	9.66	1.42	0.94
query29	12.56	4.06	3.38
query30	0.29	0.14	0.12
query31	2.83	0.62	0.39
query32	3.25	0.56	0.49
query33	3.13	3.09	3.14
query34	16.07	5.50	4.84
query35	4.91	4.95	4.84
query36	0.72	0.52	0.50
query37	0.11	0.07	0.08
query38	0.06	0.05	0.05
query39	0.04	0.03	0.03
query40	0.18	0.16	0.14
query41	0.09	0.03	0.03
query42	0.05	0.03	0.02
query43	0.05	0.04	0.04
Total cold run time: 103.94 s
Total hot run time: 30.35 s

@dataroaring dataroaring added dev/4.0.x dev/3.1.x usercase Important user case type label labels Oct 17, 2025
@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 44.44% (4/9) 🎉
Increment coverage report
Complete coverage report

@sollhui sollhui force-pushed the delay_schedule_meet_error branch from a8d6375 to cf33165 Compare October 17, 2025 07:19
@sollhui
Copy link
Contributor Author

sollhui commented Oct 17, 2025

run buildall

@hello-stephen
Copy link
Contributor

FE Regression Coverage Report

Increment line coverage 66.67% (6/9) 🎉
Increment coverage report
Complete coverage report

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 17, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@liaoxin01 liaoxin01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liaoxin01 liaoxin01 merged commit 1b6476e into apache:master Oct 19, 2025
28 of 30 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 19, 2025
Now, when transaction fail, routine load task will retry as soon as
possible, when meet some temporarily unrecoverable errors like
`too_many_version`, it will retry too many times in a short time and
take huge pressure to upstream system like Kafka.

To solve this problem, we delay load task schedule when transaction fail
to reduce retry times when meet error and restore normal schedule if
transactions resume normal execution.
github-actions bot pushed a commit that referenced this pull request Oct 19, 2025
Now, when transaction fail, routine load task will retry as soon as
possible, when meet some temporarily unrecoverable errors like
`too_many_version`, it will retry too many times in a short time and
take huge pressure to upstream system like Kafka.

To solve this problem, we delay load task schedule when transaction fail
to reduce retry times when meet error and restore normal schedule if
transactions resume normal execution.
yiguolei pushed a commit that referenced this pull request Oct 20, 2025
…fail #57092 (#57131)

Cherry-picked from #57092

Co-authored-by: hui lai <laihui@selectdb.com>
morrySnow pushed a commit that referenced this pull request Oct 28, 2025
…fail #57092 (#57130)

Cherry-picked from #57092

Co-authored-by: hui lai <laihui@selectdb.com>
Hastyshell pushed a commit to Hastyshell/doris that referenced this pull request Nov 12, 2025
…en transaction fail apache#57092 (apache#5207)

cherry-picks from apache#57092
Related to apache#5195

Co-authored-by: hui lai <laihui@selectdb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.3-merged dev/4.0.1-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants