Skip to content

[fix](cloud)fix tablet_path when rowset is null #52280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 2 commits into from
Jul 11, 2025
Merged

[fix](cloud)fix tablet_path when rowset is null #52280

dataroaring merged 2 commits into from
Jul 11, 2025

Conversation

@koarz
Copy link
Contributor

@koarz koarz commented Jun 25, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@koarz
Copy link
Contributor Author

koarz commented Jun 25, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-H: Total hot run time: 34171 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit fd719c935818b856fb7dce6896653f1a8e17e3fd, data reload: false

------ Round 1 ----------------------------------
q1	17585	5143	5034	5034
q2	1954	295	200	200
q3	10264	1312	717	717
q4	10256	1030	540	540
q5	7530	2408	2368	2368
q6	187	163	132	132
q7	915	732	604	604
q8	9313	1301	1141	1141
q9	6848	5083	5133	5083
q10	6885	2397	1955	1955
q11	496	286	275	275
q12	357	356	219	219
q13	17764	3668	3120	3120
q14	242	240	222	222
q15	584	479	486	479
q16	433	434	381	381
q17	604	879	360	360
q18	7855	7250	7204	7204
q19	1250	974	557	557
q20	360	329	230	230
q21	3960	2559	2404	2404
q22	1050	1021	946	946
Total cold run time: 106692 ms
Total hot run time: 34171 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5112	5093	5143	5093
q2	255	320	250	250
q3	2201	2670	2328	2328
q4	1359	1811	1350	1350
q5	4215	4431	4359	4359
q6	212	171	126	126
q7	1981	1940	1757	1757
q8	2581	2623	2539	2539
q9	7240	7068	7213	7068
q10	3027	3236	2839	2839
q11	564	523	496	496
q12	663	786	621	621
q13	3516	3866	3275	3275
q14	289	320	297	297
q15	542	473	483	473
q16	454	502	438	438
q17	1197	1511	1409	1409
q18	7356	7045	7169	7045
q19	779	785	924	785
q20	1942	1972	1804	1804
q21	4808	4371	4290	4290
q22	1068	1073	964	964
Total cold run time: 51361 ms
Total hot run time: 49606 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

TPC-DS: Total hot run time: 185647 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit fd719c935818b856fb7dce6896653f1a8e17e3fd, data reload: false

query1	980	395	397	395
query2	6556	1836	1791	1791
query3	6746	217	217	217
query4	26119	23690	22989	22989
query5	4394	635	480	480
query6	309	227	203	203
query7	4623	502	292	292
query8	275	237	206	206
query9	8648	2649	2664	2649
query10	465	326	267	267
query11	15514	15089	14985	14985
query12	172	111	110	110
query13	1675	549	423	423
query14	9517	6154	6042	6042
query15	206	205	189	189
query16	7652	646	460	460
query17	1201	721	593	593
query18	2039	410	313	313
query19	199	207	164	164
query20	118	124	114	114
query21	217	127	109	109
query22	4175	4133	3988	3988
query23	33839	33076	33162	33076
query24	8420	2393	2395	2393
query25	532	449	396	396
query26	1218	271	148	148
query27	2721	520	341	341
query28	4300	2154	2135	2135
query29	729	544	460	460
query30	273	223	191	191
query31	936	832	757	757
query32	76	66	68	66
query33	550	358	322	322
query34	801	867	530	530
query35	784	828	751	751
query36	947	983	873	873
query37	111	97	77	77
query38	4087	4168	4093	4093
query39	1507	1415	1484	1415
query40	210	115	103	103
query41	64	63	58	58
query42	124	105	107	105
query43	493	511	478	478
query44	1340	823	816	816
query45	178	175	162	162
query46	841	1018	626	626
query47	1738	1770	1721	1721
query48	381	413	314	314
query49	751	481	409	409
query50	639	669	402	402
query51	4143	4133	4168	4133
query52	113	110	104	104
query53	217	248	185	185
query54	569	568	520	520
query55	88	82	80	80
query56	295	305	280	280
query57	1193	1192	1120	1120
query58	258	257	261	257
query59	2533	2585	2539	2539
query60	330	317	308	308
query61	131	128	130	128
query62	798	696	688	688
query63	220	185	186	185
query64	4270	995	679	679
query65	4237	4184	4174	4174
query66	1091	465	325	325
query67	15881	15409	15272	15272
query68	8388	890	527	527
query69	460	304	271	271
query70	1175	1131	1130	1130
query71	463	336	299	299
query72	5396	4690	4696	4690
query73	707	584	352	352
query74	9287	8927	8987	8927
query75	3819	3203	2687	2687
query76	3567	1178	769	769
query77	777	376	294	294
query78	10030	10246	9368	9368
query79	1928	878	573	573
query80	600	516	450	450
query81	478	261	231	231
query82	426	136	101	101
query83	254	308	236	236
query84	244	108	91	91
query85	792	352	311	311
query86	344	301	293	293
query87	4374	4465	4389	4389
query88	3459	2364	2272	2272
query89	387	324	286	286
query90	1890	208	208	208
query91	136	143	113	113
query92	75	62	56	56
query93	1365	934	581	581
query94	671	414	310	310
query95	365	285	288	285
query96	501	568	279	279
query97	2711	2790	2628	2628
query98	238	209	203	203
query99	1468	1395	1263	1263
Total cold run time: 273532 ms
Total hot run time: 185647 ms

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

ClickBench: Total hot run time: 29.4 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit fd719c935818b856fb7dce6896653f1a8e17e3fd, data reload: false

query1	0.03	0.04	0.03
query2	0.08	0.03	0.03
query3	0.25	0.06	0.07
query4	1.61	0.10	0.11
query5	0.42	0.43	0.42
query6	1.17	0.66	0.67
query7	0.03	0.02	0.02
query8	0.05	0.04	0.04
query9	0.59	0.52	0.53
query10	0.58	0.59	0.56
query11	0.16	0.11	0.11
query12	0.15	0.12	0.12
query13	0.63	0.62	0.61
query14	0.80	0.82	0.81
query15	0.92	0.86	0.87
query16	0.40	0.39	0.41
query17	1.09	1.07	1.04
query18	0.23	0.21	0.21
query19	1.92	1.92	1.90
query20	0.01	0.01	0.02
query21	15.35	0.89	0.57
query22	0.76	1.13	0.74
query23	14.88	1.40	0.61
query24	7.14	1.47	0.56
query25	0.51	0.13	0.21
query26	0.65	0.16	0.13
query27	0.07	0.06	0.06
query28	9.42	0.96	0.46
query29	12.54	4.03	3.29
query30	0.27	0.10	0.07
query31	2.84	0.58	0.39
query32	3.22	0.55	0.47
query33	3.09	3.01	3.09
query34	16.18	5.35	4.77
query35	4.81	4.81	4.80
query36	0.68	0.51	0.49
query37	0.09	0.07	0.07
query38	0.05	0.04	0.03
query39	0.03	0.02	0.02
query40	0.18	0.15	0.14
query41	0.09	0.03	0.03
query42	0.04	0.03	0.03
query43	0.03	0.03	0.03
Total cold run time: 104.04 s
Total hot run time: 29.4 s

@doris-robot
Copy link

doris-robot commented Jun 25, 2025

BE UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.06% (15356/26912)
Line Coverage 46.14% (139347/301993)
Region Coverage 45.48% (70600/155234)
Branch Coverage 40.23% (37290/92684)

@koarz
Copy link
Contributor Author

koarz commented Jun 25, 2025

run nonConcurrent

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

BE Regression && UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 63.05% (16693/26474)
Line Coverage 52.78% (159279/301805)
Region Coverage 50.45% (91918/182198)
Branch Coverage 43.92% (46312/105454)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jun 25, 2025

BE Regression && UT Coverage Report

Increment line coverage 33.33% (1/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 63.10% (16705/26474)
Line Coverage 52.84% (159475/301805)
Region Coverage 50.51% (92021/182198)
Branch Coverage 44.00% (46402/105454)

@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 25, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jun 25, 2025

PR approved by anyone and no changes requested.

dataroaring
dataroaring approved these changes Jul 1, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 069a9e9 into apache:master Jul 11, 2025
28 of 29 checks passed
@koarz koarz deleted the fix_cloud_rowset_null branch July 11, 2025 04:30
@morrySnow morrySnow mentioned this pull request Jul 25, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@koarz @hello-stephen @doris-robot @gavinchou @dataroaring @morrySnow