Skip to content

[fix](cloud)fix tablet_path when rowset is null #52280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 2 commits into from
Jul 11, 2025
Merged

[fix](cloud)fix tablet_path when rowset is null #52280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9510581
[fix](cloud)fix tablet_path when rowset is null
koarz Jun 25, 2025
fd719c9
fix
koarz Jun 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions be/src/cloud/cloud_tablet.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,8 @@ bool CloudTablet::exceed_version_limit(int32_t limit) {
return _approximate_num_rowsets.load(std::memory_order_relaxed) > limit;
}

const std::string& CloudTablet::tablet_path() const {
return get_rowset_with_max_version()->tablet_path();
std::string CloudTablet::tablet_path() const {
return "";
}

Status CloudTablet::capture_consistent_rowsets_unlocked(
Expand Down
2 changes: 1 addition & 1 deletion be/src/cloud/cloud_tablet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ class CloudTablet final : public BaseTablet {
return _approximate_data_size.load(std::memory_order_relaxed);
}

const std::string& tablet_path() const override;
std::string tablet_path() const override;

// clang-format off
int64_t fetch_add_approximate_num_rowsets (int64_t x) { return _approximate_num_rowsets .fetch_add(x, std::memory_order_relaxed); }
Expand Down
2 changes: 1 addition & 1 deletion be/src/olap/base_tablet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ class BaseTablet {
void set_alter_failed(bool alter_failed) { _alter_failed = alter_failed; }
bool is_alter_failed() { return _alter_failed; }

virtual const std::string& tablet_path() const = 0;
virtual std::string tablet_path() const = 0;

virtual bool exceed_version_limit(int32_t limit) = 0;

Expand Down
2 changes: 1 addition & 1 deletion be/src/olap/tablet.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ class Tablet final : public BaseTablet {
DataDir* data_dir() const { return _data_dir; }
int64_t replica_id() const { return _tablet_meta->replica_id(); }

const std::string& tablet_path() const override { return _tablet_path; }
std::string tablet_path() const override { return _tablet_path; }

bool set_tablet_schema_into_rowset_meta();
Status init();
Expand Down
Loading