Skip to content

branch-3.0: [fix](be) Fix check_storage_vault deadlock #52541 #52602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dataroaring merged 1 commit into from
Jul 2, 2025
Merged

branch-3.0: [fix](be) Fix check_storage_vault deadlock #52541 #52602

dataroaring merged 1 commit into from
Jul 2, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2025

Cherry-picked from #52541

@swjtu-zhanglei
[fix](be) Fix check_storage_vault deadlock (#52541)
f8b2901 
* #51175 introduced a deadlock
problem:
1. the `sync_storage_vault()` func wait for heartbeat thread to set
config::meta_service_endpoint

2. the heartbeat thread wait for the `sync_storage_vault()` func success
to start
@github-actions github-actions bot requested a review from dataroaring as a code owner July 1, 2025 12:10
@Thearas
Copy link
Contributor

Thearas commented Jul 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jul 1, 2025
@dataroaring dataroaring reopened this Jul 1, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 1, 2025

run buildall

dataroaring
dataroaring approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 79be96b into branch-3.0 Jul 2, 2025
21 of 25 checks passed
@github-actions github-actions bot deleted the auto-pick-52541-branch-3.0 branch July 2, 2025 02:32
koarz pushed a commit to koarz/doris that referenced this pull request Jul 3, 2025
@github-actions @swjtu-zhanglei @koarz
branch-3.0: [fix](be) Fix check_storage_vault deadlock apache#52541 (…
e8a8755 
…apache#52602)

Cherry-picked from apache#52541

Co-authored-by: Lei Zhang <zhanglei@selectdb.com>
@gavinchou gavinchou mentioned this pull request Aug 15, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @dataroaring @swjtu-zhanglei