Skip to content

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Jul 1, 2025

cherry-pick from #52610

@eldenmoon eldenmoon requested a review from morrySnow as a code owner July 1, 2025 13:20
@Thearas
Copy link
Contributor

Thearas commented Jul 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon eldenmoon changed the title [Fix](Variant) add implementation update_XXXhash for IColumnDummy branch-3.1: [Fix](Variant) add implementation update_XXXhash for IColumnDummy Jul 1, 2025
@eldenmoon
Copy link
Member Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39521 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 54b8dd0be88ac9c747632919f3c3e2ae48690cd8, data reload: false

------ Round 1 ----------------------------------
q1	17616	6911	6633	6633
q2	2100	183	155	155
q3	10651	1117	1134	1117
q4	10521	708	738	708
q5	7759	2881	2801	2801
q6	210	134	140	134
q7	1003	626	607	607
q8	9345	1933	2033	1933
q9	6646	6462	6408	6408
q10	7048	2283	2307	2283
q11	463	270	264	264
q12	390	207	200	200
q13	17812	3008	2976	2976
q14	240	200	212	200
q15	519	471	471	471
q16	474	376	364	364
q17	986	584	515	515
q18	7242	6625	6551	6551
q19	1323	1001	1029	1001
q20	457	204	203	203
q21	3927	3027	3065	3027
q22	1059	991	970	970
Total cold run time: 107791 ms
Total hot run time: 39521 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6718	6620	6619	6619
q2	329	231	232	231
q3	2982	2925	2865	2865
q4	2032	1810	1828	1810
q5	5736	5734	5783	5734
q6	214	127	127	127
q7	2218	1818	1817	1817
q8	3403	3511	3600	3511
q9	8818	8898	8924	8898
q10	3558	3525	3552	3525
q11	590	492	500	492
q12	820	591	629	591
q13	7026	3174	3162	3162
q14	317	266	259	259
q15	521	468	474	468
q16	476	439	441	439
q17	1843	1654	1622	1622
q18	8276	7974	7718	7718
q19	1690	1500	1430	1430
q20	2071	1806	1835	1806
q21	5149	5053	4885	4885
q22	1115	1035	1040	1035
Total cold run time: 65902 ms
Total hot run time: 59044 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195912 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 54b8dd0be88ac9c747632919f3c3e2ae48690cd8, data reload: false

query1	1303	918	903	903
query2	6374	1865	1847	1847
query3	10813	4211	4210	4210
query4	33249	23317	24136	23317
query5	4682	457	458	457
query6	286	173	170	170
query7	3997	314	316	314
query8	282	230	234	230
query9	9589	2541	2547	2541
query10	481	267	261	261
query11	18321	15223	15352	15223
query12	159	103	102	102
query13	1564	436	420	420
query14	9408	6672	7358	6672
query15	255	194	183	183
query16	8142	515	524	515
query17	1704	621	607	607
query18	2181	318	319	318
query19	314	167	167	167
query20	123	117	114	114
query21	210	115	123	115
query22	4805	4396	4450	4396
query23	35042	34076	34437	34076
query24	11751	2871	2861	2861
query25	669	417	425	417
query26	1711	183	177	177
query27	2742	363	361	361
query28	7631	2118	2143	2118
query29	1033	468	465	465
query30	261	174	155	155
query31	1063	825	838	825
query32	135	58	66	58
query33	793	300	295	295
query34	1055	513	526	513
query35	903	749	740	740
query36	1134	967	956	956
query37	145	69	64	64
query38	4047	3952	4012	3952
query39	1539	1485	1480	1480
query40	253	104	109	104
query41	51	49	48	48
query42	115	103	98	98
query43	523	480	472	472
query44	1324	819	812	812
query45	199	174	166	166
query46	1152	748	747	747
query47	2009	1915	1919	1915
query48	457	340	345	340
query49	996	413	397	397
query50	833	434	429	429
query51	7382	7296	7342	7296
query52	102	95	88	88
query53	264	177	181	177
query54	1262	463	469	463
query55	79	81	93	81
query56	263	261	244	244
query57	1321	1217	1203	1203
query58	230	212	216	212
query59	3185	2971	2980	2971
query60	293	278	271	271
query61	115	109	109	109
query62	856	707	704	704
query63	226	195	192	192
query64	5116	706	648	648
query65	3365	3333	3203	3203
query66	1321	296	306	296
query67	15906	15439	15493	15439
query68	4820	593	564	564
query69	432	268	266	266
query70	1204	1120	1095	1095
query71	324	257	252	252
query72	6221	4027	3986	3986
query73	758	347	354	347
query74	10386	8943	9049	8943
query75	3375	2636	2683	2636
query76	2654	1015	1100	1015
query77	366	275	267	267
query78	10539	9527	9648	9527
query79	1783	609	597	597
query80	1051	456	425	425
query81	542	224	222	222
query82	932	89	88	88
query83	237	143	139	139
query84	237	80	78	78
query85	1318	320	308	308
query86	410	293	287	287
query87	4399	4224	4252	4224
query88	3728	2368	2332	2332
query89	424	292	294	292
query90	2002	184	180	180
query91	142	111	120	111
query92	75	50	51	50
query93	2465	561	563	561
query94	899	294	295	294
query95	369	257	259	257
query96	623	285	271	271
query97	3289	3118	3184	3118
query98	231	196	194	194
query99	1504	1266	1308	1266
Total cold run time: 306833 ms
Total hot run time: 195912 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.75 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 54b8dd0be88ac9c747632919f3c3e2ae48690cd8, data reload: false

query1	0.04	0.03	0.02
query2	0.07	0.03	0.03
query3	0.24	0.07	0.07
query4	1.61	0.11	0.10
query5	0.53	0.52	0.52
query6	1.13	0.73	0.74
query7	0.02	0.02	0.02
query8	0.04	0.03	0.03
query9	0.55	0.50	0.50
query10	0.56	0.58	0.55
query11	0.13	0.11	0.11
query12	0.13	0.11	0.10
query13	0.62	0.61	0.59
query14	0.79	0.80	0.82
query15	0.84	0.83	0.85
query16	0.37	0.39	0.38
query17	1.08	1.08	1.06
query18	0.24	0.23	0.22
query19	1.94	1.88	1.84
query20	0.01	0.01	0.01
query21	15.53	0.63	0.59
query22	2.86	2.65	1.39
query23	16.91	0.94	0.80
query24	3.43	0.69	1.40
query25	0.19	0.25	0.16
query26	0.35	0.15	0.13
query27	0.05	0.05	0.05
query28	10.32	0.53	0.50
query29	12.58	3.21	3.21
query30	0.26	0.07	0.06
query31	2.85	0.42	0.39
query32	3.23	0.47	0.46
query33	3.04	3.03	3.03
query34	16.94	4.51	4.51
query35	4.51	4.49	4.57
query36	0.67	0.49	0.48
query37	0.08	0.06	0.06
query38	0.04	0.04	0.03
query39	0.03	0.03	0.02
query40	0.18	0.13	0.14
query41	0.08	0.02	0.02
query42	0.04	0.02	0.02
query43	0.04	0.03	0.02
Total cold run time: 105.15 s
Total hot run time: 29.75 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.08% (12391/27485)
Line Coverage 36.06% (109665/304120)
Region Coverage 35.14% (56836/161755)
Branch Coverage 32.25% (30825/95570)

@morrySnow morrySnow merged commit dd9d709 into apache:branch-3.1 Jul 2, 2025
23 of 25 checks passed
@eldenmoon eldenmoon deleted the branch-3.1-variant-feature-3 branch July 2, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants