Skip to content

[Fix](Variant) add implementation update_XXXhash for IColumnDummy #52610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
eldenmoon merged 1 commit into from
Jul 2, 2025
Merged

[Fix](Variant) add implementation update_XXXhash for IColumnDummy #52610

eldenmoon merged 1 commit into from
Jul 2, 2025

Conversation

@eldenmoon
Copy link
Member

@eldenmoon eldenmoon commented Jul 1, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 1, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@eldenmoon eldenmoon mentioned this pull request Jul 1, 2025
Merged
@eldenmoon
Copy link
Member Author

eldenmoon commented Jul 1, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

TPC-H: Total hot run time: 33525 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit ef563ca4e8554558bf39dba689b0498153b1dfbf, data reload: false

------ Round 1 ----------------------------------
q1	17599	5228	5043	5043
q2	1933	266	181	181
q3	10329	1268	724	724
q4	10232	1012	499	499
q5	7524	2400	2255	2255
q6	176	155	126	126
q7	887	766	599	599
q8	9322	1249	1008	1008
q9	6724	5093	5155	5093
q10	6876	2369	1969	1969
q11	467	291	269	269
q12	337	350	202	202
q13	17767	3665	3110	3110
q14	229	218	203	203
q15	547	467	487	467
q16	412	417	374	374
q17	570	846	354	354
q18	7601	7141	7057	7057
q19	1377	959	552	552
q20	318	345	214	214
q21	3593	3089	2264	2264
q22	1015	1005	962	962
Total cold run time: 105835 ms
Total hot run time: 33525 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5107	5029	5038	5029
q2	240	328	222	222
q3	2116	2606	2312	2312
q4	1317	1796	1370	1370
q5	4189	4291	4456	4291
q6	212	168	129	129
q7	2023	1984	1800	1800
q8	2644	2587	2457	2457
q9	7095	7405	7211	7211
q10	3122	3467	2826	2826
q11	565	533	504	504
q12	667	765	665	665
q13	3525	3791	3054	3054
q14	267	285	254	254
q15	508	468	461	461
q16	415	454	428	428
q17	1136	1438	1351	1351
q18	7267	7099	7207	7099
q19	749	737	934	737
q20	1898	1975	1873	1873
q21	4752	4338	4219	4219
q22	1042	1034	975	975
Total cold run time: 50856 ms
Total hot run time: 49267 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

TPC-DS: Total hot run time: 184070 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit ef563ca4e8554558bf39dba689b0498153b1dfbf, data reload: false

query1	1020	390	387	387
query2	6523	1716	1723	1716
query3	6756	209	220	209
query4	26194	23782	23095	23095
query5	4414	591	419	419
query6	299	226	198	198
query7	4631	487	289	289
query8	295	222	209	209
query9	8606	2613	2637	2613
query10	469	332	266	266
query11	15679	14997	14799	14799
query12	160	107	103	103
query13	1663	531	409	409
query14	9447	5673	5651	5651
query15	203	197	179	179
query16	7650	605	470	470
query17	1198	735	604	604
query18	2032	410	311	311
query19	202	202	160	160
query20	117	119	117	117
query21	209	122	111	111
query22	4079	4157	4022	4022
query23	34323	32942	32682	32682
query24	8391	2397	2352	2352
query25	523	457	388	388
query26	1065	264	145	145
query27	2721	506	332	332
query28	4307	2142	2076	2076
query29	683	547	428	428
query30	283	209	185	185
query31	932	831	755	755
query32	70	61	66	61
query33	529	357	336	336
query34	777	836	519	519
query35	780	804	731	731
query36	963	992	881	881
query37	112	112	75	75
query38	4194	4083	4032	4032
query39	1480	1436	1366	1366
query40	205	111	101	101
query41	54	51	50	50
query42	128	105	103	103
query43	493	521	486	486
query44	1316	830	812	812
query45	172	166	164	164
query46	831	996	632	632
query47	1738	1826	1700	1700
query48	379	439	308	308
query49	694	456	383	383
query50	630	689	409	409
query51	4095	4198	4137	4137
query52	114	101	103	101
query53	222	248	181	181
query54	580	564	507	507
query55	83	82	78	78
query56	292	296	290	290
query57	1192	1192	1104	1104
query58	260	256	280	256
query59	2628	2782	2613	2613
query60	315	312	337	312
query61	131	122	119	119
query62	800	704	639	639
query63	215	182	188	182
query64	3672	1004	716	716
query65	4248	4192	4199	4192
query66	946	405	304	304
query67	15678	15623	15501	15501
query68	8090	914	513	513
query69	479	299	259	259
query70	1185	1075	1092	1075
query71	492	339	281	281
query72	5601	4714	4755	4714
query73	731	617	342	342
query74	8871	8912	8675	8675
query75	3855	3167	2680	2680
query76	3611	1139	713	713
query77	784	382	278	278
query78	9917	10062	9360	9360
query79	2762	821	585	585
query80	642	570	435	435
query81	499	255	216	216
query82	473	124	94	94
query83	281	256	230	230
query84	287	107	85	85
query85	779	358	317	317
query86	383	288	278	278
query87	4411	4558	4331	4331
query88	3600	2272	2279	2272
query89	391	308	285	285
query90	1862	205	198	198
query91	138	142	106	106
query92	76	58	53	53
query93	1821	954	587	587
query94	673	404	310	310
query95	375	284	280	280
query96	500	564	283	283
query97	2730	2729	2687	2687
query98	228	211	207	207
query99	1445	1396	1280	1280
Total cold run time: 274062 ms
Total hot run time: 184070 ms

@doris-robot
Copy link

doris-robot commented Jul 1, 2025

ClickBench: Total hot run time: 29.61 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit ef563ca4e8554558bf39dba689b0498153b1dfbf, data reload: false

query1	0.04	0.04	0.04
query2	0.07	0.04	0.04
query3	0.24	0.08	0.09
query4	1.62	0.11	0.11
query5	0.43	0.43	0.43
query6	1.18	0.67	0.67
query7	0.02	0.02	0.01
query8	0.05	0.04	0.04
query9	0.60	0.52	0.53
query10	0.58	0.57	0.56
query11	0.16	0.11	0.12
query12	0.16	0.12	0.12
query13	0.64	0.62	0.62
query14	0.80	0.81	0.84
query15	0.92	0.89	0.87
query16	0.40	0.39	0.39
query17	1.07	1.06	1.06
query18	0.23	0.22	0.21
query19	1.99	1.83	1.88
query20	0.02	0.01	0.01
query21	15.40	0.89	0.57
query22	0.74	1.08	0.62
query23	15.08	1.40	0.61
query24	7.09	0.90	0.78
query25	0.51	0.18	0.16
query26	0.67	0.16	0.14
query27	0.06	0.05	0.05
query28	9.46	0.97	0.44
query29	12.57	3.94	3.26
query30	0.25	0.10	0.08
query31	2.82	0.59	0.38
query32	3.25	0.59	0.48
query33	3.07	3.12	3.13
query34	15.96	5.39	4.75
query35	4.81	4.91	4.82
query36	0.69	0.52	0.48
query37	0.09	0.07	0.06
query38	0.06	0.04	0.04
query39	0.04	0.03	0.03
query40	0.17	0.14	0.13
query41	0.08	0.03	0.03
query42	0.04	0.02	0.03
query43	0.05	0.03	0.03
Total cold run time: 104.18 s
Total hot run time: 29.61 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 1, 2025

BE UT Coverage Report

Increment line coverage 80.00% (4/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.11% (15373/26917)
Line Coverage 46.15% (139482/302258)
Region Coverage 45.44% (70678/155536)
Branch Coverage 40.21% (37315/92804)

csun5285
csun5285 approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@csun5285 csun5285 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

PR approved by anyone and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 2, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

PR approved by at least one committer and no changes requested.

@eldenmoon eldenmoon merged commit 6776975 into apache:master Jul 2, 2025
23 of 27 checks passed
morrySnow pushed a commit that referenced this pull request Jul 2, 2025
@eldenmoon
branch-3.1: [Fix](Variant) add implementation update_XXXhash for ICol…
dd9d709 
…umnDummy #52610 (#52609)

cherry-pick from #52610
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@eldenmoon @koarz
[Fix](Variant) add implementation update_XXXhash for IColumnDummy (a…
dbfd3b2 
…pache#52610)
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@eldenmoon @koarz
[Fix](Variant) add implementation update_XXXhash for IColumnDummy (a…
8b3cdb6 
…pache#52610)
koarz pushed a commit to koarz/doris that referenced this pull request Jul 4, 2025
@eldenmoon @koarz
[Fix](Variant) add implementation update_XXXhash for IColumnDummy (a…
272ca46 
…pache#52610)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yiguolei yiguolei yiguolei approved these changes

+1 more reviewer

@csun5285 csun5285 csun5285 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.0-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@eldenmoon @hello-stephen @doris-robot @yiguolei @csun5285 @morrySnow