Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 1, 2025

Cherry-picked from #52596

Problem Summary:

DeleteBitmap::AggCache use a singleton to manage the memory of LRUCache.
It needs to release the cache memory at program exit.
@github-actions github-actions bot requested a review from dataroaring as a code owner July 1, 2025 13:39
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring closed this Jul 1, 2025
@dataroaring dataroaring reopened this Jul 1, 2025
@hello-stephen
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 39882 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 6da0501ebc16bfee57b42bdb8959ffe139f6cfa0, data reload: false

------ Round 1 ----------------------------------
q1	17590	6952	6603	6603
q2	2064	168	166	166
q3	10712	1082	1186	1082
q4	10549	772	702	702
q5	7788	2888	2854	2854
q6	216	137	134	134
q7	993	626	616	616
q8	9364	1973	2014	1973
q9	6667	6441	6439	6439
q10	6949	2365	2294	2294
q11	452	262	251	251
q12	406	207	211	207
q13	17781	2994	3018	2994
q14	245	211	216	211
q15	493	455	460	455
q16	476	388	379	379
q17	996	552	562	552
q18	7429	6549	6704	6549
q19	1403	1128	992	992
q20	492	203	198	198
q21	3893	3261	3260	3260
q22	1060	1009	971	971
Total cold run time: 108018 ms
Total hot run time: 39882 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6634	6576	6539	6539
q2	328	226	227	226
q3	2954	2786	2916	2786
q4	2058	1842	1767	1767
q5	5836	5785	5740	5740
q6	215	132	133	132
q7	2209	1801	1806	1801
q8	3410	3593	3546	3546
q9	9031	8877	9000	8877
q10	3564	3540	3514	3514
q11	601	510	503	503
q12	796	609	617	609
q13	9549	3109	3154	3109
q14	308	272	266	266
q15	519	464	467	464
q16	485	437	457	437
q17	1855	1627	1612	1612
q18	8323	7710	7767	7710
q19	1731	1571	1502	1502
q20	2118	1875	1823	1823
q21	5101	4981	5103	4981
q22	1146	1034	1038	1034
Total cold run time: 68771 ms
Total hot run time: 58978 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 197376 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 6da0501ebc16bfee57b42bdb8959ffe139f6cfa0, data reload: false

query1	1279	912	927	912
query2	6392	1863	1817	1817
query3	10810	4390	4339	4339
query4	61355	29627	23663	23663
query5	5230	456	445	445
query6	409	183	181	181
query7	5417	317	315	315
query8	313	229	219	219
query9	8253	2556	2568	2556
query10	475	275	258	258
query11	18018	15641	15984	15641
query12	154	103	105	103
query13	1385	449	418	418
query14	10961	7097	7558	7097
query15	206	176	179	176
query16	7110	448	503	448
query17	1152	571	590	571
query18	1812	325	320	320
query19	210	163	166	163
query20	123	118	114	114
query21	213	105	102	102
query22	4749	4401	4797	4401
query23	34684	34207	34298	34207
query24	6149	3003	2991	2991
query25	551	435	432	432
query26	676	178	174	174
query27	1748	354	355	354
query28	3992	2150	2121	2121
query29	727	486	460	460
query30	239	165	165	165
query31	1033	793	831	793
query32	77	57	62	57
query33	459	307	317	307
query34	934	491	509	491
query35	843	757	726	726
query36	1060	958	977	958
query37	117	71	66	66
query38	4040	4008	3982	3982
query39	1558	1464	1484	1464
query40	205	103	106	103
query41	48	50	48	48
query42	110	104	107	104
query43	520	470	471	470
query44	1164	817	798	798
query45	187	165	170	165
query46	1145	731	735	731
query47	2012	1880	1960	1880
query48	485	393	383	383
query49	724	416	391	391
query50	845	429	420	420
query51	7483	7289	7166	7166
query52	106	93	98	93
query53	266	191	190	190
query54	569	463	476	463
query55	84	80	84	80
query56	284	261	242	242
query57	1311	1213	1193	1193
query58	227	246	209	209
query59	3160	3057	3036	3036
query60	288	249	245	245
query61	122	104	118	104
query62	768	676	682	676
query63	219	191	183	183
query64	1380	673	631	631
query65	3263	3182	3245	3182
query66	707	313	295	295
query67	15957	15545	15554	15545
query68	4128	574	583	574
query69	432	272	260	260
query70	1185	1080	1128	1080
query71	364	254	253	253
query72	6397	4051	4074	4051
query73	755	348	363	348
query74	10603	9039	8897	8897
query75	3410	2624	2695	2624
query76	1998	1063	1116	1063
query77	538	271	270	270
query78	10599	9527	9545	9527
query79	1125	601	599	599
query80	841	419	440	419
query81	523	222	220	220
query82	176	89	88	88
query83	163	147	142	142
query84	282	86	81	81
query85	932	303	292	292
query86	343	304	289	289
query87	4440	4276	4260	4260
query88	4078	2415	2355	2355
query89	422	292	287	287
query90	2052	187	188	187
query91	183	151	169	151
query92	63	53	49	49
query93	1744	554	540	540
query94	783	284	301	284
query95	357	265	258	258
query96	620	279	285	279
query97	3288	3133	3177	3133
query98	213	201	199	199
query99	1562	1285	1284	1284
Total cold run time: 313151 ms
Total hot run time: 197376 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.59 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 6da0501ebc16bfee57b42bdb8959ffe139f6cfa0, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.24	0.07	0.07
query4	1.62	0.10	0.11
query5	0.52	0.49	0.52
query6	1.13	0.74	0.74
query7	0.02	0.01	0.02
query8	0.04	0.04	0.04
query9	0.57	0.49	0.50
query10	0.56	0.56	0.55
query11	0.14	0.11	0.10
query12	0.15	0.11	0.11
query13	0.62	0.61	0.59
query14	0.78	0.79	0.81
query15	0.85	0.82	0.83
query16	0.41	0.37	0.37
query17	0.99	1.03	1.05
query18	0.22	0.21	0.22
query19	1.88	1.86	1.89
query20	0.02	0.01	0.01
query21	15.43	0.58	0.57
query22	2.38	1.74	2.02
query23	17.02	0.87	0.88
query24	2.97	1.48	1.47
query25	0.25	0.17	0.05
query26	0.47	0.13	0.13
query27	0.05	0.05	0.04
query28	9.66	0.53	0.48
query29	12.64	3.16	3.20
query30	0.25	0.06	0.06
query31	2.85	0.38	0.39
query32	3.24	0.47	0.46
query33	2.96	3.02	3.05
query34	17.26	4.45	4.46
query35	4.52	4.50	4.51
query36	0.65	0.50	0.47
query37	0.09	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.02
query40	0.16	0.12	0.12
query41	0.08	0.02	0.03
query42	0.03	0.03	0.02
query43	0.04	0.03	0.03
Total cold run time: 103.94 s
Total hot run time: 30.59 s

@zhannngchen
Copy link
Contributor

#52649 is better solution

@zhannngchen zhannngchen closed this Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants