Skip to content

Conversation

@Yukang-Lian
Copy link
Collaborator

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian Yukang-Lian changed the title 1 [Fix](Clone) Fix compaction and mow failure when missing rowset Jul 4, 2025
@Yukang-Lian Yukang-Lian marked this pull request as draft July 7, 2025 02:15
@Yukang-Lian Yukang-Lian marked this pull request as ready for review July 9, 2025 05:45
@dataroaring
Copy link
Contributor

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 82.05% (1257/1532)
Line Coverage 67.85% (21501/31689)
Region Coverage 67.45% (10657/15799)
Branch Coverage 56.94% (5614/9860)

Copy link
Contributor

@zhannngchen zhannngchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 11, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hello-stephen
Copy link
Contributor

FE UT Coverage Report

Increment line coverage 0.00% (0/2) 🎉
Increment coverage report
Complete coverage report

@doris-robot
Copy link

TPC-H: Total hot run time: 33398 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 8aa4f197f0286ea9a062878b72ab845b0550d6f2, data reload: false

------ Round 1 ----------------------------------
q1	17574	5243	5056	5056
q2	1956	287	196	196
q3	10318	1321	741	741
q4	10256	1029	524	524
q5	7685	2438	2399	2399
q6	177	156	127	127
q7	893	754	602	602
q8	9301	1337	1151	1151
q9	7660	5113	5175	5113
q10	6892	2393	1966	1966
q11	487	294	282	282
q12	336	350	212	212
q13	17764	3754	3086	3086
q14	225	223	212	212
q15	547	487	488	487
q16	433	428	374	374
q17	577	895	364	364
q18	7622	7350	7092	7092
q19	1400	937	561	561
q20	340	353	216	216
q21	3668	3192	2341	2341
q22	362	321	296	296
Total cold run time: 106473 ms
Total hot run time: 33398 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5139	5317	5055	5055
q2	244	334	229	229
q3	2143	2701	2306	2306
q4	1397	1769	1358	1358
q5	4282	4479	4534	4479
q6	246	184	124	124
q7	2031	1976	1801	1801
q8	2641	2625	2524	2524
q9	7424	7349	7376	7349
q10	3169	3316	2861	2861
q11	596	538	526	526
q12	719	791	624	624
q13	3634	3966	3323	3323
q14	277	295	297	295
q15	515	478	474	474
q16	443	482	438	438
q17	1199	1662	1383	1383
q18	7982	7919	7560	7560
q19	815	772	845	772
q20	1925	2006	1847	1847
q21	4796	4380	4321	4321
q22	634	585	551	551
Total cold run time: 52251 ms
Total hot run time: 50200 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 187325 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 8aa4f197f0286ea9a062878b72ab845b0550d6f2, data reload: false

query1	977	380	391	380
query2	6519	1699	1715	1699
query3	6737	219	217	217
query4	26504	23699	23421	23421
query5	4311	569	426	426
query6	312	204	187	187
query7	4632	493	279	279
query8	251	212	218	212
query9	8623	2611	2623	2611
query10	458	339	287	287
query11	15554	15072	14762	14762
query12	160	106	111	106
query13	1667	534	389	389
query14	8584	5894	5906	5894
query15	215	203	174	174
query16	7136	642	505	505
query17	957	730	589	589
query18	1997	414	321	321
query19	206	191	165	165
query20	124	119	111	111
query21	213	123	105	105
query22	4188	4213	3990	3990
query23	34234	33149	33182	33149
query24	8548	2394	2414	2394
query25	594	452	383	383
query26	1234	270	150	150
query27	2760	556	350	350
query28	4313	2147	2145	2145
query29	767	557	432	432
query30	292	218	191	191
query31	924	857	775	775
query32	69	60	59	59
query33	553	377	308	308
query34	809	853	515	515
query35	806	836	735	735
query36	967	989	901	901
query37	118	102	76	76
query38	4235	4211	4114	4114
query39	1543	1428	1415	1415
query40	211	121	106	106
query41	61	56	53	53
query42	121	110	101	101
query43	503	507	480	480
query44	1321	839	842	839
query45	177	178	167	167
query46	831	1039	624	624
query47	1804	1828	1765	1765
query48	368	429	310	310
query49	732	488	389	389
query50	649	699	423	423
query51	5546	5437	5347	5347
query52	107	104	101	101
query53	226	248	187	187
query54	574	576	501	501
query55	86	83	82	82
query56	319	310	292	292
query57	1175	1201	1133	1133
query58	270	275	263	263
query59	2629	2637	2494	2494
query60	323	319	311	311
query61	126	160	117	117
query62	777	712	658	658
query63	226	184	196	184
query64	4335	1049	680	680
query65	4271	4226	4245	4226
query66	1126	456	321	321
query67	16014	15664	15484	15484
query68	7995	890	530	530
query69	463	302	274	274
query70	1205	1083	1049	1049
query71	475	329	303	303
query72	5678	4837	4902	4837
query73	761	703	355	355
query74	9309	9187	9002	9002
query75	3771	3219	2773	2773
query76	3641	1150	719	719
query77	787	389	310	310
query78	10213	10335	9277	9277
query79	1964	871	577	577
query80	588	515	445	445
query81	489	258	237	237
query82	439	188	94	94
query83	252	255	230	230
query84	293	114	89	89
query85	827	359	314	314
query86	352	310	283	283
query87	4519	4511	4426	4426
query88	3522	2304	2315	2304
query89	391	316	290	290
query90	1981	215	209	209
query91	142	131	112	112
query92	68	66	56	56
query93	1188	967	591	591
query94	662	429	307	307
query95	384	301	295	295
query96	494	579	286	286
query97	2711	2741	2696	2696
query98	234	214	207	207
query99	1370	1388	1288	1288
Total cold run time: 275167 ms
Total hot run time: 187325 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.48 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 8aa4f197f0286ea9a062878b72ab845b0550d6f2, data reload: false

query1	0.04	0.03	0.03
query2	0.11	0.05	0.06
query3	0.29	0.08	0.06
query4	1.60	0.08	0.08
query5	0.43	0.42	0.41
query6	1.16	0.67	0.65
query7	0.02	0.02	0.02
query8	0.06	0.05	0.04
query9	0.64	0.53	0.54
query10	0.58	0.59	0.58
query11	0.26	0.13	0.13
query12	0.26	0.13	0.14
query13	0.66	0.63	0.63
query14	0.81	0.83	0.85
query15	0.99	0.90	0.89
query16	0.40	0.38	0.38
query17	1.09	1.06	1.07
query18	0.25	0.23	0.24
query19	2.00	1.84	1.93
query20	0.02	0.01	0.01
query21	15.41	0.98	0.67
query22	0.95	1.10	0.81
query23	14.68	1.55	0.81
query24	5.43	0.59	0.30
query25	0.16	0.09	0.09
query26	0.56	0.22	0.20
query27	0.09	0.09	0.08
query28	11.06	1.20	0.60
query29	12.62	4.18	3.45
query30	0.30	0.09	0.06
query31	2.82	0.65	0.44
query32	3.25	0.62	0.52
query33	3.15	3.17	3.22
query34	17.10	5.43	4.74
query35	4.87	4.77	4.85
query36	0.65	0.52	0.50
query37	0.21	0.18	0.18
query38	0.18	0.16	0.16
query39	0.05	0.05	0.05
query40	0.20	0.17	0.16
query41	0.10	0.05	0.04
query42	0.06	0.06	0.05
query43	0.06	0.05	0.05
Total cold run time: 105.63 s
Total hot run time: 30.48 s

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/175) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.06% (15508/27177)
Line Coverage 45.87% (138466/301860)
Region Coverage 35.29% (103544/293435)
Branch Coverage 37.77% (45602/120733)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 5c98c21 into apache:master Jul 12, 2025
23 of 25 checks passed
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Jul 17, 2025
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Jul 17, 2025
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Jul 17, 2025
dataroaring pushed a commit that referenced this pull request Jul 18, 2025
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Aug 18, 2025
dataroaring pushed a commit to Yukang-Lian/doris that referenced this pull request Aug 25, 2025
Yukang-Lian added a commit to Yukang-Lian/doris that referenced this pull request Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed usercase Important user case type label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants