Skip to content

Conversation

@Yukang-Lian
Copy link
Collaborator

Pick #52812

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Yukang-Lian Yukang-Lian requested a review from dataroaring as a code owner July 17, 2025 16:32
@Yukang-Lian Yukang-Lian changed the title [Cherry-Pick](branch-3.1) Pick "[Fix](Clone) Fix compaction and mow failure when missing rowset (#52812)" [Cherry-Pick](branch-3.0) Pick "[Fix](Clone) Fix compaction and mow failure when missing rowset (#52812)" Jul 17, 2025
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 80.98% (1171/1446)
Line Coverage 65.00% (19945/30686)
Region Coverage 66.51% (10049/15108)
Branch Coverage 56.17% (5304/9442)

@doris-robot
Copy link

TPC-H: Total hot run time: 40297 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit a90afb5d1f4a9d0cc53f27ada24c304d2b1770d8, data reload: false

------ Round 1 ----------------------------------
q1	17773	7023	6898	6898
q2	3758	173	182	173
q3	10682	1141	1193	1141
q4	10390	720	714	714
q5	7747	2924	2772	2772
q6	240	137	131	131
q7	985	615	617	615
q8	9361	1985	2028	1985
q9	6649	6420	6429	6420
q10	6954	2252	2315	2252
q11	452	259	272	259
q12	414	218	224	218
q13	17793	3001	3024	3001
q14	244	212	218	212
q15	512	469	479	469
q16	476	382	377	377
q17	1008	604	590	590
q18	7462	6737	6687	6687
q19	1407	1095	999	999
q20	505	205	209	205
q21	4013	3202	3238	3202
q22	1103	977	977	977
Total cold run time: 109928 ms
Total hot run time: 40297 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6668	6556	6600	6556
q2	325	230	228	228
q3	3115	3046	2984	2984
q4	2059	1802	1844	1802
q5	5649	5686	5792	5686
q6	204	127	129	127
q7	2262	1814	1820	1814
q8	3365	3533	3555	3533
q9	8920	8887	8943	8887
q10	3554	3553	3496	3496
q11	596	506	498	498
q12	797	621	573	573
q13	7312	3169	3088	3088
q14	305	275	285	275
q15	525	473	456	456
q16	484	439	461	439
q17	1868	1617	1607	1607
q18	8107	7706	7681	7681
q19	1711	1560	1547	1547
q20	2077	1898	1880	1880
q21	5093	4916	4801	4801
q22	1120	999	1002	999
Total cold run time: 66116 ms
Total hot run time: 58957 ms

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/175) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.21% (10948/26569)
Line Coverage 31.93% (93817/293826)
Region Coverage 31.09% (48379/155618)
Branch Coverage 27.53% (24778/90008)

@doris-robot
Copy link

TPC-DS: Total hot run time: 189685 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit a90afb5d1f4a9d0cc53f27ada24c304d2b1770d8, data reload: false

query1	1004	364	359	359
query2	6548	1878	1866	1866
query3	6703	212	220	212
query4	34037	23518	23519	23518
query5	4343	451	460	451
query6	272	178	185	178
query7	4625	306	309	306
query8	282	214	206	206
query9	9605	2604	2596	2596
query10	489	280	276	276
query11	18648	15217	15108	15108
query12	156	103	101	101
query13	1632	421	420	420
query14	9792	6832	6703	6703
query15	240	171	176	171
query16	8040	418	447	418
query17	1609	587	547	547
query18	2071	303	295	295
query19	212	151	146	146
query20	124	102	107	102
query21	204	103	101	101
query22	4302	4287	4166	4166
query23	34377	33471	33177	33177
query24	11376	2880	2823	2823
query25	671	396	383	383
query26	1445	166	159	159
query27	3077	342	340	340
query28	7949	2131	2131	2131
query29	906	437	440	437
query30	328	154	155	154
query31	1056	782	778	778
query32	100	58	62	58
query33	797	291	308	291
query34	931	494	524	494
query35	878	735	705	705
query36	1114	951	943	943
query37	133	73	75	73
query38	3970	3801	3843	3801
query39	1478	1406	1413	1406
query40	284	101	103	101
query41	56	51	52	51
query42	122	104	104	104
query43	519	469	486	469
query44	1271	806	802	802
query45	191	172	170	170
query46	1155	714	714	714
query47	1902	1820	1831	1820
query48	484	381	383	381
query49	1204	418	423	418
query50	822	439	427	427
query51	7212	7157	7131	7131
query52	107	90	92	90
query53	262	189	196	189
query54	1295	482	472	472
query55	81	79	79	79
query56	278	269	268	268
query57	1280	1169	1137	1137
query58	248	233	240	233
query59	3101	2891	2932	2891
query60	303	268	270	268
query61	128	140	134	134
query62	878	694	675	675
query63	223	197	206	197
query64	5474	767	713	713
query65	3277	3220	3178	3178
query66	1467	326	325	325
query67	15969	15492	15370	15370
query68	4429	591	605	591
query69	443	278	278	278
query70	1205	1074	1055	1055
query71	335	268	263	263
query72	6540	4129	4094	4094
query73	788	360	358	358
query74	10396	9012	9127	9012
query75	3356	2669	2650	2650
query76	2526	1090	1105	1090
query77	431	294	272	272
query78	10481	9595	9432	9432
query79	2314	625	612	612
query80	1137	433	422	422
query81	538	222	219	219
query82	939	91	99	91
query83	230	146	146	146
query84	248	77	76	76
query85	1345	302	290	290
query86	424	315	295	295
query87	4420	4198	4184	4184
query88	3756	2407	2361	2361
query89	415	294	302	294
query90	2033	194	188	188
query91	187	152	150	150
query92	61	53	53	53
query93	1562	573	560	560
query94	963	302	290	290
query95	362	263	262	262
query96	620	283	287	283
query97	3285	3110	3155	3110
query98	216	205	191	191
query99	1493	1331	1307	1307
Total cold run time: 302595 ms
Total hot run time: 189685 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.28 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit a90afb5d1f4a9d0cc53f27ada24c304d2b1770d8, data reload: false

query1	0.03	0.03	0.04
query2	0.07	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.10
query5	0.52	0.52	0.50
query6	1.12	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.50	0.51
query10	0.57	0.56	0.56
query11	0.15	0.10	0.10
query12	0.14	0.10	0.11
query13	0.62	0.60	0.62
query14	0.78	0.78	0.79
query15	0.83	0.82	0.82
query16	0.39	0.39	0.38
query17	1.07	1.06	1.01
query18	0.23	0.21	0.22
query19	1.94	1.87	1.81
query20	0.01	0.01	0.01
query21	15.41	0.59	0.59
query22	2.12	2.10	2.06
query23	16.81	1.17	0.76
query24	3.46	0.97	1.19
query25	0.17	0.20	0.04
query26	0.48	0.14	0.15
query27	0.05	0.04	0.03
query28	9.97	0.50	0.48
query29	12.60	3.25	3.23
query30	0.26	0.05	0.05
query31	2.86	0.38	0.38
query32	3.28	0.46	0.44
query33	2.92	2.98	3.03
query34	17.06	4.46	4.46
query35	4.55	4.52	4.51
query36	0.67	0.47	0.49
query37	0.08	0.06	0.06
query38	0.04	0.04	0.04
query39	0.04	0.02	0.02
query40	0.15	0.12	0.12
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.09 s
Total hot run time: 30.28 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 1.69% (3/178) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 50.11% (13140/26224)
Line Coverage 40.75% (119563/293433)
Region Coverage 38.45% (69320/180286)
Branch Coverage 32.93% (33514/101768)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dataroaring dataroaring merged commit 7811764 into apache:branch-3.0 Jul 18, 2025
23 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants