Skip to content

branch-3.1: [fix](json) incorrect results of json_contains #53291 #53439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 18, 2025
Merged

branch-3.1: [fix](json) incorrect results of json_contains #53291 #53439

morrySnow merged 1 commit into from
Jul 18, 2025

Conversation

@mrhhsg
Copy link
Member

@mrhhsg mrhhsg commented Jul 17, 2025 •
edited by morrySnow
Loading

picked from #53291

@mrhhsg mrhhsg requested a review from morrySnow as a code owner July 17, 2025 06:32
@mrhhsg
Copy link
Member Author

mrhhsg commented Jul 17, 2025

run buildall

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 17, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow changed the title [fix](json) incorrect results of json_contains (#53291) branch-3.1: [fix](json) incorrect results of json_contains #53291 Jul 17, 2025
@doris-robot
Copy link

doris-robot commented Jul 17, 2025

TPC-H: Total hot run time: 39881 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 12e2c76d313ace58a8237a20b3b591ce9c080154, data reload: false

------ Round 1 ----------------------------------
q1	17868	6848	6601	6601
q2	2094	185	167	167
q3	10646	1221	1226	1221
q4	10429	794	742	742
q5	7750	2885	2874	2874
q6	217	135	133	133
q7	999	621	605	605
q8	9363	1969	2008	1969
q9	6691	6443	6423	6423
q10	7026	2260	2320	2260
q11	457	256	254	254
q12	396	210	201	201
q13	17803	2968	3007	2968
q14	233	218	204	204
q15	518	471	465	465
q16	448	377	370	370
q17	1005	555	534	534
q18	7394	6632	6802	6632
q19	1357	1033	984	984
q20	484	197	197	197
q21	3945	3246	3065	3065
q22	1108	1012	1027	1012
Total cold run time: 108231 ms
Total hot run time: 39881 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6583	6561	6540	6540
q2	329	234	238	234
q3	2950	2939	2932	2932
q4	2040	1827	1747	1747
q5	5706	5793	5754	5754
q6	214	124	124	124
q7	2273	1829	1809	1809
q8	3357	3525	3561	3525
q9	8793	8943	8869	8869
q10	3556	3566	3523	3523
q11	588	488	487	487
q12	813	616	599	599
q13	8402	3135	3169	3135
q14	321	271	276	271
q15	498	463	466	463
q16	488	423	435	423
q17	1850	1663	1616	1616
q18	8354	7889	7527	7527
q19	1680	1646	1501	1501
q20	2116	1856	1830	1830
q21	5226	5145	5082	5082
q22	1122	1114	1070	1070
Total cold run time: 67259 ms
Total hot run time: 59061 ms

@doris-robot
Copy link

doris-robot commented Jul 17, 2025

TPC-DS: Total hot run time: 197270 ms 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 12e2c76d313ace58a8237a20b3b591ce9c080154, data reload: false

query1	1332	902	918	902
query2	6244	1944	1911	1911
query3	10938	4467	4761	4467
query4	33251	23386	23852	23386
query5	4366	469	440	440
query6	277	196	186	186
query7	3986	319	328	319
query8	301	219	217	217
query9	9566	2584	2586	2584
query10	468	260	249	249
query11	18383	15193	15115	15115
query12	161	111	105	105
query13	1555	413	434	413
query14	8533	6824	7041	6824
query15	221	190	203	190
query16	7863	529	503	503
query17	1626	600	604	600
query18	2107	322	323	322
query19	220	166	171	166
query20	122	125	129	125
query21	206	115	115	115
query22	4838	4537	4506	4506
query23	35477	34380	34512	34380
query24	12097	2958	2960	2958
query25	723	416	425	416
query26	1808	179	167	167
query27	2997	355	352	352
query28	7803	2182	2231	2182
query29	1097	471	474	471
query30	258	160	158	158
query31	1105	849	811	811
query32	103	58	59	58
query33	816	333	306	306
query34	1208	512	522	512
query35	856	727	707	707
query36	1115	953	1005	953
query37	292	69	66	66
query38	4104	3991	4031	3991
query39	1526	1463	1453	1453
query40	258	111	101	101
query41	49	48	45	45
query42	118	102	109	102
query43	530	512	495	495
query44	1280	812	824	812
query45	185	173	167	167
query46	1159	735	715	715
query47	2057	1939	1943	1939
query48	439	348	350	348
query49	1089	397	398	397
query50	835	433	424	424
query51	7351	7300	7297	7297
query52	103	88	89	88
query53	258	185	186	185
query54	1274	476	487	476
query55	81	79	80	79
query56	259	250	252	250
query57	1350	1241	1211	1211
query58	249	236	210	210
query59	3299	3109	3019	3019
query60	299	274	289	274
query61	112	114	133	114
query62	891	697	672	672
query63	223	189	198	189
query64	5055	681	643	643
query65	3357	3217	3191	3191
query66	1291	298	291	291
query67	15983	15531	15813	15531
query68	5081	591	585	585
query69	424	262	271	262
query70	1112	1087	1068	1068
query71	327	258	260	258
query72	6209	4020	4054	4020
query73	758	343	353	343
query74	10363	8928	9161	8928
query75	3383	2650	2653	2650
query76	2959	1089	1089	1089
query77	383	269	272	269
query78	10577	9590	9653	9590
query79	1732	603	594	594
query80	1119	422	431	422
query81	536	225	218	218
query82	931	94	88	88
query83	234	142	137	137
query84	232	78	80	78
query85	1368	301	296	296
query86	373	312	307	307
query87	4369	4205	4199	4199
query88	3722	2411	2388	2388
query89	422	288	292	288
query90	2017	181	185	181
query91	161	104	115	104
query92	60	51	57	51
query93	2115	551	562	551
query94	943	292	295	292
query95	359	252	256	252
query96	607	278	277	277
query97	3308	3143	3176	3143
query98	213	199	195	195
query99	1528	1309	1296	1296
Total cold run time: 307308 ms
Total hot run time: 197270 ms

@doris-robot
Copy link

doris-robot commented Jul 17, 2025

ClickBench: Total hot run time: 30.31 s 
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 12e2c76d313ace58a8237a20b3b591ce9c080154, data reload: false

query1	0.04	0.04	0.03
query2	0.07	0.03	0.03
query3	0.24	0.06	0.06
query4	1.63	0.11	0.11
query5	0.52	0.52	0.50
query6	1.13	0.72	0.73
query7	0.03	0.02	0.02
query8	0.03	0.03	0.03
query9	0.57	0.51	0.52
query10	0.56	0.55	0.55
query11	0.15	0.11	0.10
query12	0.14	0.12	0.10
query13	0.60	0.60	0.59
query14	0.76	0.81	0.80
query15	0.84	0.83	0.82
query16	0.39	0.39	0.39
query17	1.07	1.00	1.04
query18	0.23	0.23	0.22
query19	1.94	1.80	1.89
query20	0.01	0.01	0.01
query21	15.41	0.58	0.57
query22	2.10	2.06	1.49
query23	16.86	0.99	0.85
query24	3.10	1.68	1.40
query25	0.25	0.11	0.11
query26	0.48	0.14	0.13
query27	0.07	0.04	0.04
query28	9.37	0.56	0.43
query29	12.58	3.19	3.18
query30	0.24	0.06	0.06
query31	2.88	0.40	0.40
query32	3.23	0.48	0.46
query33	2.99	3.01	2.99
query34	16.88	4.48	4.50
query35	4.56	4.55	4.59
query36	0.69	0.50	0.48
query37	0.09	0.07	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.17	0.13	0.13
query41	0.07	0.02	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.02
Total cold run time: 103.11 s
Total hot run time: 30.31 s

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 17, 2025

BE UT Coverage Report

Increment line coverage 0.00% (0/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 45.25% (12538/27708)
Line Coverage 36.10% (111374/308493)
Region Coverage 35.18% (57604/163741)
Branch Coverage 32.36% (31313/96758)

@hello-stephen
Copy link
Contributor

hello-stephen commented Jul 17, 2025

BE Regression && UT Coverage Report

Increment line coverage 100.00% (6/6) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 75.79% (20747/27375)
Line Coverage 69.10% (212991/308255)
Region Coverage 67.05% (127247/189783)
Branch Coverage 60.71% (66264/109144)

@morrySnow morrySnow merged commit 0cecab4 into apache:branch-3.1 Jul 18, 2025
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mrhhsg @hello-stephen @doris-robot @morrySnow