Skip to content

Conversation

@Yukang-Lian
Copy link
Collaborator

Pick #53193

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Yukang-Lian Yukang-Lian requested a review from dataroaring as a code owner July 18, 2025 07:15
@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Yukang-Lian
Copy link
Collaborator Author

run buildall

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 41.84% (11116/26571)
Line Coverage 32.40% (95226/293891)
Region Coverage 31.57% (49141/155663)
Branch Coverage 27.96% (25173/90034)

@doris-robot
Copy link

TPC-H: Total hot run time: 40165 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 563e52918b38fa86d3c90a7fb6a0fc71b9e2e122, data reload: false

------ Round 1 ----------------------------------
q1	17827	6929	7033	6929
q2	2080	178	163	163
q3	10626	1166	1165	1165
q4	10418	753	683	683
q5	7752	2900	2870	2870
q6	212	136	135	135
q7	974	637	589	589
q8	9349	2010	2034	2010
q9	6651	6425	6431	6425
q10	7065	2222	2301	2222
q11	469	261	274	261
q12	413	209	211	209
q13	17780	2954	2989	2954
q14	241	205	212	205
q15	510	467	472	467
q16	504	376	371	371
q17	976	555	583	555
q18	7301	6662	6708	6662
q19	1389	1096	1094	1094
q20	459	197	203	197
q21	4231	3112	3015	3015
q22	1090	999	984	984
Total cold run time: 108317 ms
Total hot run time: 40165 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6719	6552	6566	6552
q2	327	231	228	228
q3	2913	2959	2933	2933
q4	2101	1857	1751	1751
q5	5710	5786	5742	5742
q6	211	127	131	127
q7	2217	1849	1794	1794
q8	3349	3582	3527	3527
q9	8770	8952	8893	8893
q10	3564	3549	3518	3518
q11	604	504	492	492
q12	818	612	591	591
q13	7623	3153	3205	3153
q14	298	272	277	272
q15	516	456	473	456
q16	483	434	451	434
q17	1858	1653	1605	1605
q18	8238	7698	7742	7698
q19	1662	1523	1590	1523
q20	2147	1886	1864	1864
q21	5228	4905	5075	4905
q22	1210	1022	1018	1018
Total cold run time: 66566 ms
Total hot run time: 59076 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 195791 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 563e52918b38fa86d3c90a7fb6a0fc71b9e2e122, data reload: false

query1	1262	920	886	886
query2	6234	1865	1859	1859
query3	10946	4340	4443	4340
query4	33196	23555	23380	23380
query5	3574	467	483	467
query6	281	184	194	184
query7	4003	309	316	309
query8	301	230	226	226
query9	9436	2577	2559	2559
query10	491	264	258	258
query11	18326	15220	15226	15220
query12	170	100	101	100
query13	1544	435	419	419
query14	9195	6583	6629	6583
query15	256	190	191	190
query16	7900	471	479	471
query17	1617	585	601	585
query18	2179	324	313	313
query19	215	168	166	166
query20	125	112	111	111
query21	202	107	107	107
query22	4901	4521	4529	4521
query23	35078	34209	33850	33850
query24	12330	2924	2921	2921
query25	693	424	451	424
query26	1430	174	172	172
query27	2987	350	358	350
query28	7640	2169	2220	2169
query29	918	474	452	452
query30	272	153	159	153
query31	1053	806	849	806
query32	94	54	53	53
query33	748	316	305	305
query34	980	513	511	511
query35	912	722	715	715
query36	1091	944	951	944
query37	130	66	64	64
query38	4086	3935	3995	3935
query39	1525	1470	1480	1470
query40	253	104	104	104
query41	49	51	48	48
query42	120	102	103	102
query43	536	475	483	475
query44	1296	809	816	809
query45	179	170	167	167
query46	1166	724	749	724
query47	2008	1883	1948	1883
query48	468	387	381	381
query49	897	396	392	392
query50	826	421	428	421
query51	7399	7216	7226	7216
query52	101	92	89	89
query53	257	184	183	183
query54	1119	462	458	458
query55	82	81	80	80
query56	268	242	245	242
query57	1298	1224	1203	1203
query58	235	207	215	207
query59	3109	2960	2873	2873
query60	302	252	253	252
query61	110	111	109	109
query62	881	706	697	697
query63	225	197	188	188
query64	4051	688	671	671
query65	3303	3301	3262	3262
query66	789	303	298	298
query67	16050	15565	15505	15505
query68	4584	583	568	568
query69	433	262	259	259
query70	1210	1053	1141	1053
query71	352	262	251	251
query72	6308	4033	3977	3977
query73	738	347	348	347
query74	10542	8947	9286	8947
query75	3382	2649	2668	2649
query76	2645	1107	1007	1007
query77	376	270	264	264
query78	10625	9573	9638	9573
query79	1638	580	570	570
query80	889	426	417	417
query81	556	218	217	217
query82	708	89	87	87
query83	251	144	150	144
query84	238	77	80	77
query85	1579	301	286	286
query86	465	295	285	285
query87	4385	4266	4256	4256
query88	4395	2374	2355	2355
query89	416	293	288	288
query90	1973	184	184	184
query91	184	152	145	145
query92	60	49	51	49
query93	2564	533	542	533
query94	819	293	295	293
query95	369	260	258	258
query96	606	273	280	273
query97	3276	3127	3151	3127
query98	230	197	200	197
query99	1520	1316	1268	1268
Total cold run time: 304014 ms
Total hot run time: 195791 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.43 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 563e52918b38fa86d3c90a7fb6a0fc71b9e2e122, data reload: false

query1	0.03	0.03	0.03
query2	0.08	0.02	0.03
query3	0.24	0.07	0.06
query4	1.62	0.11	0.11
query5	0.52	0.54	0.53
query6	1.14	0.74	0.73
query7	0.02	0.01	0.01
query8	0.04	0.03	0.03
query9	0.56	0.50	0.50
query10	0.55	0.56	0.57
query11	0.14	0.10	0.11
query12	0.14	0.12	0.11
query13	0.60	0.60	0.59
query14	0.78	0.78	0.80
query15	0.84	0.82	0.82
query16	0.38	0.39	0.39
query17	1.09	1.05	1.03
query18	0.23	0.22	0.23
query19	1.91	1.91	1.84
query20	0.02	0.01	0.01
query21	15.39	0.59	0.55
query22	2.41	1.94	1.46
query23	17.13	0.94	0.91
query24	2.68	0.50	1.44
query25	0.20	0.18	0.06
query26	0.44	0.14	0.14
query27	0.04	0.06	0.05
query28	10.97	0.50	0.44
query29	12.56	3.26	3.20
query30	0.25	0.06	0.06
query31	2.87	0.38	0.39
query32	3.23	0.46	0.46
query33	2.95	2.96	2.98
query34	17.11	4.50	4.50
query35	4.57	4.59	4.52
query36	0.68	0.47	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.04
query39	0.04	0.02	0.02
query40	0.15	0.12	0.13
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.87 s
Total hot run time: 29.43 s

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 0.00% (0/5) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 74.97% (19660/26225)
Line Coverage 68.21% (200200/293495)
Region Coverage 66.31% (119527/180267)
Branch Coverage 59.65% (60711/101772)

Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 19, 2025
@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

@dataroaring dataroaring merged commit da37cab into apache:branch-3.0 Jul 20, 2025
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants