Skip to content

[Cherry-Pick](branch-3.0) Pick "[Enhancement](Log) Missing rowset clone should not print stack log (#53193)" #53527

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dataroaring merged 1 commit into from
Jul 20, 2025
Merged

[Cherry-Pick](branch-3.0) Pick "[Enhancement](Log) Missing rowset clone should not print stack log (#53193)" #53527

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion be/src/olap/cumulative_compaction.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ Status CumulativeCompaction::pick_rowsets_to_compact() {
Status st = _engine.submit_clone_task(tablet(), missing_versions.back().first);
if (!st) {
LOG_WARNING("cumulative compaction failed to submit missing rowset clone task.")
.tag("st", st.to_string())
.tag("st", st.msg())
.tag("tablet_id", _tablet->tablet_id())
.tag("version", missing_versions.back().first)
.tag("replica_id", tablet()->replica_id())
Expand Down
5 changes: 3 additions & 2 deletions be/src/olap/storage_engine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1472,6 +1472,7 @@ bool StorageEngine::get_peers_replica_backends(int64_t tablet_id, std::vector<TB
int64_t cur_time = UnixMillis();
if (cur_time - _last_get_peers_replica_backends_time_ms < 10000) {
LOG_WARNING("failed to get peers replica backens.")
.tag("tablet_id", tablet_id)
.tag("last time", _last_get_peers_replica_backends_time_ms)
.tag("cur time", cur_time);
return false;
Expand Down Expand Up @@ -1653,8 +1654,8 @@ Status StorageEngine::_persist_broken_paths() {
Status StorageEngine::submit_clone_task(Tablet* tablet, int64_t version) {
std::vector<TBackend> backends;
if (!get_peers_replica_backends(tablet->tablet_id(), &backends)) {
LOG(WARNING) << tablet->tablet_id() << " tablet doesn't have peer replica backends";
return Status::InternalError("");
return Status::Error<ErrorCode::INTERNAL_ERROR, false>(
"get_peers_replica_backends failed.");
}
TAgentTaskRequest task;
TCloneReq req;
Expand Down
2 changes: 1 addition & 1 deletion be/src/olap/task/engine_publish_version_task.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,7 +228,7 @@ Status EnginePublishVersionTask::execute() {
if (!st) {
LOG_WARNING(
"mow publish failed to submit missing rowset clone task.")
.tag("st", st.to_string())
.tag("st", st.msg())
.tag("tablet_id", tablet->tablet_id())
.tag("version", version.first - 1)
.tag("replica_id", tablet->replica_id())
Expand Down
Loading