Skip to content

branch-3.1: [test](p2) allow protocol prefix in S3 endpoint format in test_broker_load #53525 #53615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
morrySnow merged 1 commit into from
Jul 22, 2025
Merged

branch-3.1: [test](p2) allow protocol prefix in S3 endpoint format in test_broker_load #53525 #53615

morrySnow merged 1 commit into from
Jul 22, 2025

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 21, 2025

Cherry-picked from #53525

@kaijchen
[test](p2) allow protocol prefix in S3 endpoint format in test_broker…
a761ddd 
…_load (#53525)

Related PR: #51529

Problem Summary:

PR #51529 introduced a change that adds `http://` to S3 endpoints if no
protocol is specified.
For example, `cluster:${s3Endpoint}` could become
`cluster:http://${s3Endpoint}`.
This PR updates the test logic to accept S3 endpoints with extra
protocol prefix .
@github-actions github-actions bot requested a review from morrySnow as a code owner July 21, 2025 03:26
@Thearas
Copy link
Contributor

Thearas commented Jul 21, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@dataroaring dataroaring reopened this Jul 21, 2025
@Thearas
Copy link
Contributor

Thearas commented Jul 21, 2025

run buildall

@morrySnow morrySnow merged commit b9a7183 into branch-3.1 Jul 22, 2025
22 checks passed
@morrySnow morrySnow deleted the auto-pick-53525-branch-3.1 branch July 22, 2025 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morrySnow morrySnow morrySnow approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@Thearas @morrySnow @dataroaring @kaijchen