Skip to content

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Jul 30, 2025

This reverts commit a73d082.

@deardeng deardeng requested a review from morrySnow as a code owner July 30, 2025 03:34
@Thearas
Copy link
Contributor

Thearas commented Jul 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@morrySnow morrySnow changed the title Revert "branch-3.1: [fix](trash) Fix shadow variable causing garbage … Revert "branch-3.1: [fix](trash) Fix shadow variable causing garbage scheduling time errors #51647 (#52029)" Jul 30, 2025
@morrySnow
Copy link
Contributor

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32274 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 38e39562b7beab5d14386c665314a2bce03d6d97, data reload: false

------ Round 1 ----------------------------------
q1	17577	5570	5419	5419
q2	2049	279	158	158
q3	10564	1218	755	755
q4	10257	861	442	442
q5	8546	2363	2106	2106
q6	177	165	135	135
q7	890	766	619	619
q8	9327	1411	1227	1227
q9	5252	4887	4865	4865
q10	6770	2308	1839	1839
q11	480	294	256	256
q12	336	357	213	213
q13	17761	3575	2967	2967
q14	222	231	207	207
q15	517	472	458	458
q16	421	422	377	377
q17	600	856	366	366
q18	6848	6308	6185	6185
q19	1881	983	549	549
q20	319	343	203	203
q21	2758	2163	1966	1966
q22	1040	1015	962	962
Total cold run time: 104592 ms
Total hot run time: 32274 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5624	6193	5509	5509
q2	236	325	237	237
q3	2195	2597	2320	2320
q4	1331	1776	1296	1296
q5	4391	4830	5007	4830
q6	169	161	128	128
q7	2072	1938	1797	1797
q8	2614	2810	2738	2738
q9	7239	7251	7325	7251
q10	2991	3315	2807	2807
q11	561	496	493	493
q12	624	757	624	624
q13	3436	3839	3198	3198
q14	283	302	264	264
q15	503	466	468	466
q16	433	492	456	456
q17	1219	1737	1238	1238
q18	7507	7459	7221	7221
q19	825	1056	1099	1056
q20	1964	2060	1885	1885
q21	5341	4924	4592	4592
q22	1057	1045	979	979
Total cold run time: 52615 ms
Total hot run time: 51385 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 196713 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 38e39562b7beab5d14386c665314a2bce03d6d97, data reload: false

query1	1287	963	889	889
query2	6245	1987	1862	1862
query3	10926	4562	4539	4539
query4	32531	23756	23500	23500
query5	3809	620	457	457
query6	262	187	186	186
query7	3981	486	317	317
query8	293	267	229	229
query9	9481	2594	2580	2580
query10	488	322	261	261
query11	17902	15397	15111	15111
query12	159	108	106	106
query13	1575	555	425	425
query14	10399	6516	7082	6516
query15	229	193	184	184
query16	7913	657	484	484
query17	1617	769	625	625
query18	2088	416	309	309
query19	206	205	168	168
query20	130	121	126	121
query21	206	127	125	125
query22	4688	4385	4346	4346
query23	34616	33893	33855	33855
query24	7212	2650	2709	2650
query25	500	471	404	404
query26	862	286	182	182
query27	2071	475	357	357
query28	5163	2238	2177	2177
query29	628	568	453	453
query30	245	196	168	168
query31	951	930	818	818
query32	75	61	54	54
query33	491	352	302	302
query34	767	860	516	516
query35	794	832	746	746
query36	1012	1040	974	974
query37	105	96	72	72
query38	3973	4007	3988	3988
query39	1559	1497	1513	1497
query40	210	120	102	102
query41	49	49	48	48
query42	126	104	104	104
query43	514	527	475	475
query44	1364	833	851	833
query45	187	190	175	175
query46	890	1059	665	665
query47	1927	1968	1908	1908
query48	425	420	353	353
query49	738	496	403	403
query50	710	686	446	446
query51	7416	7303	7196	7196
query52	99	108	94	94
query53	233	260	195	195
query54	577	561	469	469
query55	79	76	81	76
query56	290	269	256	256
query57	1257	1267	1198	1198
query58	239	224	220	220
query59	3057	3142	3078	3078
query60	302	304	281	281
query61	156	145	128	128
query62	814	784	720	720
query63	238	207	201	201
query64	3393	1034	637	637
query65	3342	3316	3268	3268
query66	807	412	300	300
query67	16194	15690	15593	15593
query68	2874	863	580	580
query69	491	309	262	262
query70	1200	1159	1101	1101
query71	392	290	264	264
query72	5763	3726	3884	3726
query73	637	752	357	357
query74	10210	9254	9352	9254
query75	3159	3135	2656	2656
query76	2989	1171	773	773
query77	472	362	295	295
query78	10397	10308	9750	9750
query79	2897	920	597	597
query80	1722	535	465	465
query81	566	266	225	225
query82	353	124	92	92
query83	250	175	160	160
query84	246	103	82	82
query85	853	449	364	364
query86	462	309	289	289
query87	4253	4318	4222	4222
query88	5173	2460	2431	2431
query89	400	340	299	299
query90	1778	191	197	191
query91	154	154	150	150
query92	69	56	54	54
query93	2757	890	539	539
query94	728	415	307	307
query95	336	271	270	270
query96	498	607	295	295
query97	3152	3280	3155	3155
query98	232	208	204	204
query99	1354	1420	1329	1329
Total cold run time: 289889 ms
Total hot run time: 196713 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.22 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 38e39562b7beab5d14386c665314a2bce03d6d97, data reload: false

query1	0.04	0.04	0.03
query2	0.06	0.03	0.03
query3	0.23	0.07	0.06
query4	1.63	0.10	0.11
query5	0.52	0.51	0.51
query6	1.13	0.73	0.73
query7	0.02	0.02	0.02
query8	0.04	0.04	0.03
query9	0.57	0.50	0.52
query10	0.55	0.56	0.55
query11	0.15	0.11	0.11
query12	0.16	0.11	0.11
query13	0.61	0.59	0.59
query14	0.77	0.79	0.77
query15	0.84	0.83	0.84
query16	0.38	0.39	0.39
query17	0.97	1.00	0.96
query18	0.24	0.22	0.22
query19	1.91	1.80	1.81
query20	0.01	0.01	0.02
query21	15.45	0.92	0.59
query22	0.74	0.74	0.64
query23	15.22	1.43	0.51
query24	2.93	1.59	1.46
query25	0.13	0.16	0.06
query26	0.27	0.16	0.13
query27	0.06	0.05	0.05
query28	14.35	1.01	0.44
query29	12.57	3.93	3.27
query30	0.25	0.10	0.06
query31	2.82	0.58	0.38
query32	3.22	0.54	0.45
query33	2.98	3.00	3.05
query34	16.72	5.13	4.50
query35	4.55	4.58	4.55
query36	0.66	0.49	0.48
query37	0.08	0.06	0.06
query38	0.04	0.03	0.03
query39	0.03	0.03	0.02
query40	0.17	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.04	0.03	0.03
Total cold run time: 104.22 s
Total hot run time: 29.22 s

@morrySnow morrySnow merged commit 2a1f9c4 into apache:branch-3.1 Jul 30, 2025
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants