Skip to content

Conversation

@deardeng
Copy link
Contributor

@deardeng deardeng commented Jun 11, 2025

What problem does this PR solve?

shadow variable lead to curr_interval always equal 300s

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@deardeng
Copy link
Contributor Author

run buildall

@hello-stephen
Copy link
Contributor

BE UT Coverage Report

Increment line coverage 0.00% (0/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 56.49% (15100/26729)
Line Coverage 45.22% (134900/298297)
Region Coverage 44.33% (67900/153160)
Branch Coverage 38.89% (34829/89564)

@hello-stephen
Copy link
Contributor

BE Regression && UT Coverage Report

Increment line coverage 100.00% (3/3) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 79.72% (20973/26307)
Line Coverage 72.70% (216756/298147)
Region Coverage 70.93% (127779/180156)
Branch Coverage 64.64% (66179/102380)

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jun 12, 2025
@github-actions
Copy link
Contributor

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

PR approved by anyone and no changes requested.

Copy link
Contributor

@sollhui sollhui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gavinchou gavinchou merged commit 9c8cf19 into apache:master Jun 12, 2025
27 of 29 checks passed
github-actions bot pushed a commit that referenced this pull request Jun 12, 2025
…rs (#51647)

shadow variable lead to curr_interval always equal 300s
@doris-robot
Copy link

TPC-H: Total hot run time: 34082 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1aaaae9db45edf4b4df098fc351d73f08b10f340, data reload: false

------ Round 1 ----------------------------------
q1	26333	5065	5054	5054
q2	1961	287	175	175
q3	10388	1237	699	699
q4	10237	1011	531	531
q5	7626	2356	2375	2356
q6	198	165	137	137
q7	910	760	610	610
q8	9307	1240	1125	1125
q9	6844	5164	5119	5119
q10	6874	2320	1924	1924
q11	496	299	279	279
q12	344	353	219	219
q13	17772	3730	3090	3090
q14	233	239	227	227
q15	561	485	492	485
q16	453	435	375	375
q17	618	885	367	367
q18	7756	7260	7098	7098
q19	2100	1043	576	576
q20	329	354	228	228
q21	3716	3228	2420	2420
q22	1017	998	988	988
Total cold run time: 116073 ms
Total hot run time: 34082 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5267	5086	5106	5086
q2	236	318	226	226
q3	2179	2650	2322	2322
q4	1361	1778	1454	1454
q5	4482	4370	4435	4370
q6	219	167	130	130
q7	2001	1955	1752	1752
q8	2602	2668	2606	2606
q9	7244	7270	6967	6967
q10	3042	3226	2737	2737
q11	587	515	522	515
q12	700	776	632	632
q13	3518	3905	3375	3375
q14	276	301	297	297
q15	539	482	479	479
q16	444	474	449	449
q17	1177	1549	1394	1394
q18	7892	7563	7412	7412
q19	878	850	957	850
q20	1980	2064	1841	1841
q21	4885	4541	4401	4401
q22	1084	1056	1003	1003
Total cold run time: 52593 ms
Total hot run time: 50298 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 193289 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1aaaae9db45edf4b4df098fc351d73f08b10f340, data reload: false

query1	1424	1086	1035	1035
query2	6252	1781	1772	1772
query3	11016	4645	4545	4545
query4	53280	25355	23590	23590
query5	5223	516	482	482
query6	358	213	201	201
query7	4894	526	296	296
query8	286	240	229	229
query9	5730	2655	2667	2655
query10	481	335	292	292
query11	15019	15125	14789	14789
query12	162	111	105	105
query13	1057	523	413	413
query14	10041	6292	6394	6292
query15	202	203	188	188
query16	7045	661	538	538
query17	1108	771	600	600
query18	1581	429	336	336
query19	215	211	172	172
query20	128	133	129	129
query21	210	129	115	115
query22	4437	4556	4492	4492
query23	34480	33600	33658	33600
query24	6606	2408	2488	2408
query25	459	504	439	439
query26	730	274	169	169
query27	2371	516	352	352
query28	3000	2172	2151	2151
query29	598	569	430	430
query30	282	218	191	191
query31	882	862	787	787
query32	76	69	65	65
query33	486	404	319	319
query34	808	886	529	529
query35	793	840	739	739
query36	959	1015	883	883
query37	110	102	77	77
query38	4282	4275	4256	4256
query39	1546	1630	1482	1482
query40	212	126	114	114
query41	67	61	60	60
query42	125	117	111	111
query43	500	520	483	483
query44	1353	869	849	849
query45	186	187	171	171
query46	872	1053	660	660
query47	1845	1853	1763	1763
query48	407	437	330	330
query49	670	510	401	401
query50	695	713	416	416
query51	4317	4306	4240	4240
query52	112	116	104	104
query53	233	263	196	196
query54	597	606	533	533
query55	82	87	86	86
query56	318	327	301	301
query57	1219	1216	1155	1155
query58	278	262	268	262
query59	2595	2734	2615	2615
query60	351	334	329	329
query61	139	129	146	129
query62	732	737	715	715
query63	226	199	196	196
query64	1982	1033	740	740
query65	4244	4153	4171	4153
query66	748	393	306	306
query67	16010	15806	15220	15220
query68	7440	894	532	532
query69	531	311	270	270
query70	1245	1105	1077	1077
query71	497	342	297	297
query72	5948	4731	4724	4724
query73	1251	619	359	359
query74	9191	8930	8797	8797
query75	3802	3199	2735	2735
query76	4107	1198	763	763
query77	617	381	296	296
query78	10218	10127	9405	9405
query79	2473	830	588	588
query80	681	520	501	501
query81	470	264	222	222
query82	486	130	102	102
query83	263	257	234	234
query84	297	103	82	82
query85	798	354	323	323
query86	412	301	294	294
query87	4353	4441	4336	4336
query88	3183	2301	2297	2297
query89	421	316	290	290
query90	1759	217	219	217
query91	140	153	114	114
query92	74	64	61	61
query93	2247	938	590	590
query94	665	387	307	307
query95	382	292	286	286
query96	502	599	281	281
query97	2735	2777	2646	2646
query98	237	216	215	215
query99	1435	1405	1267	1267
Total cold run time: 298592 ms
Total hot run time: 193289 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 29.37 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 1aaaae9db45edf4b4df098fc351d73f08b10f340, data reload: false

query1	0.04	0.04	0.04
query2	0.13	0.11	0.11
query3	0.25	0.20	0.20
query4	1.59	0.20	0.20
query5	0.46	0.44	0.44
query6	1.18	0.67	0.66
query7	0.02	0.02	0.02
query8	0.05	0.03	0.04
query9	0.61	0.52	0.51
query10	0.58	0.56	0.56
query11	0.16	0.11	0.11
query12	0.15	0.11	0.12
query13	0.62	0.58	0.60
query14	0.80	0.80	0.80
query15	0.87	0.86	0.87
query16	0.39	0.37	0.41
query17	1.00	1.05	1.08
query18	0.23	0.21	0.21
query19	1.95	1.82	1.89
query20	0.02	0.01	0.01
query21	15.40	0.90	0.55
query22	0.75	1.18	0.72
query23	14.91	1.37	0.67
query24	6.86	1.46	0.90
query25	0.48	0.33	0.06
query26	0.62	0.17	0.14
query27	0.06	0.05	0.05
query28	9.64	0.92	0.43
query29	12.56	4.10	3.42
query30	0.25	0.09	0.06
query31	2.82	0.59	0.39
query32	3.22	0.55	0.48
query33	3.05	3.00	3.07
query34	15.93	5.12	4.51
query35	4.53	4.50	4.50
query36	0.65	0.50	0.48
query37	0.09	0.06	0.06
query38	0.04	0.04	0.04
query39	0.03	0.03	0.02
query40	0.17	0.16	0.13
query41	0.08	0.02	0.02
query42	0.03	0.02	0.02
query43	0.04	0.04	0.03
Total cold run time: 103.31 s
Total hot run time: 29.37 s

dataroaring pushed a commit that referenced this pull request Jun 20, 2025
…ng time errors #51647 (#51687)

Cherry-picked from #51647

Co-authored-by: deardeng <dengxin@selectdb.com>
github-actions bot pushed a commit that referenced this pull request Jun 20, 2025
…rs (#51647)

shadow variable lead to curr_interval always equal 300s
github-actions bot pushed a commit that referenced this pull request Jun 20, 2025
…rs (#51647)

shadow variable lead to curr_interval always equal 300s
morrySnow pushed a commit that referenced this pull request Jun 20, 2025
…ng time errors #51647 (#52029)

Cherry-picked from #51647

Co-authored-by: deardeng <dengxin@selectdb.com>
yiguolei pushed a commit that referenced this pull request Jun 28, 2025
…ng time errors #51647 (#51996)

Cherry-picked from #51647

Co-authored-by: deardeng <dengxin@selectdb.com>
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Jul 30, 2025
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Jul 30, 2025
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Jul 30, 2025
deardeng added a commit to deardeng/incubator-doris that referenced this pull request Jul 30, 2025
morrySnow pushed a commit that referenced this pull request Jul 30, 2025
dataroaring pushed a commit that referenced this pull request Jul 31, 2025
dataroaring pushed a commit that referenced this pull request Aug 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by one committer. dev/3.0.7-merged dev/3.1.0-merged reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants